From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4506421184E91 for ; Wed, 31 Oct 2018 01:56:46 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2018 01:56:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,447,1534834800"; d="scan'208";a="85582915" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 31 Oct 2018 01:56:45 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 31 Oct 2018 01:56:45 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 31 Oct 2018 01:56:45 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.214]) with mapi id 14.03.0415.000; Wed, 31 Oct 2018 16:56:43 +0800 From: "Ni, Ruiyu" To: Jeff Brasen , "edk2-devel@lists.01.org" CC: "Gao, Liming" , "Kinney, Michael D" Thread-Topic: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types Thread-Index: AQHUcJfz8lNZgpaaUEydadxSWGi2eqU5DGLg Date: Wed, 31 Oct 2018 08:56:42 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BEE8DCE@SHSMSX104.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Oct 2018 08:56:46 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable SortLib depends on MemoryAllocationLib. How can it be a BASE type library? Can we do it in two options? 1. Change the SortLib API to accept a temporary buffer from caller. So the = MemoryAllocationlIb dependency can be removed. 2. Do not change SortLibAPI but uses a fixed-size temporary buffer internal= ly. E.g.: UINT8 Buffer[MAX_ELEMENT_SIZE]; Thanks/Ray > -----Original Message----- > From: edk2-devel On Behalf Of Jeff > Brasen > Sent: Wednesday, October 31, 2018 5:31 AM > To: edk2-devel@lists.01.org > Cc: Jeff Brasen > Subject: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all > module types >=20 > Expose BaseSortLib for use in SEC and PEI phases. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jeff Brasen > --- > MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > index f807cd7..5bd1aa1 100644 > --- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > +++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > @@ -18,9 +18,9 @@ > BASE_NAME =3D BaseSortLib > MODULE_UNI_FILE =3D BaseSortLib.uni > FILE_GUID =3D 03F3331B-F12D-494f-BF37-E55A657F249= 7 > - MODULE_TYPE =3D UEFI_DRIVER > + MODULE_TYPE =3D BASE > VERSION_STRING =3D 1.0 > - LIBRARY_CLASS =3D SortLib|DXE_DRIVER DXE_RUNTIME_DRIV= ER > UEFI_APPLICATION UEFI_DRIVER > + LIBRARY_CLASS =3D SortLib >=20 > # > # VALID_ARCHITECTURES =3D IA32 X64 EBC > -- > 2.7.4 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel