public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "'afish@apple.com'" <afish@apple.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Gerd Hoffmann <kraxel@redhat.com>,
	 Laszlo Ersek <lersek@redhat.com>,
	"Richardson, Brian" <brian.richardson@intel.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Kevin O'Connor <kevin@koconnor.net>
Subject: Re: Drop CSM support in OvmfPkg?
Date: Wed, 23 Jan 2019 04:29:38 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BFCFAA5@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <CE5C7FE9-6F25-42A0-9F09-23ADE83F3F7E@apple.com>

Andrew,
Do you have any specific concerns if we move csm out of edk2 repo, to a repo owned by David?

As David mentioned, VM can switch between firmware images. It 's just somehow difficult in certain environment. Maybe for the long term consideration, enhancing the VM to support easily switching firmware images makes a little more sense.

Thanks,
Ray

From: afish@apple.com <afish@apple.com>
Sent: Wednesday, January 23, 2019 12:01 PM
To: Ni, Ray <ray.ni@intel.com>
Cc: David Woodhouse <dwmw2@infradead.org>; Gerd Hoffmann <kraxel@redhat.com>; Laszlo Ersek <lersek@redhat.com>; Richardson, Brian <brian.richardson@intel.com>; Anthony Perard <anthony.perard@citrix.com>; Justen, Jordan L <jordan.l.justen@intel.com>; edk2-devel@lists.01.org; Kevin O'Connor <kevin@koconnor.net>
Subject: Re: [edk2] Drop CSM support in OvmfPkg?




On Jan 22, 2019, at 7:43 PM, Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> wrote:

-----Original Message-----
From: David Woodhouse <dwmw2@infradead.org<mailto:dwmw2@infradead.org>>
Sent: Wednesday, January 23, 2019 12:23 AM
To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Gerd Hoffmann <kraxel@redhat.com<mailto:kraxel@redhat.com>>;
Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>; Richardson, Brian
<brian.richardson@intel.com<mailto:brian.richardson@intel.com>>
Cc: Justen, Jordan L <jordan.l.justen@intel.com<mailto:jordan.l.justen@intel.com>>; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>;
Kevin O'Connor <kevin@koconnor.net<mailto:kevin@koconnor.net>>; Anthony Perard
<anthony.perard@citrix.com<mailto:anthony.perard@citrix.com>>
Subject: Re: Drop CSM support in OvmfPkg?

On Tue, 2019-01-22 at 16:13 +0000, Ni, Ray wrote:

David,
I'd like to re-start the discussion.
Could you please kindly explain the background/reason of adding CSM
support in OVMF?
Maybe knowing the reason can help to make further decisions of
whether to
A. keep it outside OvmfPkg
B. keep it inside OvmfPkg
C. maybe have a chance to just remove the CSM support after
revisiting


The idea was to make it simple to have a single firmware image for
virtual machines which would support both UEFI and Legacy boot for
guests simultaneously.

In libvirt there has been an alternative approach, where the BIOS image
is switched between OVMF and SeaBIOS according to the configuration of
the guest VM.

That's fine for libvirt, but in situations where VM hosting is provided
as a service, it becomes quite painful to manage the 'UEFI' vs.
'Legacy' flags on guest images and then switch firmware images
accordingly. A one-size-fits-all BIOS using OVMF+CSM is very much
preferable.

David,
Thanks for sharing. I now understand that you do have a need of
CSM + UEFI OVMF image.
A very straightforward idea is to move all COM components you needed
into OvmfPkg. But Laszlo as the OvmfPkg owner may disagree with this.
So maybe you could set up another (github) repo and clone all the CSM components
there.
EDKII build tool supports to build firmware from multiple repos.
That's how we can have edk2-platforms and to-be-created edk2-app.
In practical, you could create a new csm repo.
Laszlo/Gerd who don't care about CSM can just build OVMF image from edk2 repo.
You can build the OVMF image from edk2 and csm repo.


Ray,

I kind or agree at this point CSM is really more interesting for virtual machines vs. real platforms. I guess the interesting question to ask is do we want to start making it more part of the virtual machines that happen to be checked into TianoCore, or should we keep it more generic? The thinking being the CSM is likely upstreamed in other more commercial VMs? Can we just add a readme to the current CSM package and explain it mostly exists to support VMs?

Thanks,

Andrew Fish


We can have a call if you are ok. I can explain how that can work in details.

Thanks,
Ray

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
https://lists.01.org/mailman/listinfo/edk2-devel



  reply	other threads:[~2019-01-23  4:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17  2:23 Drop CSM support in OvmfPkg? Ni, Ruiyu
2018-12-17  9:54 ` Laszlo Ersek
2018-12-17 10:44   ` Ni, Ruiyu
2018-12-20  6:44   ` Gerd Hoffmann
2018-12-20 13:37     ` David Woodhouse
2018-12-20 14:55       ` Ni, Ruiyu
2019-01-22 16:13         ` Ni, Ray
2019-01-22 16:23           ` David Woodhouse
2019-01-23  3:43             ` Ni, Ray
2019-01-23  4:00               ` Andrew Fish
2019-01-23  4:29                 ` Ni, Ray [this message]
2019-01-23  9:46               ` Laszlo Ersek
2019-01-23  9:49                 ` David Woodhouse
2019-01-24  1:48                   ` Ni, Ray
2019-01-24  9:31                     ` David Woodhouse
2019-01-24 11:30                       ` Laszlo Ersek
2019-01-25 20:28                         ` Brian J. Johnson
2019-01-28  8:23                           ` Laszlo Ersek
2019-01-23 12:26                 ` Ard Biesheuvel
2019-01-23  6:12             ` Gerd Hoffmann
2019-01-23  8:42               ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BFCFAA5@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox