From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=ray.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3B7EC211B6C1A for ; Tue, 22 Jan 2019 20:29:42 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jan 2019 20:29:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,509,1539673200"; d="scan'208,217";a="137945068" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 22 Jan 2019 20:29:42 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 22 Jan 2019 20:29:41 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 22 Jan 2019 20:29:41 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.150]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.184]) with mapi id 14.03.0415.000; Wed, 23 Jan 2019 12:29:39 +0800 From: "Ni, Ray" To: "'afish@apple.com'" CC: David Woodhouse , Gerd Hoffmann , Laszlo Ersek , "Richardson, Brian" , Anthony Perard , "Justen, Jordan L" , "edk2-devel@lists.01.org" , Kevin O'Connor Thread-Topic: [edk2] Drop CSM support in OvmfPkg? Thread-Index: AdSVrlbHq3cEbVXKTw64xdd45eGHWv//+jKAgASCA4CAAHNHgP//Znkg/8rYqECAacwbAP/+v6nwAEBoAQD//3I/kA== Date: Wed, 23 Jan 2019 04:29:38 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BFCFAA5@SHSMSX103.ccr.corp.intel.com> References: <734D49CCEBEEF84792F5B80ED585239D5BF6035C@SHSMSX104.ccr.corp.intel.com> <20181220064447.7eflwhm3t5upj7ds@sirius.home.kraxel.org> <734D49CCEBEEF84792F5B80ED585239D5BF6895F@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5BFCEBF2@SHSMSX103.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5BFCF8F8@SHSMSX103.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: Drop CSM support in OvmfPkg? X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2019 04:29:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Andrew, Do you have any specific concerns if we move csm out of edk2 repo, to a rep= o owned by David? As David mentioned, VM can switch between firmware images. It 's just someh= ow difficult in certain environment. Maybe for the long term consideration,= enhancing the VM to support easily switching firmware images makes a littl= e more sense. Thanks, Ray From: afish@apple.com Sent: Wednesday, January 23, 2019 12:01 PM To: Ni, Ray Cc: David Woodhouse ; Gerd Hoffmann ; Laszlo Ersek ; Richardson, Brian ; Anthony Perard ; Justen, Jordan L ; edk2-devel@lists.01.org; Kevin O'Connor Subject: Re: [edk2] Drop CSM support in OvmfPkg? On Jan 22, 2019, at 7:43 PM, Ni, Ray > wrote: -----Original Message----- From: David Woodhouse > Sent: Wednesday, January 23, 2019 12:23 AM To: Ni, Ray >; Gerd Hoffmann >; Laszlo Ersek >; Richardson, Bri= an > Cc: Justen, Jordan L >; edk2-devel@lists.01.org; Kevin O'Connor >; Anthony Per= ard > Subject: Re: Drop CSM support in OvmfPkg? On Tue, 2019-01-22 at 16:13 +0000, Ni, Ray wrote: David, I'd like to re-start the discussion. Could you please kindly explain the background/reason of adding CSM support in OVMF? Maybe knowing the reason can help to make further decisions of whether to A. keep it outside OvmfPkg B. keep it inside OvmfPkg C. maybe have a chance to just remove the CSM support after revisiting The idea was to make it simple to have a single firmware image for virtual machines which would support both UEFI and Legacy boot for guests simultaneously. In libvirt there has been an alternative approach, where the BIOS image is switched between OVMF and SeaBIOS according to the configuration of the guest VM. That's fine for libvirt, but in situations where VM hosting is provided as a service, it becomes quite painful to manage the 'UEFI' vs. 'Legacy' flags on guest images and then switch firmware images accordingly. A one-size-fits-all BIOS using OVMF+CSM is very much preferable. David, Thanks for sharing. I now understand that you do have a need of CSM + UEFI OVMF image. A very straightforward idea is to move all COM components you needed into OvmfPkg. But Laszlo as the OvmfPkg owner may disagree with this. So maybe you could set up another (github) repo and clone all the CSM compo= nents there. EDKII build tool supports to build firmware from multiple repos. That's how we can have edk2-platforms and to-be-created edk2-app. In practical, you could create a new csm repo. Laszlo/Gerd who don't care about CSM can just build OVMF image from edk2 re= po. You can build the OVMF image from edk2 and csm repo. Ray, I kind or agree at this point CSM is really more interesting for virtual ma= chines vs. real platforms. I guess the interesting question to ask is do we= want to start making it more part of the virtual machines that happen to b= e checked into TianoCore, or should we keep it more generic? The thinking b= eing the CSM is likely upstreamed in other more commercial VMs? Can we just= add a readme to the current CSM package and explain it mostly exists to su= pport VMs? Thanks, Andrew Fish We can have a call if you are ok. I can explain how that can work in detail= s. Thanks, Ray _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel