public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "Chen, Chen A" <chen.a.chen@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Zhang, Chao B" <chao.b.zhang@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH v3 1/4] MdePkg/UefiSpec.h: Add definition to support Capsule-on-Disk feature
Date: Tue, 29 Jan 2019 09:00:02 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BFFAACB@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190129074341.7032-2-chen.a.chen@intel.com>

Where does the macro name come from?
If it's not defined in Spec, how about to rename it to "EFI_CAPSULE_FILE_DIRECTORY"?


> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Chen A Chen
> Sent: Tuesday, January 29, 2019 3:44 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [PATCH v3 1/4] MdePkg/UefiSpec.h: Add definition to support
> Capsule-on-Disk feature
> 
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1482
> 
> UEFI Spec define this definition to support Capsule-on-Disk.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Zhang Chao B <chao.b.zhang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Chen A Chen <chen.a.chen@intel.com>
> ---
>  MdePkg/Include/Uefi/UefiSpec.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/MdePkg/Include/Uefi/UefiSpec.h b/MdePkg/Include/Uefi/UefiSpec.h
> index 75af99de50..9d3d7a9a63 100644
> --- a/MdePkg/Include/Uefi/UefiSpec.h
> +++ b/MdePkg/Include/Uefi/UefiSpec.h
> @@ -2201,6 +2201,11 @@ typedef struct {
>    #error Unknown Processor Type
>  #endif
> 
> +//
> +// The directory within the active EFI System Partition defined for
> +delivery of capsule to firmware //
> +#define EFI_CAPSULE_FROM_FILE_DIR            L"\\EFI\\UpdateCapsule\\"
> +
>  #include <Uefi/UefiPxe.h>
>  #include <Uefi/UefiGpt.h>
>  #include <Uefi/UefiInternalFormRepresentation.h>
> --
> 2.16.2.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2019-01-29  9:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29  7:43 [PATCH v3 0/4] Introduce CapsuleApp patch v3 Chen A Chen
2019-01-29  7:43 ` [PATCH v3 1/4] MdePkg/UefiSpec.h: Add definition to support Capsule-on-Disk feature Chen A Chen
2019-01-29  9:00   ` Ni, Ray [this message]
2019-01-29  7:43 ` [PATCH v3 2/4] MdeModulePkg/CapsuleApp: Add a function used to get next DevicePath Chen A Chen
2019-01-29 14:02   ` Wang, Jian J
2019-01-29  7:43 ` [PATCH v3 3/4] MdeModulePkg/CapsuleApp: Add functions to support Capsule-on-Disk Chen A Chen
2019-01-29 14:02   ` Wang, Jian J
2019-01-29  7:43 ` [PATCH v3 4/4] MdeModulePkg/CapsuleApp: Enhance CapsuleApp " Chen A Chen
2019-01-29 14:01   ` Wang, Jian J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BFFAACB@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox