From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=ray.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BC081211BD5E9 for ; Wed, 30 Jan 2019 19:26:30 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 19:26:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,543,1539673200"; d="scan'208";a="111217816" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga007.jf.intel.com with ESMTP; 30 Jan 2019 19:26:29 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 30 Jan 2019 19:26:16 -0800 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 30 Jan 2019 19:26:15 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.190]) with mapi id 14.03.0415.000; Thu, 31 Jan 2019 11:25:46 +0800 From: "Ni, Ray" To: "Wu, Hao A" , "edk2-devel@lists.01.org" CC: "Wang, Jian J" , "Dong, Eric" Thread-Topic: [PATCH v2 01/12] MdeModulePkg: Add definitions for ATA AHCI host controller PPI Thread-Index: AQHUuQ+Hr2PCjDjlrk+LmqBPmmWNIKXIt9gA Date: Thu, 31 Jan 2019 03:25:45 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BFFFF03@SHSMSX104.ccr.corp.intel.com> References: <20190131024854.4880-1-hao.a.wu@intel.com> <20190131024854.4880-2-hao.a.wu@intel.com> In-Reply-To: <20190131024854.4880-2-hao.a.wu@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 01/12] MdeModulePkg: Add definitions for ATA AHCI host controller PPI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 03:26:31 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Wu, Hao A > Sent: Thursday, January 31, 2019 10:49 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Wang, Jian J ; > Ni, Ray ; Dong, Eric > Subject: [PATCH v2 01/12] MdeModulePkg: Add definitions for ATA AHCI > host controller PPI >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1409 >=20 > This commit will add the definitions for ATA AHCI host controller PPI. Th= e > purpose of the PPI in to provide: >=20 > * MMIO base address > * Controller identification information (DevicePath) >=20 > for ATA host controllers working under AHCI mode. >=20 > Cc: Jian J Wang > Cc: Ray Ni > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Hao Wu > --- > MdeModulePkg/MdeModulePkg.dec | 3 + > MdeModulePkg/Include/Ppi/AtaAhciController.h | 89 > ++++++++++++++++++++ > 2 files changed, 92 insertions(+) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index e5c32d15ed..4411185073 > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -480,6 +480,9 @@ > ## Include/Ppi/NvmExpressHostController.h > gEdkiiPeiNvmExpressHostControllerPpiGuid =3D { 0xcae3aa63, 0x676f, 0x= 4da3, > { 0xbd, 0x50, 0x6c, 0xc5, 0xed, 0xde, 0x9a, 0xad } } >=20 > + ## Include/Ppi/AtaAhciController.h > + gEdkiiPeiAtaAhciHostControllerPpiGuid =3D { 0x61dd33ea, 0x421f, 0x= 4cc0, > { 0x89, 0x29, 0xff, 0xee, 0xa9, 0xa1, 0xa2, 0x61 } } > + > [Protocols] > ## Load File protocol provides capability to load and unload EFI image= into > memory and execute it. > # Include/Protocol/LoadPe32Image.h > diff --git a/MdeModulePkg/Include/Ppi/AtaAhciController.h > b/MdeModulePkg/Include/Ppi/AtaAhciController.h > new file mode 100644 > index 0000000000..2bdd53ff36 > --- /dev/null > +++ b/MdeModulePkg/Include/Ppi/AtaAhciController.h > @@ -0,0 +1,89 @@ > +/** @file > + > + Copyright (c) 2019, Intel Corporation. All rights reserved.
This > + program and the accompanying materials are licensed and made > + available under the terms and conditions of the BSD License which > + accompanies this distribution. The full text of the license may be > + found at http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > + > +**/ > + > +#ifndef _EDKII_ATA_AHCI_HOST_CONTROLLER_PPI_H_ > +#define _EDKII_ATA_AHCI_HOST_CONTROLLER_PPI_H_ > + > +#include > + > +/// > +/// Global ID for the EDKII_ATA_AHCI_HOST_CONTROLLER_PPI. > +/// > +#define EDKII_ATA_AHCI_HOST_CONTROLLER_PPI_GUID \ > + { \ > + 0x61dd33ea, 0x421f, 0x4cc0, { 0x89, 0x29, 0xff, 0xee, 0xa9, 0xa1, > +0xa2, 0x61 } \ > + } > + > +// > +// Forward declaration for the EDKII_ATA_AHCI_HOST_CONTROLLER_PPI. > +// > +typedef struct _EDKII_ATA_AHCI_HOST_CONTROLLER_PPI > +EDKII_ATA_AHCI_HOST_CONTROLLER_PPI; > + > +/** > + Get the MMIO base address of ATA AHCI host controller. > + > + @param[in] This The PPI instance pointer. > + @param[in] ControllerId The ID of the ATA AHCI host controlle= r. > + @param[out] MmioBar The MMIO base address of the controll= er. > + > + @retval EFI_SUCCESS The operation succeeds. > + @retval EFI_INVALID_PARAMETER The parameters are invalid. > + @retval EFI_NOT_FOUND The specified ATA AHCI host controlle= r not > found. > + > +**/ > +typedef > +EFI_STATUS > +(EFIAPI *EDKII_ATA_AHCI_HC_GET_MMIO_BAR) ( > + IN EDKII_ATA_AHCI_HOST_CONTROLLER_PPI *This, > + IN UINT8 ControllerId, > + OUT UINTN *MmioBar > + ); > + > +/** > + Get the device path of ATA AHCI host controller. > + > + @param[in] This The PPI instance pointer. > + @param[in] ControllerId The ID of the ATA AHCI host controlle= r. > + @param[out] DevicePathLength The length of the device path in byte= s > specified > + by DevicePath. > + @param[out] DevicePath The device path of ATA AHCI host cont= roller. > + This field re-uses EFI Device Path Pr= otocol as > + defined by Section 10.2 EFI Device Pa= th Protocol > + of UEFI 2.7 Specification. > + > + @retval EFI_SUCCESS The operation succeeds. > + @retval EFI_INVALID_PARAMETER The parameters are invalid. > + @retval EFI_NOT_FOUND The specified ATA AHCI host controlle= r not > found. > + @retval EFI_OUT_OF_RESOURCES The operation fails due to lack of > resources. > + > +**/ > +typedef > +EFI_STATUS > +(EFIAPI *EDKII_ATA_AHCI_HC_GET_DEVICE_PATH) ( > + IN EDKII_ATA_AHCI_HOST_CONTROLLER_PPI *This, > + IN UINT8 ControllerId, > + OUT UINTN *DevicePathLength, > + OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath > + ); > + > +// > +// This PPI contains a set of services to interact with the ATA AHCI hos= t > controller. > +// > +struct _EDKII_ATA_AHCI_HOST_CONTROLLER_PPI { > + EDKII_ATA_AHCI_HC_GET_MMIO_BAR GetAhciHcMmioBar; > + EDKII_ATA_AHCI_HC_GET_DEVICE_PATH GetAhciHcDevicePath; > +}; > + > +extern EFI_GUID gEdkiiPeiAtaAhciHostControllerPpiGuid; > + > +#endif > -- > 2.12.0.windows.1