From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=ray.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 51A18211BA46B for ; Wed, 30 Jan 2019 19:29:04 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 19:29:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,543,1539673200"; d="scan'208";a="114093680" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga008.jf.intel.com with ESMTP; 30 Jan 2019 19:29:03 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 30 Jan 2019 19:29:03 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 30 Jan 2019 19:29:02 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.162]) with mapi id 14.03.0415.000; Thu, 31 Jan 2019 11:29:01 +0800 From: "Ni, Ray" To: "Wu, Hao A" , "edk2-devel@lists.01.org" CC: "Wang, Jian J" , "Dong, Eric" Thread-Topic: [PATCH v2 03/12] MdeModulePkg: Add definitions for Storage Security Command PPI Thread-Index: AQHUuQ+LBH/AzbN7ZE2TqtKdY/XW+KXIuAqA Date: Thu, 31 Jan 2019 03:26:25 +0000 Deferred-Delivery: Thu, 31 Jan 2019 03:29:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BFFFF2C@SHSMSX104.ccr.corp.intel.com> References: <20190131024854.4880-1-hao.a.wu@intel.com> <20190131024854.4880-4-hao.a.wu@intel.com> In-Reply-To: <20190131024854.4880-4-hao.a.wu@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 03/12] MdeModulePkg: Add definitions for Storage Security Command PPI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 03:29:04 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Wu, Hao A > Sent: Thursday, January 31, 2019 10:49 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Wang, Jian J ; > Ni, Ray ; Dong, Eric > Subject: [PATCH v2 03/12] MdeModulePkg: Add definitions for Storage > Security Command PPI >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1409 >=20 > This commit will add the definitions for Storage Security Command (SSC) P= PI. > This PPI will be be used to abstract mass storage devices to allow code > running in the PEI phase to send security protocol commands to mass stora= ge > devices without specific knowledge of the type of device or controller th= at > manages the device. >=20 > More specifically, the PPI will provide services to: >=20 > * Get the number of mass storage devices managed by a instance of the SSC > PPI (by service 'GetNumberofDevices'); > * Get the identification information (DevicePath) of a managing mass > storage devices (by service 'GetDevicePath'); > * Send security protocol commands to mass storage devices (by services > 'ReceiveData' and 'SendData'). >=20 > Cc: Jian J Wang > Cc: Ray Ni > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Hao Wu > --- > MdeModulePkg/MdeModulePkg.dec | 3 + > MdeModulePkg/Include/Ppi/StorageSecurityCommand.h | 283 > ++++++++++++++++++++ > 2 files changed, 286 insertions(+) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 8efb19e626..7f646d7702 > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -483,6 +483,9 @@ > ## Include/Ppi/AtaAhciController.h > gEdkiiPeiAtaAhciHostControllerPpiGuid =3D { 0x61dd33ea, 0x421f, 0x= 4cc0, > { 0x89, 0x29, 0xff, 0xee, 0xa9, 0xa1, 0xa2, 0x61 } } >=20 > + ## Include/Ppi/StorageSecurityCommand.h > + gEdkiiPeiStorageSecurityCommandPpiGuid =3D { 0x35de0b4e, 0x30fb, > 0x46c3, { 0xbd, 0x84, 0x1f, 0xdb, 0xa1, 0x58, 0xbb, 0x56 } } > + > ## Include/Ppi/AtaPassThru.h > gEdkiiPeiAtaPassThruPpiGuid =3D { 0xa16473fd, 0xd474, 0x= 4c89, { 0xae, > 0xc7, 0x90, 0xb8, 0x3c, 0x73, 0x86, 0x9 } } >=20 > diff --git a/MdeModulePkg/Include/Ppi/StorageSecurityCommand.h > b/MdeModulePkg/Include/Ppi/StorageSecurityCommand.h > new file mode 100644 > index 0000000000..cc1688dabb > --- /dev/null > +++ b/MdeModulePkg/Include/Ppi/StorageSecurityCommand.h > @@ -0,0 +1,283 @@ > +/** @file > + > + Copyright (c) 2019, Intel Corporation. All rights reserved.
This > + program and the accompanying materials are licensed and made > + available under the terms and conditions of the BSD License which > + accompanies this distribution. The full text of the license may be > + found at http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > + > +**/ > + > +#ifndef _EDKII_STORAGE_SECURITY_COMMAND_PPI_H_ > +#define _EDKII_STORAGE_SECURITY_COMMAND_PPI_H_ > + > +#include > + > +/// > +/// Global ID for the EDKII_PEI_STORAGE_SECURITY_CMD_PPI. > +/// > +#define EDKII_PEI_STORAGE_SECURITY_CMD_PPI_GUID \ > + { \ > + 0x35de0b4e, 0x30fb, 0x46c3, { 0xbd, 0x84, 0x1f, 0xdb, 0xa1, 0x58, > +0xbb, 0x56 } \ > + } > + > +// > +// Forward declaration for the EDKII_PEI_STORAGE_SECURITY_CMD_PPI. > +// > +typedef struct _EDKII_PEI_STORAGE_SECURITY_CMD_PPI > +EDKII_PEI_STORAGE_SECURITY_CMD_PPI; > + > +// > +// Revision The revision to which the Storage Security Command interface > adheres. > +// All future revisions must be backwards compatible. > +// If a future version is not back wards compatible it is not t= he same > GUID. > +// > +#define EDKII_STORAGE_SECURITY_PPI_REVISION 0x00010000 > + > + > +/** > + Gets the count of storage security devices that one specific driver de= tects. > + > + @param[in] This The PPI instance pointer. > + @param[out] NumberofDevices The number of storage security devices > discovered. > + > + @retval EFI_SUCCESS The operation performed successfully. > + @retval EFI_INVALID_PARAMETER The parameters are invalid. > + > +**/ > +typedef > +EFI_STATUS > +(EFIAPI *EDKII_PEI_STORAGE_SECURITY_GET_NUMBER_DEVICES) ( > + IN EDKII_PEI_STORAGE_SECURITY_CMD_PPI *This, > + OUT UINTN *NumberofDevices > + ); > + > +/** > + Gets the device path of a specific storage security device. > + > + @param[in] This The PPI instance pointer. > + @param[in] DeviceIndex Specifies the storage security device= to > which > + the function wants to talk. Because t= he driver > + that implements Storage Security Comm= and PPIs > + will manage multiple storage devices,= the PPIs > + that want to talk to a single device = must specify > + the device index that was assigned du= ring the > + enumeration process. This index is a = number from > + one to NumberofDevices. > + @param[out] DevicePathLength The length of the device path in byte= s > specified > + by DevicePath. > + @param[out] DevicePath The device path of storage security d= evice. > + This field re-uses EFI Device Path Pr= otocol as > + defined by Section 10.2 EFI Device Pa= th Protocol > + of UEFI 2.7 Specification. > + > + @retval EFI_SUCCESS The operation succeeds. > + @retval EFI_INVALID_PARAMETER DevicePathLength or DevicePath is > NULL. > + @retval EFI_NOT_FOUND The specified storage security device= not > found. > + @retval EFI_OUT_OF_RESOURCES The operation fails due to lack of > resources. > + > +**/ > +typedef > +EFI_STATUS > +(EFIAPI *EDKII_PEI_STORAGE_SECURITY_GET_DEVICE_PATH) ( > + IN EDKII_PEI_STORAGE_SECURITY_CMD_PPI *This, > + IN UINTN DeviceIndex, > + OUT UINTN *DevicePathLength, > + OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath > + ); > + > +/** > + Send a security protocol command to a device that receives data > +and/or the result > + of one or more commands sent by SendData. > + > + The ReceiveData function sends a security protocol command to the give= n > DeviceIndex. > + The security protocol command sent is defined by SecurityProtocolId > + and contains the security protocol specific data > + SecurityProtocolSpecificData. The function returns the data from the > security protocol command in PayloadBuffer. > + > + For devices supporting the SCSI command set, the security protocol > + command is sent using the SECURITY PROTOCOL IN command defined in > SPC-4. > + > + For devices supporting the ATA command set, the security protocol > + command is sent using one of the TRUSTED RECEIVE commands defined in > + ATA8-ACS if PayloadBufferSize is non-zero. > + > + If the PayloadBufferSize is zero, the security protocol command is > + sent using the Trusted Non-Data command defined in ATA8-ACS. > + > + If PayloadBufferSize is too small to store the available data from > + the security protocol command, the function shall copy > + PayloadBufferSize bytes into the PayloadBuffer and return > EFI_WARN_BUFFER_TOO_SMALL. > + > + If PayloadBuffer or PayloadTransferSize is NULL and PayloadBufferSize > + is non-zero, the function shall return EFI_INVALID_PARAMETER. > + > + If the given DeviceIndex does not support security protocol commands, > + the function shall return EFI_UNSUPPORTED. > + > + If the security protocol fails to complete within the Timeout period, > + the function shall return EFI_TIMEOUT. > + > + If the security protocol command completes without an error, the > + function shall return EFI_SUCCESS. If the security protocol command > + completes with an error, the function shall return EFI_DEVICE_ERROR. > + > + @param[in] This The PPI instance pointer. > + @param[in] DeviceIndex Specifies the storage security device to = which > the > + function wants to talk. Because the drive= r that > + implements Storage Security Command PPIs = will manage > + multiple storage devices, the PPIs that w= ant to talk > + to a single device must specify the devic= e index > + that was assigned during the enumeration = process. > + This index is a number from one to Number= ofDevices. > + @param[in] Timeout The timeout, in 100ns units, to use for t= he > execution > + of the security protocol command. A Timeo= ut value > + of 0 means that this function will wait i= ndefinitely > + for the security protocol command to exec= ute. If > + Timeout is greater than zero, then this f= unction > + will return EFI_TIMEOUT if the time requi= red to > + execute the receive data command is great= er than > + Timeout. > + @param[in] SecurityProtocolId > + The value of the "Security Protocol" para= meter of > + the security protocol command to be sent. > + @param[in] SecurityProtocolSpecificData > + The value of the "Security Protocol Speci= fic" > + parameter of the security protocol comman= d to be > + sent. > + @param[in] PayloadBufferSize > + Size in bytes of the payload data buffer. > + @param[out] PayloadBuffer A pointer to a destination buffer to stor= e > the > + security protocol command specific payloa= d data > + for the security protocol command. The ca= ller is > + responsible for having either implicit or= explicit > + ownership of the buffer. > + @param[out] PayloadTransferSize > + A pointer to a buffer to store the size i= n bytes > + of the data written to the payload data b= uffer. > + > + @retval EFI_SUCCESS The security protocol command com= pleted > + successfully. > + @retval EFI_WARN_BUFFER_TOO_SMALL The PayloadBufferSize was too > small to > + store the available data from the= device. > + The PayloadBuffer contains the tr= uncated > + data. > + @retval EFI_UNSUPPORTED The given DeviceIndex does not > support > + security protocol commands. > + @retval EFI_DEVICE_ERROR The security protocol command > completed > + with an error. > + @retval EFI_INVALID_PARAMETER The PayloadBuffer or > PayloadTransferSize > + is NULL and PayloadBufferSize is = non-zero. > + @retval EFI_TIMEOUT A timeout occurred while waiting = for the > + security protocol command to exec= ute. > + > +**/ > +typedef > +EFI_STATUS > +(EFIAPI *EDKII_PEI_STORAGE_SECURITY_RECEIVE_DATA) ( > + IN EDKII_PEI_STORAGE_SECURITY_CMD_PPI *This, > + IN UINTN DeviceIndex, > + IN UINT64 Timeout, > + IN UINT8 SecurityProtocolId, > + IN UINT16 SecurityProtocolSpecificData= , > + IN UINTN PayloadBufferSize, > + OUT VOID *PayloadBuffer, > + OUT UINTN *PayloadTransferSize > + ); > + > +/** > + Send a security protocol command to a device. > + > + The SendData function sends a security protocol command containing > + the payload PayloadBuffer to the given DeviceIndex. The security > + protocol command sent is defined by SecurityProtocolId and contains > + the security protocol specific data SecurityProtocolSpecificData. If > + the underlying protocol command requires a specific padding for the > + command payload, the SendData function shall add padding bytes to the > command payload to satisfy the padding requirements. > + > + For devices supporting the SCSI command set, the security protocol > + command is sent using the SECURITY PROTOCOL OUT command defined in > SPC-4. > + > + For devices supporting the ATA command set, the security protocol > + command is sent using one of the TRUSTED SEND commands defined in > + ATA8-ACS if PayloadBufferSize is non-zero. If the PayloadBufferSize > + is zero, the security protocol command is sent using the Trusted Non-D= ata > command defined in ATA8-ACS. > + > + If PayloadBuffer is NULL and PayloadBufferSize is non-zero, the > + function shall return EFI_INVALID_PARAMETER. > + > + If the given DeviceIndex does not support security protocol commands, > + the function shall return EFI_UNSUPPORTED. > + > + If the security protocol fails to complete within the Timeout period, > + the function shall return EFI_TIMEOUT. > + > + If the security protocol command completes without an error, the > + function shall return EFI_SUCCESS. If the security protocol command > + completes with an error, the functio shall return EFI_DEVICE_ERROR. > + > + @param[in] This The PPI instance pointer. > + @param[in] DeviceIndex The ID of the device. > + @param[in] Timeout The timeout, in 100ns units, to use for t= he > execution > + of the security protocol command. A Timeo= ut value > + of 0 means that this function will wait i= ndefinitely > + for the security protocol command to exec= ute. If > + Timeout is greater than zero, then this f= unction > + will return EFI_TIMEOUT if the time requi= red to > + execute the receive data command is great= er than > + Timeout. > + @param[in] SecurityProtocolId > + The value of the "Security Protocol" para= meter of > + the security protocol command to be sent. > + @param[in] SecurityProtocolSpecificData > + The value of the "Security Protocol Speci= fic" > + parameter of the security protocol comman= d to be > + sent. > + @param[in] PayloadBufferSize Size in bytes of the payload data buffer. > + @param[in] PayloadBuffer A pointer to a destination buffer to stor= e the > + security protocol command specific payloa= d data > + for the security protocol command. > + > + @retval EFI_SUCCESS The security protocol command complet= ed > successfully. > + @retval EFI_UNSUPPORTED The given DeviceIndex does not suppor= t > security > + protocol commands. > + @retval EFI_DEVICE_ERROR The security protocol command > completed with > + an error. > + @retval EFI_INVALID_PARAMETER The PayloadBuffer is NULL and > PayloadBufferSize > + is non-zero. > + @retval EFI_TIMEOUT A timeout occurred while waiting for = the > security > + protocol command to execute. > + > +**/ > +typedef > +EFI_STATUS > +(EFIAPI *EDKII_PEI_STORAGE_SECURITY_SEND_DATA) ( > + IN EDKII_PEI_STORAGE_SECURITY_CMD_PPI *This, > + IN UINTN DeviceIndex, > + IN UINT64 Timeout, > + IN UINT8 SecurityProtocolId, > + IN UINT16 SecurityProtocolSpecificData, > + IN UINTN PayloadBufferSize, > + IN VOID *PayloadBuffer > + ); > + > +// > +// EDKII_PEI_STORAGE_SECURITY_CMD_PPI contains a set of services to > +send security // protocol commands to a mass storage device. Two types > +of security protocol // commands are supported. SendData sends a > command with data to a device. > +// ReceiveData sends a command that receives data and/or the result of > +one or // more commands sent by SendData. > +// > +struct _EDKII_PEI_STORAGE_SECURITY_CMD_PPI { > + UINT64 Revision; > + EDKII_PEI_STORAGE_SECURITY_GET_NUMBER_DEVICES > GetNumberofDevices; > + EDKII_PEI_STORAGE_SECURITY_GET_DEVICE_PATH GetDevicePath; > + EDKII_PEI_STORAGE_SECURITY_RECEIVE_DATA ReceiveData; > + EDKII_PEI_STORAGE_SECURITY_SEND_DATA SendData; > +}; > + > +extern EFI_GUID gEdkiiPeiStorageSecurityCommandPpiGuid; > + > +#endif > -- > 2.12.0.windows.1