From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=ray.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A062921B02822 for ; Thu, 14 Feb 2019 00:06:11 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2019 00:06:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,367,1544515200"; d="scan'208";a="144173996" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 14 Feb 2019 00:06:10 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Feb 2019 00:06:10 -0800 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Feb 2019 00:06:10 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.174]) with mapi id 14.03.0415.000; Thu, 14 Feb 2019 16:06:08 +0800 From: "Ni, Ray" To: "Chiu, Chasel" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Gao, Liming" Thread-Topic: [edk2] [PATCH 1/3] MdePkg: Support EFI_PEI_CORE_FV_LOCATION_PPI Thread-Index: AQHUwtXRp4FjSMSiaUWtfnLheO1tcKXe8vqw Date: Thu, 14 Feb 2019 08:06:08 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C0196F1@SHSMSX104.ccr.corp.intel.com> References: <20190212131957.2576-1-chasel.chiu@intel.com> <20190212131957.2576-2-chasel.chiu@intel.com> In-Reply-To: <20190212131957.2576-2-chasel.chiu@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 1/3] MdePkg: Support EFI_PEI_CORE_FV_LOCATION_PPI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2019 08:06:11 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Chasel, I don't think the below forward definition is needed. typedef struct _EFI_PEI_CORE_FV_LOCATION_PPI EFI_PEI_CORE_FV_LOCATION_PPI; It is needed when the PPI contains methods and the methods requires This po= inter as the first parameter. > -----Original Message----- > From: edk2-devel On Behalf Of Chasel, > Chiu > Sent: Tuesday, February 12, 2019 9:20 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [edk2] [PATCH 1/3] MdePkg: Support > EFI_PEI_CORE_FV_LOCATION_PPI >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1524 >=20 > Add EFI_PEI_CORE_FV_LOCATION_PPI definition basing on PI spec 1.7, > Section 6.3.9. > This PPI can support the secnario that PEI Foundation not in BFV. >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Chasel Chiu > --- > MdePkg/Include/Ppi/PeiCoreFvLocation.h | 53 > +++++++++++++++++++++++++++++++++++++++++++++++++++++ > MdePkg/MdePkg.dec | 11 +++++++++-- > 2 files changed, 62 insertions(+), 2 deletions(-) >=20 > diff --git a/MdePkg/Include/Ppi/PeiCoreFvLocation.h > b/MdePkg/Include/Ppi/PeiCoreFvLocation.h > new file mode 100644 > index 0000000000..c7bbbfb265 > --- /dev/null > +++ b/MdePkg/Include/Ppi/PeiCoreFvLocation.h > @@ -0,0 +1,53 @@ > +/** @file > + Header file for Pei Core FV Location PPI. > + > + This PPI contains a pointer to the firmware volume which contains the = PEI > Foundation. > + If the PEI Foundation does not reside in the BFV, then SEC must pass > + this PPI as a part of the PPI list provided to the PEI Foundation > + Entry Point, otherwise the PEI Foundation shall assume that it resides > within the BFV. > + > + Copyright (c) 2019, Intel Corporation. All rights reserved.
This > + program and the accompanying materials are licensed and made > + available under the terms and conditions of the BSD License which > + accompanies this distribution. The full text of the license may be > + found at http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > + > + @par Revision Reference: > + This PPI is defined in UEFI Platform Initialization Specification 1.7 = Volume 1: > + Standards > + > +**/ > + > + > +#ifndef _EFI_PEI_CORE_FV_LOCATION_H_ > +#define _EFI_PEI_CORE_FV_LOCATION_H_ > + > +/// > +/// Global ID for EFI_PEI_CORE_FV_LOCATION_PPI /// #define > +EFI_PEI_CORE_FV_LOCATION_GUID \ > + { \ > + 0x52888eae, 0x5b10, 0x47d0, {0xa8, 0x7f, 0xb8, 0x22, 0xab, 0xa0, > +0xca, 0xf4 } \ > + } > + > +/// > +/// Forward declaration for EFI_PEI_CORE_FV_LOCATION_PPI /// typedef > +struct _EFI_PEI_CORE_FV_LOCATION_PPI > EFI_PEI_CORE_FV_LOCATION_PPI; > + > +/// > +/// This PPI provides location of EFI PeiCoreFv. > +/// > +struct _EFI_PEI_CORE_FV_LOCATION_PPI { > + /// > + /// Pointer to the first byte of the firmware volume which contains th= e PEI > Foundation. > + /// > + VOID *PeiCoreFvLocation; > +}; > + > +extern EFI_GUID gEfiPeiCoreFvLocationPpiGuid; > + > +#endif // _EFI_PEI_CORE_FV_LOCATION_H_ > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > a485408310..c859b4a511 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -2,9 +2,9 @@ > # This Package provides all definitions, library classes and libraries i= nstances. > # > # It also provides the definitions(including PPIs/PROTOCOLs/GUIDs) of -# > EFI1.10/UEFI2.7/PI1.6 and some Industry Standards. > +# EFI1.10/UEFI2.7/PI1.7 and some Industry Standards. > # > -# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
> +# Copyright (c) 2007 - 2019, Intel Corporation. All rights > +reserved.
> # Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved. # (C) > Copyright 2016 Hewlett Packard Enterprise Development LP
# @@ - > 929,6 +929,13 @@ > ## Include/Ppi/SecHobData.h > gEfiSecHobDataPpiGuid =3D { 0x3ebdaf20, 0x6667, 0x40d8, {0xb4, 0xee, 0= xf5, > 0x99, 0x9a, 0xc1, 0xb7, 0x1f } } >=20 > + # > + # PPIs defined in PI 1.7. > + # > + > + ## Include/Ppi/PeiCoreFvLocation.h > + gEfiPeiCoreFvLocationPpiGuid =3D { 0x52888eae, 0x5b10, 0x47d0, { 0xa= 8, > 0x7f, 0xb8, 0x22, 0xab, 0xa0, 0xca, 0xf4 }} > + > [Protocols] > ## Include/Protocol/Pcd.h > gPcdProtocolGuid =3D { 0x11B34006, 0xD85B, 0x4D0A, { 0xA= 2, 0x90, > 0xD5, 0xA5, 0x71, 0x31, 0x0E, 0xF7 }} > -- > 2.13.3.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel