From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=ray.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 27E5221A1349F for ; Mon, 18 Feb 2019 19:42:04 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Feb 2019 19:42:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,385,1544515200"; d="scan'208";a="127491694" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga003.jf.intel.com with ESMTP; 18 Feb 2019 19:42:03 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 18 Feb 2019 19:42:03 -0800 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 18 Feb 2019 19:42:02 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.190]) with mapi id 14.03.0415.000; Tue, 19 Feb 2019 11:42:00 +0800 From: "Ni, Ray" To: "Zeng, Star" , "Wang, Jian J" , "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Wu, Hao A" Thread-Topic: [PATCH] MdeModulePkg/PropertiesTableAttributesDxe: Remove this driver Thread-Index: AQHUx2dXlfCwuU2b+ky6niFGILq+CqXlE+aAgAAB5gCAAWVHIA== Date: Tue, 19 Feb 2019 03:38:26 +0000 Deferred-Delivery: Tue, 19 Feb 2019 03:42:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C023EAF@SHSMSX104.ccr.corp.intel.com> References: <20190218085240.8400-1-shenglei.zhang@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483104026EFC0@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483104026EFC0@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg/PropertiesTableAttributesDxe: Remove this driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Feb 2019 03:42:05 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Zeng, Star > Sent: Monday, February 18, 2019 10:22 PM > To: Wang, Jian J ; Zhang, Shenglei > ; edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ni, Ray > Subject: RE: [PATCH] MdeModulePkg/PropertiesTableAttributesDxe: > Remove this driver >=20 > Reviewed-by: Star Zeng >=20 > -----Original Message----- > From: Wang, Jian J > Sent: Monday, February 18, 2019 10:16 PM > To: Zhang, Shenglei ; edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ni, Ray ; Zeng, > Star > Subject: RE: [PATCH] MdeModulePkg/PropertiesTableAttributesDxe: > Remove this driver >=20 >=20 > Reviewed-by: Jian J Wang >=20 > > -----Original Message----- > > From: Zhang, Shenglei > > Sent: Monday, February 18, 2019 4:53 PM > > To: edk2-devel@lists.01.org > > Cc: Wang, Jian J ; Wu, Hao A > > ; Ni, Ray ; Zeng, Star > > > > Subject: [PATCH] MdeModulePkg/PropertiesTableAttributesDxe: Remove > > this driver > > > > This functionality of this driver has been deprecated and no platform > > employs this driver. It can be removed completely. > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1475 > > > > Cc: Jian J Wang > > Cc: Hao Wu > > Cc: Ray Ni > > Cc: Star Zeng > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Shenglei Zhang > > --- > > MdeModulePkg/MdeModulePkg.dsc | 1 - > > .../PropertiesTableAttributesDxe.c | 208 ------------------ > > .../PropertiesTableAttributesDxe.inf | 56 ----- > > .../PropertiesTableAttributesDxe.uni | 23 -- > > .../PropertiesTableAttributesDxeExtra.uni | 23 -- > > 5 files changed, 311 deletions(-) > > delete mode 100644 > > > MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAt > t > > ribu > > tesDxe.c > > delete mode 100644 > > > MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAt > t > > ribu > > tesDxe.inf > > delete mode 100644 > > > MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAt > t > > ribu > > tesDxe.uni > > delete mode 100644 > > > MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAt > t > > ribu > > tesDxeExtra.uni > > > > diff --git a/MdeModulePkg/MdeModulePkg.dsc > > b/MdeModulePkg/MdeModulePkg.dsc index 4f2ac8ae89..388bca25bd > 100644 > > --- a/MdeModulePkg/MdeModulePkg.dsc > > +++ b/MdeModulePkg/MdeModulePkg.dsc > > @@ -413,7 +413,6 @@ > > MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf > > MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmpDxe.inf > > > > - > > > MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTableAt > t > > ribu > > tesDxe.inf > > MdeModulePkg/Universal/FileExplorerDxe/FileExplorerDxe.inf { > > > > > > FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.i > > nf > > diff --git > > > a/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTable > A > > ttri > > butesDxe.c > > > b/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTable > A > > ttri > > butesDxe.c > > deleted file mode 100644 > > index 4d1a46f64c..0000000000 > > --- > > > a/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTable > A > > ttri > > butesDxe.c > > +++ /dev/null > > @@ -1,208 +0,0 @@ > > -/** @file > > - This module sets default policy for attributes of EfiACPIMemoryNVS > > and EfiReservedMemoryType. > > - > > - This module sets EFI_MEMORY_XP for attributes of EfiACPIMemoryNVS > > and EfiReservedMemoryType > > - in UEFI memory map, if and only of PropertiesTable is published and > > has BIT0 set. > > - > > -Copyright (c) 2015 - 2018, Intel Corporation. All rights > > reserved.
-This program and the accompanying materials -are > > licensed and made available under the terms and conditions of the BSD > > License -which accompanies this distribution. The full text of the > > license may be found at > > -http://opensource.org/licenses/bsd-license.php > > - > > -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > > -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR > > IMPLIED. > > - > > -**/ > > - > > -#include > > -#include > > -#include > > -#include -#include > > -#include > > -#include -#include > > - > > -/** > > - Converts a number of EFI_PAGEs to a size in bytes. > > - > > - NOTE: Do not use EFI_PAGES_TO_SIZE because it handles UINTN only. > > - > > - @param Pages The number of EFI_PAGES. > > - > > - @return The number of bytes associated with the number of > > EFI_PAGEs specified > > - by Pages. > > -**/ > > -UINT64 > > -EfiPagesToSize ( > > - IN UINT64 Pages > > - ) > > -{ > > - return LShiftU64 (Pages, EFI_PAGE_SHIFT); -} > > - > > -/** > > - Set memory attributes according to default policy. > > - > > - @param MemoryMap A pointer to the buffer in which firmware > places > > the current memory map. > > - @param MemoryMapSize Size, in bytes, of the MemoryMap buffer. > > - @param DescriptorSize size, in bytes, of an individual > > EFI_MEMORY_DESCRIPTOR. > > -**/ > > -VOID > > -SetMemorySpaceAttributesDefault ( > > - IN EFI_MEMORY_DESCRIPTOR *MemoryMap, > > - IN UINTN MemoryMapSize, > > - IN UINTN DescriptorSize > > - ) > > -{ > > - EFI_MEMORY_DESCRIPTOR *MemoryMapEntry; > > - EFI_MEMORY_DESCRIPTOR *MemoryMapEnd; > > - EFI_STATUS Status; > > - > > - DEBUG ((EFI_D_INFO, "SetMemorySpaceAttributesDefault\n")); > > - > > - MemoryMapEntry =3D MemoryMap; > > - MemoryMapEnd =3D (EFI_MEMORY_DESCRIPTOR *) ((UINT8 *) > MemoryMap + > > MemoryMapSize); > > - while ((UINTN)MemoryMapEntry < (UINTN)MemoryMapEnd) { > > - if (MemoryMapEntry->PhysicalStart < BASE_1MB) { > > - // > > - // Do not touch memory space below 1MB > > - // > > - MemoryMapEntry =3D NEXT_MEMORY_DESCRIPTOR (MemoryMapEntry, > > DescriptorSize); > > - continue; > > - } > > - switch (MemoryMapEntry->Type) { > > - case EfiRuntimeServicesCode: > > - case EfiRuntimeServicesData: > > - // > > - // should be handled later; > > - // > > - break; > > - case EfiReservedMemoryType: > > - case EfiACPIMemoryNVS: > > - // > > - // Handle EfiReservedMemoryType and EfiACPIMemoryNVS, because > there > > might be firmware executable there. > > - // > > - DEBUG ((EFI_D_INFO, "SetMemorySpaceAttributes - %016lx - %016lx > > (%016lx) ...\n", > > - MemoryMapEntry->PhysicalStart, > > - MemoryMapEntry->PhysicalStart + EfiPagesToSize > (MemoryMapEntry- > > >NumberOfPages), > > - MemoryMapEntry->Attribute > > - )); > > - Status =3D gDS->SetMemorySpaceCapabilities ( > > - MemoryMapEntry->PhysicalStart, > > - EfiPagesToSize (MemoryMapEntry->NumberOfPages), > > - MemoryMapEntry->Attribute | EFI_MEMORY_XP > > - ); > > - DEBUG ((EFI_D_INFO, "SetMemorySpaceCapabilities - %r\n", Status)= ); > > - break; > > - } > > - > > - MemoryMapEntry =3D NEXT_MEMORY_DESCRIPTOR (MemoryMapEntry, > > DescriptorSize); > > - } > > - > > - return ; > > -} > > - > > -/** > > - Update memory attributes according to default policy. > > - > > - @param[in] Event The Event this notify function registered to. > > - @param[in] Context Pointer to the context data registered to the = Event. > > -**/ > > -VOID > > -EFIAPI > > -UpdateMemoryAttributesDefault ( > > - EFI_EVENT Event, > > - VOID *Context > > - ) > > -{ > > - EFI_STATUS Status; > > - EFI_MEMORY_DESCRIPTOR *MemoryMap; > > - UINTN MemoryMapSize; > > - UINTN MapKey; > > - UINTN DescriptorSize; > > - UINT32 DescriptorVersion; > > - EFI_PROPERTIES_TABLE *PropertiesTable; > > - > > - DEBUG ((EFI_D_INFO, "UpdateMemoryAttributesDefault\n")); > > - Status =3D EfiGetSystemConfigurationTable (&gEfiPropertiesTableGuid, > > (VOID **) &PropertiesTable); > > - if (EFI_ERROR (Status)) { > > - goto Done; > > - } > > - > > - ASSERT (PropertiesTable !=3D NULL); > > - > > - DEBUG ((EFI_D_INFO, "MemoryProtectionAttribute - 0x%016lx\n", > > PropertiesTable->MemoryProtectionAttribute)); > > - if ((PropertiesTable->MemoryProtectionAttribute & > > > EFI_PROPERTIES_RUNTIME_MEMORY_PROTECTION_NON_EXECUTABLE_PE > _D > > ATA) =3D=3D 0) { > > - goto Done; > > - } > > - > > - // > > - // Get the EFI memory map. > > - // > > - MemoryMapSize =3D 0; > > - MemoryMap =3D NULL; > > - Status =3D gBS->GetMemoryMap ( > > - &MemoryMapSize, > > - MemoryMap, > > - &MapKey, > > - &DescriptorSize, > > - &DescriptorVersion > > - ); > > - ASSERT (Status =3D=3D EFI_BUFFER_TOO_SMALL); > > - do { > > - MemoryMap =3D (EFI_MEMORY_DESCRIPTOR *) AllocatePool > > (MemoryMapSize); > > - ASSERT (MemoryMap !=3D NULL); > > - Status =3D gBS->GetMemoryMap ( > > - &MemoryMapSize, > > - MemoryMap, > > - &MapKey, > > - &DescriptorSize, > > - &DescriptorVersion > > - ); > > - if (EFI_ERROR (Status)) { > > - FreePool (MemoryMap); > > - } > > - } while (Status =3D=3D EFI_BUFFER_TOO_SMALL); > > - ASSERT_EFI_ERROR (Status); > > - > > - SetMemorySpaceAttributesDefault (MemoryMap, MemoryMapSize, > > DescriptorSize); > > - > > -Done: > > - gBS->CloseEvent (Event); > > - > > - return ; > > -} > > - > > -/** > > - The entrypoint of properties table attribute driver. > > - > > - @param ImageHandle The firmware allocated handle for the EFI ima= ge. > > - @param SystemTable A pointer to the EFI System Table. > > - > > - @retval EFI_SUCCESS It always returns EFI_SUCCESS. > > - > > -**/ > > -EFI_STATUS > > -EFIAPI > > -InitializePropertiesTableAttributesDxe ( > > - IN EFI_HANDLE ImageHandle, > > - IN EFI_SYSTEM_TABLE *SystemTable > > - ) > > -{ > > - EFI_STATUS Status; > > - EFI_EVENT ReadyToBootEvent; > > - > > - Status =3D gBS->CreateEventEx ( > > - EVT_NOTIFY_SIGNAL, > > - TPL_CALLBACK, > > - UpdateMemoryAttributesDefault, > > - NULL, > > - &gEfiEventReadyToBootGuid, > > - &ReadyToBootEvent > > - ); > > - ASSERT_EFI_ERROR (Status); > > - > > - return EFI_SUCCESS; > > -} > > diff --git > > > a/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTable > A > > ttri > > butesDxe.inf > > > b/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTable > A > > ttri > > butesDxe.inf > > deleted file mode 100644 > > index a8edf854bb..0000000000 > > --- > > > a/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTable > A > > ttri > > butesDxe.inf > > +++ /dev/null > > @@ -1,56 +0,0 @@ > > -## @file > > -# This module sets default policy for attributes of EfiACPIMemoryNVS > > and EfiReservedMemoryType. > > -# > > -# This module sets EFI_MEMORY_XP for attributes of EfiACPIMemoryNVS > > and EfiReservedMemoryType -# in UEFI memory map, if and only of > > PropertiesTable is published and has BIT0 set. > > -# > > -# Copyright (c) 2015 - 2018, Intel Corporation. All rights > > reserved.
-# -# This program and the accompanying materials -# > > are licensed and made available under the terms and conditions of the > > BSD License -# which accompanies this distribution. The full text of > > the license may be found at -# > > http://opensource.org/licenses/bsd-license.php > > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > > BASIS, > > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS > > OR IMPLIED. > > -# > > -# > > -## > > - > > -[Defines] > > - INF_VERSION =3D 0x00010005 > > - BASE_NAME =3D PropertiesTableAttributesDxe > > - MODULE_UNI_FILE =3D PropertiesTableAttributesDxe.uni > > - FILE_GUID =3D AA48FBB2-9F87-4DFD-B416-575938F0C= 8F4 > > - MODULE_TYPE =3D DXE_DRIVER > > - VERSION_STRING =3D 1.0 > > - ENTRY_POINT =3D InitializePropertiesTableAttribut= esDxe > > - > > -# > > -# The following information is for reference only and not required by > > the build tools. > > -# > > -# VALID_ARCHITECTURES =3D IA32 X64 EBC > > -# > > - > > -[Sources] > > - PropertiesTableAttributesDxe.c > > - > > -[Packages] > > - MdePkg/MdePkg.dec > > - > > -[LibraryClasses] > > - UefiDriverEntryPoint > > - UefiBootServicesTableLib > > - DxeServicesTableLib > > - DebugLib > > - UefiLib > > - MemoryAllocationLib > > - > > -[Guids] > > - gEfiEventReadyToBootGuid ## CONSUMES ## Event > > - gEfiPropertiesTableGuid ## CONSUMES ## SystemT= able > > - > > -[Depex] > > - TRUE > > - > > -[UserExtensions.TianoCore."ExtraFiles"] > > - PropertiesTableAttributesDxeExtra.uni > > diff --git > > > a/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTable > A > > ttri > > butesDxe.uni > > > b/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTable > A > > ttri > > butesDxe.uni > > deleted file mode 100644 > > index 9df097f7ce..0000000000 > > --- > > > a/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTable > A > > ttri > > butesDxe.uni > > +++ /dev/null > > @@ -1,23 +0,0 @@ > > -// /** @file > > -// This module sets default policy for attributes of > > EfiACPIMemoryNVS and EfiReservedMemoryType. > > -// > > -// This module sets EFI_MEMORY_XP for attributes of > EfiACPIMemoryNVS > > and EfiReservedMemoryType -// in UEFI memory map, if and only of > > PropertiesTable is published and has > > BIT0 set. > > -// > > -// Copyright (c) 2015, Intel Corporation. All rights reserved.
> > -// -// This program and the accompanying materials -// are licensed > > and made available under the terms and conditions of the BSD License > > -// which accompanies this distribution. The full text of the license > > may be found at -// http://opensource.org/licenses/bsd-license.php > > -// > > -// THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > > BASIS, > > -// WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS > > OR IMPLIED. > > -// > > -// **/ > > - > > - > > -#string STR_MODULE_ABSTRACT #language en-US "This module > sets > > default policy for attributes of EfiACPIMemoryNVS and > > EfiReservedMemoryType." > > - > > -#string STR_MODULE_DESCRIPTION #language en-US "This module > sets > > EFI_MEMORY_XP for attributes of EfiACPIMemoryNVS and > > EfiReservedMemoryType in UEFI memory map, if and only of > > PropertiesTable is published and has BIT0 set." > > - > > diff --git > > > a/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTable > A > > ttri > > butesDxeExtra.uni > > > b/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTable > A > > ttri > > butesDxeExtra.uni > > deleted file mode 100644 > > index e107e78523..0000000000 > > --- > > > a/MdeModulePkg/Universal/PropertiesTableAttributesDxe/PropertiesTable > A > > ttri > > butesDxeExtra.uni > > +++ /dev/null > > @@ -1,23 +0,0 @@ > > -// /** @file > > -// This module sets default policy for attributes of > > EfiACPIMemoryNVS and EfiReservedMemoryType. > > -// > > -// This module sets EFI_MEMORY_XP for attributes of > EfiACPIMemoryNVS > > and EfiReservedMemoryType -// in UEFI memory map, if and only of > > PropertiesTable is published and has > > BIT0 set. > > -// > > -// Copyright (c) 2015, Intel Corporation. All rights reserved.
> > -// -// This program and the accompanying materials -// are licensed > > and made available under the terms and conditions of the BSD License > > -// which accompanies this distribution. The full text of the license > > may be found at -// http://opensource.org/licenses/bsd-license.php > > -// > > -// THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > > BASIS, > > -// WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS > > OR IMPLIED. > > -// > > -// **/ > > - > > -#string STR_PROPERTIES_MODULE_NAME > > -#language en-US > > -"PropertiesTable Attributes Setting DXE Driver" > > - > > - > > -- > > 2.18.0.windows.1