From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=ray.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 759CB201B0457 for ; Fri, 22 Feb 2019 01:47:16 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Feb 2019 01:47:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,399,1544515200"; d="scan'208";a="116931434" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga007.jf.intel.com with ESMTP; 22 Feb 2019 01:47:15 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 22 Feb 2019 01:47:15 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 22 Feb 2019 01:47:14 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.253]) with mapi id 14.03.0415.000; Fri, 22 Feb 2019 17:47:12 +0800 From: "Ni, Ray" To: "Chen, Chen A" , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [PATCH] MdeModulePkg: Rename confusion function name Thread-Index: AQHUykZV3R+clYm+UEGg0qLX7PTVO6Xrkmxg Date: Fri, 22 Feb 2019 09:47:10 +0000 Deferred-Delivery: Fri, 22 Feb 2019 09:47:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C02CB35@SHSMSX104.ccr.corp.intel.com> References: <20190222003405.12696-1-chen.a.chen@intel.com> In-Reply-To: <20190222003405.12696-1-chen.a.chen@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTIyNmE0ZWUtNThmNS00NWZjLWJmMmItMzI1YzEwYTFmOGU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUnlUbzJJWnJkTGNOSTBFZ2J2WjhvR1R2MXZqanhFVFBtN0RqUWsramlURXArQkIxM1FSZFVuNVl3c0VMdlJHWSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg: Rename confusion function name X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Feb 2019 09:47:16 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Chen, Chen A > Sent: Friday, February 22, 2019 8:34 AM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A ; Ni, Ray ; Gao= , > Liming > Subject: [PATCH] MdeModulePkg: Rename confusion function name >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1536 >=20 > To avoid the confusion caused by function name, > rename EfiBootManagerGetNextFullDevicePath to > EfiBootManagerGetNextLoadOptionDevicePath. > As an API function should add EFIAPI prefix for this function. >=20 > Cc: Ray Ni > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Chen A Chen > --- > MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c | 2 +- > MdeModulePkg/Include/Library/UefiBootManagerLib.h | 3 ++- > MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 3 ++- > 3 files changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c > b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c > index f6e46cbdb1..4ff69af1b4 100644 > --- a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c > +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c > @@ -355,7 +355,7 @@ GetEfiSysPartitionFromBootOptionFilePath ( > // > do { > PreFullPath =3D CurFullPath; > - CurFullPath =3D EfiBootManagerGetNextFullDevicePath (DevicePath, > CurFullPath); > + CurFullPath =3D EfiBootManagerGetNextLoadOptionDevicePath (DevicePat= h, > CurFullPath); >=20 > if (PreFullPath !=3D NULL) { > FreePool (PreFullPath); > diff --git a/MdeModulePkg/Include/Library/UefiBootManagerLib.h > b/MdeModulePkg/Include/Library/UefiBootManagerLib.h > index 64347ff160..69678a62ca 100644 > --- a/MdeModulePkg/Include/Library/UefiBootManagerLib.h > +++ b/MdeModulePkg/Include/Library/UefiBootManagerLib.h > @@ -460,7 +460,8 @@ EfiBootManagerGetBootManagerMenu ( > Caller is responsible to free the memory. > **/ > EFI_DEVICE_PATH_PROTOCOL * > -EfiBootManagerGetNextFullDevicePath ( > +EFIAPI > +EfiBootManagerGetNextLoadOptionDevicePath ( > IN EFI_DEVICE_PATH_PROTOCOL *FilePath, > IN EFI_DEVICE_PATH_PROTOCOL *FullPath > ); > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > index 9be1633b74..d5957db610 100644 > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > @@ -2482,7 +2482,8 @@ EfiBootManagerGetBootManagerMenu ( > Caller is responsible to free the memory. > **/ > EFI_DEVICE_PATH_PROTOCOL * > -EfiBootManagerGetNextFullDevicePath ( > +EFIAPI > +EfiBootManagerGetNextLoadOptionDevicePath ( > IN EFI_DEVICE_PATH_PROTOCOL *FilePath, > IN EFI_DEVICE_PATH_PROTOCOL *FullPath > ) > -- > 2.16.2.windows.1