From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=ray.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A9ADD208AE36B for ; Fri, 22 Feb 2019 03:50:27 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Feb 2019 03:50:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,399,1544515200"; d="scan'208";a="322524586" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 22 Feb 2019 03:50:26 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 22 Feb 2019 03:50:26 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 22 Feb 2019 03:50:26 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by shsmsx102.ccr.corp.intel.com ([169.254.2.207]) with mapi id 14.03.0415.000; Fri, 22 Feb 2019 19:50:24 +0800 From: "Ni, Ray" To: Laszlo Ersek , "edk2-devel@lists.01.org" CC: "Bi, Dandan" , "Wu, Hao A" , "Wang, Jian J" , Sean Brogan , "Zeng, Star" Thread-Topic: [PATCH v3 1/5] MdeModulePkg/UefiBootManagerLib: fix LoadImage/StartImage status code rep. Thread-Index: AQHUydIAU9tJKt76dUqRWRZ+9YXdeKXrtUpA Date: Fri, 22 Feb 2019 11:50:23 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C02CEB3@SHSMSX104.ccr.corp.intel.com> References: <20190221104112.14995-1-lersek@redhat.com> <20190221104112.14995-2-lersek@redhat.com> In-Reply-To: <20190221104112.14995-2-lersek@redhat.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDhmOWNiNjUtMjM5ZC00MjE4LWJmMGEtMzZiZjUwMzk4NjM1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiM0RTWkE0UlJqMkpCY2Erak5JZDFmdmt5U0NaREVCUWh3SzRUbjF1d0F0NnJlXC81bGVadkg0RWZLcTl6aGRxbkwifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v3 1/5] MdeModulePkg/UefiBootManagerLib: fix LoadImage/StartImage status code rep. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Feb 2019 11:50:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Thursday, February 21, 2019 6:41 PM > To: edk2-devel@lists.01.org > Cc: Bi, Dandan ; Wu, Hao A ; > Wang, Jian J ; Ni, Ray ; Sean Br= ogan > ; Zeng, Star > Subject: [PATCH v3 1/5] MdeModulePkg/UefiBootManagerLib: fix > LoadImage/StartImage status code rep. > + if (!ReportErrorCodeEnabled ()) { > + return; > + } Sorry I didn't notice this piece of code in V2. The if-check-return code is not needed here. Because the implementation of ReportStatusCodeLib is responsible to do the filter. See below: EFI_STATUS InternalReportStatusCode ( IN EFI_STATUS_CODE_TYPE Type, IN EFI_STATUS_CODE_VALUE Value, IN UINT32 Instance, IN CONST EFI_GUID *CallerId OPTIONAL, IN EFI_STATUS_CODE_DATA *Data OPTIONAL ) { if ((ReportProgressCodeEnabled() && ((Type) & EFI_STATUS_CODE_TYPE_MASK) = =3D=3D EFI_PROGRESS_CODE) || (ReportErrorCodeEnabled() && ((Type) & EFI_STATUS_CODE_TYPE_MASK) =3D= =3D EFI_ERROR_CODE) || (ReportDebugCodeEnabled() && ((Type) & EFI_STATUS_CODE_TYPE_MASK) =3D= =3D EFI_DEBUG_CODE)) { ... With the removal of the three lines code, Reviewed-by: Ray Ni