From: "Ni, Ray" <ray.ni@intel.com>
To: "Justen, Jordan L" <jordan.l.justen@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] EmulatorPkg/Sec: Don't install TemporaryRamSupport PPI
Date: Tue, 5 Mar 2019 02:37:03 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C05DE53@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <155156311737.17885.4362726503400495940@jljusten-skl>
> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Jordan
> Justen
> Sent: Sunday, March 3, 2019 5:45 AM
> To: Ni, Ray <ray.ni@intel.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] EmulatorPkg/Sec: Don't install
> TemporaryRamSupport PPI
>
> On 2019-03-02 04:11:11, Ray Ni wrote:
> >
> > So this patch removes TemporaryRamSupport PPI implementation from
> > EmulatorPkg/Sec module to fix the boot failure when using GCC5.
>
> I don't think we should just hide the known bug with the
> TemporaryRamSupport PPI implementation in the PEI Core.
>
> I would agree that we should make this change after addressing that.
Jordan,
I have a goal to replace Nt32 with EmulatorPkg before Q2 stable tag release.
I understand we need more discussions on how to fix the PeiCore bug.
So I don't want this blocks the Nt32 deletion.
And in my opinion, the TemporaryRamSupport PPI that requires being called
from assembly code is a design bug.
I suggest to change the PI spec instead of changing PeiCore by introducing
more assembly code to hide this design bug.
Thanks,
Ray
next prev parent reply other threads:[~2019-03-05 2:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 12:11 [PATCH] EmulatorPkg/Sec: Don't install TemporaryRamSupport PPI Ray Ni
2019-03-02 21:45 ` Jordan Justen
2019-03-05 2:37 ` Ni, Ray [this message]
2019-03-05 21:48 ` Jordan Justen
2019-03-06 2:23 ` Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C05DE53@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox