From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=ray.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AFC1F2194EB70 for ; Mon, 4 Mar 2019 18:37:07 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2019 18:37:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,442,1544515200"; d="scan'208";a="149281532" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 04 Mar 2019 18:37:06 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 4 Mar 2019 18:37:06 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 4 Mar 2019 18:37:06 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.74]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.113]) with mapi id 14.03.0415.000; Tue, 5 Mar 2019 10:37:04 +0800 From: "Ni, Ray" To: "Justen, Jordan L" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH] EmulatorPkg/Sec: Don't install TemporaryRamSupport PPI Thread-Index: AQHU0PCpA5DuGIhItkyrZYGge3n9eqX4WnWAgAP7ffA= Date: Tue, 5 Mar 2019 02:37:03 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C05DE53@SHSMSX104.ccr.corp.intel.com> References: <20190302121111.70992-1-ray.ni@intel.com> <155156311737.17885.4362726503400495940@jljusten-skl> In-Reply-To: <155156311737.17885.4362726503400495940@jljusten-skl> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] EmulatorPkg/Sec: Don't install TemporaryRamSupport PPI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2019 02:37:08 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: edk2-devel On Behalf Of Jordan > Justen > Sent: Sunday, March 3, 2019 5:45 AM > To: Ni, Ray ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] EmulatorPkg/Sec: Don't install > TemporaryRamSupport PPI >=20 > On 2019-03-02 04:11:11, Ray Ni wrote: > > > > So this patch removes TemporaryRamSupport PPI implementation from > > EmulatorPkg/Sec module to fix the boot failure when using GCC5. >=20 > I don't think we should just hide the known bug with the > TemporaryRamSupport PPI implementation in the PEI Core. >=20 > I would agree that we should make this change after addressing that. Jordan, I have a goal to replace Nt32 with EmulatorPkg before Q2 stable tag release= . I understand we need more discussions on how to fix the PeiCore bug. So I don't want this blocks the Nt32 deletion. And in my opinion, the TemporaryRamSupport PPI that requires being called from assembly code is a design bug. I suggest to change the PI spec instead of changing PeiCore by introducing more assembly code to hide this design bug. Thanks, Ray