From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=ray.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C8485211CBCFB for ; Tue, 5 Mar 2019 18:24:01 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2019 18:24:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,446,1544515200"; d="scan'208";a="304734863" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 05 Mar 2019 18:24:00 -0800 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 5 Mar 2019 18:23:52 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 5 Mar 2019 18:23:52 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.74]) by shsmsx102.ccr.corp.intel.com ([169.254.2.163]) with mapi id 14.03.0415.000; Wed, 6 Mar 2019 10:23:49 +0800 From: "Ni, Ray" To: "edk2-devel@lists.01.org" , "Kinney, Michael D" , "Gao, Liming" , "Wang, Jian J" , Ard Biesheuvel , "'leif.lindholm@linaro.org'" CC: Laszlo Ersek , "Justen, Jordan L" Thread-Topic: [edk2] [PATCH] EmulatorPkg/Sec: Don't install TemporaryRamSupport PPI Thread-Index: AQHU0PCpA5DuGIhItkyrZYGge3n9eqX4WnWAgAP7ffCAALxSAIAA0rdg Date: Wed, 6 Mar 2019 02:23:49 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C05FDB4@SHSMSX104.ccr.corp.intel.com> References: <20190302121111.70992-1-ray.ni@intel.com> <155156311737.17885.4362726503400495940@jljusten-skl> <734D49CCEBEEF84792F5B80ED585239D5C05DE53@SHSMSX104.ccr.corp.intel.com> <155182249221.4162.13515420509245239988@jljusten-skl> In-Reply-To: <155182249221.4162.13515420509245239988@jljusten-skl> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] EmulatorPkg/Sec: Don't install TemporaryRamSupport PPI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2019 02:24:02 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: edk2-devel On Behalf Of Jordan > Justen > Sent: Wednesday, March 6, 2019 5:48 AM > To: Ni, Ray ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Laszlo Ersek > > Subject: Re: [edk2] [PATCH] EmulatorPkg/Sec: Don't install > TemporaryRamSupport PPI >=20 > On 2019-03-04 18:37:03, Ni, Ray wrote: > > > > > -----Original Message----- > > > From: edk2-devel On Behalf Of > > > Jordan Justen > > > Sent: Sunday, March 3, 2019 5:45 AM > > > To: Ni, Ray ; edk2-devel@lists.01.org > > > Subject: Re: [edk2] [PATCH] EmulatorPkg/Sec: Don't install > > > TemporaryRamSupport PPI > > > > > > On 2019-03-02 04:11:11, Ray Ni wrote: > > > > > > > > So this patch removes TemporaryRamSupport PPI implementation from > > > > EmulatorPkg/Sec module to fix the boot failure when using GCC5. > > > > > > I don't think we should just hide the known bug with the > > > TemporaryRamSupport PPI implementation in the PEI Core. > > > > > > I would agree that we should make this change after addressing that. > > > > Jordan, > > I have a goal to replace Nt32 with EmulatorPkg before Q2 stable tag rel= ease. > > I understand we need more discussions on how to fix the PeiCore bug. > > So I don't want this blocks the Nt32 deletion. >=20 > Given the choice of fixing a known bug in PEI Core relating to the PI spe= c > TemporaryRamSupport PPI, or deleting Nt32, I would choose fixing the bug. >=20 > But, why not fix the bug, and then make this change? >=20 Mike, Liming, Jian, Can you please review Jordan's patch to fix the code calling TemporaryRamSu= pport PPI in PeiCore with some assembly code? Personally I don't like the assembly code. But you are the experts and maintainers, I am ok if you give a R-b. Ard, Leif, Jordan is fixing a bug in PeiCore but only fixing x86. I am not sure whethe= r ARM code also contains such TemporaryRamSupport PPI issue. Thanks, Ray