From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=ray.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5432821959CB2 for ; Thu, 28 Mar 2019 18:50:09 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2019 18:50:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,282,1549958400"; d="scan'208";a="144797826" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 28 Mar 2019 18:50:06 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 28 Mar 2019 18:50:04 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 28 Mar 2019 18:50:00 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.74]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.252]) with mapi id 14.03.0415.000; Fri, 29 Mar 2019 09:49:58 +0800 From: "Ni, Ray" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" Thread-Topic: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib Thread-Index: AQHU5dCSodQBYYsUpk+tcVR3QhDa26Yh12Mw Date: Fri, 29 Mar 2019 01:49:57 +0000 Deferred-Delivery: Fri, 29 Mar 2019 01:49:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C0A27F5@SHSMSX104.ccr.corp.intel.com> References: <20190329014126.20208-1-shenglei.zhang@intel.com> <20190329014126.20208-3-shenglei.zhang@intel.com> In-Reply-To: <20190329014126.20208-3-shenglei.zhang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmM0ZDlhMzAtMjExOS00ODM2LTk0NzMtNTY3OTE2Njk5ZjQxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTEJ1Y0pZamdRRUtmWnFnajY4YmlDdDh0Znl4V3M0Q2ZEdFhcLzlLalBhdWRGNml2R1BEenRzVnBDZUJcL2w0b2ZZIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Mar 2019 01:50:09 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Zhang, Shenglei > Sent: Friday, March 29, 2019 9:41 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ray > Subject: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib >=20 > With Itanium architecture unsupported, gEfiSalSystemTableGuid and > gEfiMpsTableGuid will be no longer used. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1560 >=20 > Cc: Jaben Carsey > Cc: Ray Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c | 10 ---------- > .../UefiShellDebug1CommandsLib.inf | 2 -- > 2 files changed, 12 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c > index a4c18c9b68..023806742d 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c > @@ -17,9 +17,7 @@ > #include "UefiShellDebug1CommandsLib.h" > #include > #include > -#include > #include > -#include >=20 > /** > Make a printable character. > @@ -186,10 +184,6 @@ ShellCommandRunDmem ( > AcpiTableAddress =3D (UINT64)(UINTN)gST- > >ConfigurationTable[TableWalker].VendorTable; > continue; > } > - if (CompareGuid(&gST->ConfigurationTable[TableWalker].Vendor= Guid, > &gEfiSalSystemTableGuid)) { > - SalTableAddress =3D (UINT64)(UINTN)gST- > >ConfigurationTable[TableWalker].VendorTable; > - continue; > - } > if (CompareGuid(&gST->ConfigurationTable[TableWalker].Vendor= Guid, > &gEfiSmbiosTableGuid)) { > SmbiosTableAddress =3D (UINT64)(UINTN)gST- > >ConfigurationTable[TableWalker].VendorTable; > continue; > @@ -198,10 +192,6 @@ ShellCommandRunDmem ( > SmbiosTableAddress =3D (UINT64) (UINTN) gST- > >ConfigurationTable[TableWalker].VendorTable; > continue; > } > - if (CompareGuid(&gST->ConfigurationTable[TableWalker].Vendor= Guid, > &gEfiMpsTableGuid)) { > - MpsTableAddress =3D (UINT64)(UINTN)gST- > >ConfigurationTable[TableWalker].VendorTable; > - continue; > - } > } >=20 > ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_DMEM_SYSTEM_TA= BLE), > gShellDebug1HiiHandle, diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi > b.inf > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi > b.inf > index ec1f87ae19..f2666b7ff9 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi > b.inf > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Command > +++ sLib.inf > @@ -130,8 +130,6 @@ > gEfiGlobalVariableGuid ## SOMETIMES_CONSUMES ## GUID > gEfiSmbiosTableGuid ## SOMETIMES_CONSUMES ## SystemTable > gEfiSmbios3TableGuid ## SOMETIMES_CONSUMES ## SystemTable > - gEfiMpsTableGuid ## SOMETIMES_CONSUMES ## SystemTable > - gEfiSalSystemTableGuid ## SOMETIMES_CONSUMES ## SystemTable > gEfiAcpi10TableGuid ## SOMETIMES_CONSUMES ## SystemTable > gEfiAcpi20TableGuid ## SOMETIMES_CONSUMES ## SystemTable > gShellDebug1HiiGuid ## SOMETIMES_CONSUMES ## HII > -- > 2.18.0.windows.1