From: "Ni, Ray" <ray.ni@intel.com>
To: "Dong, Eric" <eric.dong@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch v2 1/4] UefiCpuPkg/RegisterCpuFeaturesLib: Remove useless functions.
Date: Tue, 2 Apr 2019 07:07:30 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C0C27AB@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190301053957.3572-2-eric.dong@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
Please remember to update the year in copyright when pushing.
> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Eric Dong
> Sent: Friday, March 1, 2019 1:40 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch v2 1/4] UefiCpuPkg/RegisterCpuFeaturesLib: Remove
> useless functions.
>
> Remove useless APIs, simplify the code logic.
>
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1375
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
> .../Include/Library/RegisterCpuFeaturesLib.h | 34 ---------------
> .../RegisterCpuFeaturesLib.c | 50 ----------------------
> 2 files changed, 84 deletions(-)
>
> diff --git a/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h
> b/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h
> index 2f7e71c833..073f020d0b 100644
> --- a/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h
> +++ b/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h
> @@ -166,40 +166,6 @@ IsCpuFeatureInSetting (
> IN UINT32 Feature
> );
>
> -/**
> - Determines if a CPU feature is set in PcdCpuFeaturesCapability bit mask.
> -
> - @param[in] Feature The bit number of the CPU feature to check in the PCD
> - PcdCpuFeaturesCapability.
> -
> - @retval TRUE The CPU feature is set in PcdCpuFeaturesCapability.
> - @retval FALSE The CPU feature is not set in PcdCpuFeaturesCapability.
> -
> - @note This service could be called by BSP only.
> -**/
> -BOOLEAN
> -EFIAPI
> -IsCpuFeatureCapability (
> - IN UINT32 Feature
> - );
> -
> -/**
> - Determines if a CPU feature is set in PcdCpuFeaturesUserConfiguration bit
> mask.
> -
> - @param[in] Feature The bit number of the CPU feature to check in the PCD
> - PcdCpuFeaturesUserConfiguration.
> -
> - @retval TRUE The CPU feature is set in PcdCpuFeaturesUserConfiguration.
> - @retval FALSE The CPU feature is not set in
> PcdCpuFeaturesUserConfiguration.
> -
> - @note This service could be called by BSP only.
> -**/
> -BOOLEAN
> -EFIAPI
> -IsCpuFeatureUserConfiguration (
> - IN UINT32 Feature
> - );
> -
> /**
> Prepares for the data used by CPU feature detection and initialization.
>
> diff --git
> a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> index ed8d526325..3540029079 100644
> --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> @@ -1242,56 +1242,6 @@ IsCpuFeatureInSetting (
> );
> }
>
> -/**
> - Determines if a CPU feature is set in PcdCpuFeaturesCapability bit mask.
> -
> - @param[in] Feature The bit number of the CPU feature to check in the PCD
> - PcdCpuFeaturesCapability
> -
> - @retval TRUE The CPU feature is set in PcdCpuFeaturesCapability.
> - @retval FALSE The CPU feature is not set in PcdCpuFeaturesCapability.
> -
> - @note This service could be called by BSP only.
> -**/
> -BOOLEAN
> -EFIAPI
> -IsCpuFeatureCapability (
> - IN UINT32 Feature
> - )
> -{
> - return IsCpuFeatureSetInCpuPcd (
> - (UINT8 *)PcdGetPtr (PcdCpuFeaturesCapability),
> - PcdGetSize (PcdCpuFeaturesCapability),
> - Feature
> - );
> -
> -}
> -
> -/**
> - Determines if a CPU feature is set in PcdCpuFeaturesUserConfiguration bit
> mask.
> -
> - @param[in] Feature The bit number of the CPU feature to check in the PCD
> - PcdCpuFeaturesUserConfiguration
> -
> - @retval TRUE The CPU feature is set in PcdCpuFeaturesUserConfiguration.
> - @retval FALSE The CPU feature is not set in
> PcdCpuFeaturesUserConfiguration.
> -
> - @note This service could be called by BSP only.
> -**/
> -BOOLEAN
> -EFIAPI
> -IsCpuFeatureUserConfiguration (
> - IN UINT32 Feature
> - )
> -{
> - return IsCpuFeatureSetInCpuPcd (
> - (UINT8 *)PcdGetPtr (PcdCpuFeaturesUserConfiguration),
> - PcdGetSize (PcdCpuFeaturesUserConfiguration),
> - Feature
> - );
> -
> -}
> -
> /**
> Switches to assigned BSP after CPU features initialization.
>
> --
> 2.15.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2019-04-02 7:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 5:39 [Patch v2 0/4] Simplify CPU Features solution Eric Dong
2019-03-01 5:39 ` [Patch v2 1/4] UefiCpuPkg/RegisterCpuFeaturesLib: Remove useless functions Eric Dong
2019-04-02 7:07 ` Ni, Ray [this message]
2019-03-01 5:39 ` [Patch v2 2/4] UefiCpuPkg/RegisterCpuFeaturesLib: Optimize PCD PcdCpuFeaturesUserConfiguration Eric Dong
2019-03-05 9:55 ` Zeng, Star
2019-03-05 9:56 ` Zeng, Star
2019-03-07 2:48 ` Dong, Eric
2019-04-02 7:15 ` Ni, Ray
2019-03-01 5:39 ` [Patch v2 3/4] UefiCpuPkg/RegisterCpuFeaturesLib: Simplify PcdCpuFeaturesSupport Eric Dong
2019-04-02 7:22 ` Ni, Ray
2019-03-01 5:39 ` [Patch v2 4/4] UefiCpuPkg/RegisterCpuFeaturesLib: Correct comments Eric Dong
2019-03-01 15:32 ` Laszlo Ersek
2019-04-02 7:22 ` Ni, Ray
2019-03-01 15:30 ` [Patch v2 0/4] Simplify CPU Features solution Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C0C27AB@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox