public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: ray.ni@intel.com
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	"Bi, Dandan" <dandan.bi@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Cetola, Stephano" <stephano.cetola@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>,
	"Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master
Date: Thu, 4 Apr 2019 03:42:40 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C0CCA8C@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9C78BC2@ORSMSX112.amr.corp.intel.com>

Mike, Laszlo,
It's a good idea to store the shell binaries into the assets of each stable tag.

If we go in this way, it means "build" requires network connection to download the
shell binary from the assets of a certain release.
Do you think it's acceptable?

Or we can separate the binary download and build into two phases so build phase
can be independent on network connection.

Is there any known practice/solution for such requirement (stable sub-component binaries
needed by a production image generation)?

Thanks,
Ray

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Thursday, April 4, 2019 5:47 AM
> To: Laszlo Ersek <lersek@redhat.com>; Ni, Ray <ray.ni@intel.com>; Bi,
> Dandan <dandan.bi@intel.com>; devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Cetola, Stephano <stephano.cetola@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
> Subject: RE: [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master
> 
> Laszlo,
> 
> A PREBUILD action looks like a good idea.
> 
> Release artifacts in GitHub are available as an http link, so a python script to
> download into a path in the build output directory and referenced by
> DSC/FDF should work.
> 
> We could even post shell binaries for the past couple edk2-stable tags
> because release content can be updated.
> 
> Mike
> 
> > -----Original Message-----
> > From: Laszlo Ersek [mailto:lersek@redhat.com]
> > Sent: Wednesday, April 3, 2019 9:07 AM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ray
> > <ray.ni@intel.com>; Bi, Dandan <dandan.bi@intel.com>;
> > edk2-devel@lists.01.org
> > Cc: Cetola, Stephano <stephano.cetola@intel.com>; Gao, Liming
> > <liming.gao@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
> > Subject: Re: [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master
> >
> > On 04/03/19 17:49, Kinney, Michael D wrote:
> > > Laszlo,
> > >
> > > I think it makes sense to post validated shell
> > binaries
> > > with the edk2-stable tag releases.  GitHub does
> > support
> > > this when a release tag is made.
> > >
> > > However, we would need to make it simple for a
> > platform
> > > to use a binary from that location.  We may need some enhancements
> > > to pull in binary artifacts from
> > different
> > > locations to support a platform build that uses one
> > or
> > > more pre-built binaries.
> >
> > Can PREBUILD scripts (written by platform owners) download the
> > required binaries?
> >
> > Thanks,
> > Laszlo

  reply	other threads:[~2019-04-04  3:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-02  5:38 [RFC] Plan to delete ShellBinPkg from edk2/master Bi, Dandan
2019-04-02  8:49 ` Laszlo Ersek
2019-04-02  9:12   ` Leif Lindholm
2019-04-02 11:29     ` Ryszard Knop
2019-04-02 11:45       ` Laszlo Ersek
2019-04-02 11:50         ` Ryszard Knop
2019-04-02 12:56           ` Laszlo Ersek
2019-04-03  2:17   ` Ni, Ray
2019-04-03 10:09     ` Laszlo Ersek
2019-04-03 15:49       ` Kinney, Michael D
2019-04-03 16:07         ` Laszlo Ersek
2019-04-03 21:47           ` [edk2] " Michael D Kinney
2019-04-04  3:42             ` ray.ni [this message]
2019-04-04  4:09               ` [edk2-devel] " Andrew Fish
2019-04-04 10:45                 ` Laszlo Ersek
2019-04-04 15:10                   ` Andrew Fish
2019-04-04 16:06                     ` Laszlo Ersek
2019-04-04 16:36                       ` Andrew Fish
2019-04-08  8:08                         ` Dandan Bi
2019-04-15 14:58                           ` Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C0CCA8C@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox