From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: ray.ni@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Mon, 15 Apr 2019 13:23:34 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Apr 2019 13:23:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,355,1549958400"; d="scan'208";a="134592002" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 15 Apr 2019 13:23:33 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 15 Apr 2019 13:23:33 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 15 Apr 2019 13:23:33 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.21]) with mapi id 14.03.0415.000; Tue, 16 Apr 2019 04:23:30 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "ard.biesheuvel@linaro.org" CC: "Kinney, Michael D" , Andrew Fish , Leif Lindholm , "Zeng, Star" , "Dong, Eric" , "Gao, Liming" , "Carsey, Jaben" , "Shi, Steven" , "Wang, Jian J" , "Wu, Hao A" Subject: Re: [edk2-devel] [PATCH v6 3/7] MdeModulePkg/PciBusDxe: dispatch option ROMs for foreign architectures Thread-Topic: [edk2-devel] [PATCH v6 3/7] MdeModulePkg/PciBusDxe: dispatch option ROMs for foreign architectures Thread-Index: AQHU8vutrlCdqIH8xEWlMk95V41d66Y9q8zA Date: Mon, 15 Apr 2019 20:23:29 +0000 Deferred-Delivery: Mon, 15 Apr 2019 20:23:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C0EEA3F@SHSMSX104.ccr.corp.intel.com> References: <20190414195233.30045-1-ard.biesheuvel@linaro.org> <20190414195233.30045-4-ard.biesheuvel@linaro.org> In-Reply-To: <20190414195233.30045-4-ard.biesheuvel@linaro.org> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzY5MDQ0MWEtMzc3Ny00Yjg4LTgxNGItNTQ3NzliYjI2N2Y0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZmx3VHpqRjhwNnBQVXNBaVdMN2J5ZE5wdE9VXC83VzlvTlR2T281MFV1Q1FaRXcrZjNVVnNaRWZBQ1NmWjZKWEwifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Ard Biesheuvel > Sent: Sunday, April 14, 2019 12:52 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Kinney, Michael D > ; Andrew Fish ; Leif > Lindholm ; Zeng, Star ; > Dong, Eric ; Ni, Ray ; Gao, Limin= g > ; Carsey, Jaben ; Shi, > Steven ; Wang, Jian J ; Wu, > Hao A > Subject: [edk2-devel] [PATCH v6 3/7] MdeModulePkg/PciBusDxe: dispatch > option ROMs for foreign architectures >=20 > Delete the explicit machine type check for option ROM images, and instea= d, > rely on the LoadImage() boot service to decide whether an option ROM can > be dispatched or not. This permits platforms to ship with emulators to > execute option ROMs that are not native to the processor architecture. >=20 > Signed-off-by: Ard Biesheuvel > Reviewed-by: Michael D Kinney > --- > MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 7 ------- > 1 file changed, 7 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c > index c75ef1a82505..54cf4251cc86 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c > @@ -699,13 +699,6 @@ ProcessOpRomImage ( > goto NextImage; > } >=20 > - // > - // Skip the EFI PCI Option ROM image if its machine type is not > supported > - // > - if (!EFI_IMAGE_MACHINE_TYPE_SUPPORTED (EfiRomHeader- > >EfiMachineType)) { > - goto NextImage; > - } > - > // > // Ignore the EFI PCI Option ROM image if it is an EFI application > // > -- > 2.17.1 >=20 >=20 >=20