From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Tue, 16 Apr 2019 09:26:14 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 09:26:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,358,1549958400"; d="scan'208";a="338166507" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 16 Apr 2019 09:26:14 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 09:26:13 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 09:26:13 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.149]) with mapi id 14.03.0415.000; Wed, 17 Apr 2019 00:26:11 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Gao, Liming" CC: "Feng, Bob C" Subject: Re: [edk2-devel] [PATCH v2] BaseTools: Remove the unnecessary copy action for module output files Thread-Topic: [edk2-devel] [PATCH v2] BaseTools: Remove the unnecessary copy action for module output files Thread-Index: AQHU9CwTQAe0E8RgqUybP4Bn2Z4S2aY++SQg Date: Tue, 16 Apr 2019 16:26:11 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C0F0350@SHSMSX104.ccr.corp.intel.com> References: <1555402279-11572-1-git-send-email-liming.gao@intel.com> In-Reply-To: <1555402279-11572-1-git-send-email-liming.gao@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTMwMDdhYTEtOWJmNS00M2I3LWE1MmMtOTMzODUwOTFkMGI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZSttY211dEowMXNVN1NvcitacDg5cEJEQ0ttdlVleko5YlIrMWw0RzZ3TGhQUm41WjNLXC9TWWo1bWl4VjlDZkIifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, Is there a place or maybe a spec to summarize the build output file locati= on? Platform may have script to reference some of the output files. Have a clear documentation from now on if there is not could be great to a= void future build breakage due to missing some of output files. Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Liming Gao > Sent: Tuesday, April 16, 2019 1:11 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C > Subject: [edk2-devel] [PATCH v2] BaseTools: Remove the unnecessary copy > action for module output files >=20 > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1673 >=20 > In v2, keep copy output image into $(BIN_DIR), the platform still uses > the output file in $(BIN_DIR). >=20 > Signed-off-by: Liming Gao > Cc: Bob Feng > --- > BaseTools/Conf/build_rule.template | 17 ++--------------- > 1 file changed, 2 insertions(+), 15 deletions(-) >=20 > diff --git a/BaseTools/Conf/build_rule.template > b/BaseTools/Conf/build_rule.template > index 030e74c35a..dbb68c62fb 100755 > --- a/BaseTools/Conf/build_rule.template > +++ b/BaseTools/Conf/build_rule.template > @@ -357,34 +357,21 @@ >=20 > > "$(GENFW)" -e $(MODULE_TYPE) -o ${dst} ${src} $(GENFW_FLAGS) > - $(CP) ${dst} $(DEBUG_DIR) > $(CP) ${dst} $(BIN_DIR)(+)$(MODULE_NAME_GUID).efi > - -$(CP) $(DEBUG_DIR)(+)*.map $(OUTPUT_DIR) > - -$(CP) $(DEBUG_DIR)(+)*.pdb $(OUTPUT_DIR) > + > > $(CP) ${src} $(DEBUG_DIR)(+)$(MODULE_NAME).debug > $(OBJCOPY) --strip-unneeded -R .eh_frame ${src} > - > - # > - #The below 2 lines are only needed for UNIXGCC tool chain, whic= h > generates PE image directly > - # > - -$(OBJCOPY) $(OBJCOPY_ADDDEBUGFLAG) ${src} > - -$(CP) $(DEBUG_DIR)(+)$(MODULE_NAME).debug > $(BIN_DIR)(+)$(MODULE_NAME_GUID).debug > - > "$(GENFW)" -e $(MODULE_TYPE) -o ${dst} ${src} $(GENFW_FLAGS) > - $(CP) ${dst} $(DEBUG_DIR) > $(CP) ${dst} $(BIN_DIR)(+)$(MODULE_NAME_GUID).efi > - -$(CP) $(DEBUG_DIR)(+)*.map $(OUTPUT_DIR) > - > + > > # tool to convert Mach-O to PE/COFF > "$(MTOC)" -subsystem $(MODULE_TYPE) $(MTOC_FLAGS) ${src} > $(DEBUG_DIR)(+)$(MODULE_NAME).pecoff > # create symbol file for GDB debug > -$(DSYMUTIL) ${src} > "$(GENFW)" -e $(MODULE_TYPE) -o ${dst} > $(DEBUG_DIR)(+)$(MODULE_NAME).pecoff $(GENFW_FLAGS) > - $(CP) ${dst} $(DEBUG_DIR) > $(CP) ${dst} $(BIN_DIR)(+)$(MODULE_NAME_GUID).efi > - -$(CP) $(DEBUG_DIR)(+)*.map $(OUTPUT_DIR) >=20 > [Dependency-Expression-File] > > -- > 2.13.0.windows.1 >=20 >=20 >=20