Re: [edk2-devel] [PATCH 19/25] PcAtChipsetPkg/ResetSystemLib: Add new API ResetSystem

["Ni, Ray" <ray.ni@intel.com>]

Reviewed-by: Ray Ni <ray.ni@intel.com>

> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Gao, Zhichao
> > Sent: Monday, April 15, 2019 11:06 AM
> > To: devel@edk2.groups.io
> > Cc: Ni, Ray <ray.ni@intel.com>; Gao, Liming <liming.gao@intel.com>
> > Subject: [edk2-devel] [PATCH 19/25] PcAtChipsetPkg/ResetSystemLib: Add
> > new API ResetSystem
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
> >
> > Add a new API ResetSystem to this ResetSystemLib instance.
> > It only adds the basic functions from ResetSystemRuntimeDxe.
> > Lacking of this interface may cause link error, if some drivers use
> > this new API and link to this library instance.
> > Notes:
> > This library API only provide a basic function of reset. Full function
> > should use the instance in the MdeModulePkg and make sure the depex
> > driver is dispatched.
> >
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> > ---
> >  .../Library/ResetSystemLib/ResetSystemLib.c   | 43 +++++++++++++++++++
> >  1 file changed, 43 insertions(+)
> >
> > diff --git a/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c
> > b/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c
> > index eccef89ebe..b215ebed61 100644
> > --- a/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c
> > +++ b/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c
> > @@ -99,3 +99,46 @@ ResetPlatformSpecific (  {
> >    ResetCold ();
> >  }
> > +
> > +/**
> > +  The ResetSystem function resets the entire platform.
> > +
> > +  @param[in] ResetType      The type of reset to perform.
> > +  @param[in] ResetStatus    The status code for the reset.
> > +  @param[in] DataSize       The size, in bytes, of ResetData.
> > +  @param[in] ResetData      For a ResetType of EfiResetCold, EfiResetWarm,
> > or EfiResetShutdown
> > +                            the data buffer starts with a Null-terminated string,
> optionally
> > +                            followed by additional binary data. The string is a
> description
> > +                            that the caller may use to further indicate the reason for
> the
> > +                            system reset.
> > +**/
> > +VOID
> > +EFIAPI
> > +ResetSystem (
> > +  IN EFI_RESET_TYPE               ResetType,
> > +  IN EFI_STATUS                   ResetStatus,
> > +  IN UINTN                        DataSize,
> > +  IN VOID                         *ResetData OPTIONAL
> > +  )
> > +{
> > +  switch (ResetType) {
> > +  case EfiResetWarm:
> > +    ResetWarm ();
> > +    break;
> > +
> > +  case EfiResetCold:
> > +    ResetCold ();
> > +    break;
> > +
> > +  case EfiResetShutdown:
> > +    ResetShutdown ();
> > +    return ;
> > +
> > +  case EfiResetPlatformSpecific:
> > +    ResetPlatformSpecific (DataSize, ResetData);
> > +    return;
> > +
> > +  default:
> > +    return ;
> > +  }
> > +}
> > --
> > 2.21.0.windows.1
> >
> >
> >