Re: [PATCH v2 2/4] ShellPkg/UefiShellDebug1CommandsLib

["Ni, Ray" <ray.ni@intel.com>]

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Thursday, April 25, 2019 8:02 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH v2 2/4] ShellPkg/UefiShellDebug1CommandsLib
> 
> With Itanium architecture unsupported, gEfiSalSystemTableGuid and
> gEfiMpsTableGuid will be no longer used.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1560
> 
> v2:Withdraw the removal of #include <Guid/Mps.h> and
>    gEfiMpsTableGuid.
> 
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c           | 5 -----
>  .../UefiShellDebug1CommandsLib.inf                           | 1 -
>  2 files changed, 6 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> index 59eee3082a..e6aec2e37c 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> @@ -13,7 +13,6 @@
>  #include <Guid/Acpi.h>
>  #include <Guid/Mps.h>
>  #include <Guid/SmBios.h>
> -#include <Guid/SalSystemTable.h>
> 
>  /**
>    Make a printable character.
> @@ -180,10 +179,6 @@ ShellCommandRunDmem (
>                AcpiTableAddress = (UINT64)(UINTN)gST-
> >ConfigurationTable[TableWalker].VendorTable;
>                continue;
>              }
> -            if (CompareGuid(&gST-
> >ConfigurationTable[TableWalker].VendorGuid, &gEfiSalSystemTableGuid)) {
> -              SalTableAddress = (UINT64)(UINTN)gST-
> >ConfigurationTable[TableWalker].VendorTable;
> -              continue;
> -            }
>              if (CompareGuid(&gST-
> >ConfigurationTable[TableWalker].VendorGuid, &gEfiSmbiosTableGuid)) {
>                SmbiosTableAddress = (UINT64)(UINTN)gST-
> >ConfigurationTable[TableWalker].VendorTable;
>                continue;
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsLib.inf
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsLib.inf
> index 2c8894a2cd..ed94477a06 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsLib.inf
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> d
> +++ sLib.inf
> @@ -126,7 +126,6 @@
>    gEfiSmbiosTableGuid             ## SOMETIMES_CONSUMES ## SystemTable
>    gEfiSmbios3TableGuid            ## SOMETIMES_CONSUMES ## SystemTable
>    gEfiMpsTableGuid                ## SOMETIMES_CONSUMES ## SystemTable
> -  gEfiSalSystemTableGuid          ## SOMETIMES_CONSUMES ## SystemTable
>    gEfiAcpi10TableGuid             ## SOMETIMES_CONSUMES ## SystemTable
>    gEfiAcpi20TableGuid             ## SOMETIMES_CONSUMES ## SystemTable
>    gShellDebug1HiiGuid             ## SOMETIMES_CONSUMES ## HII
> --
> 2.18.0.windows.1