From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ray.ni@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Thu, 25 Apr 2019 22:53:49 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 22:53:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,396,1549958400"; d="scan'208";a="226849851" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 25 Apr 2019 22:53:48 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 25 Apr 2019 22:53:48 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 25 Apr 2019 22:53:47 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.149]) with mapi id 14.03.0415.000; Fri, 26 Apr 2019 13:53:45 +0800 From: "Ni, Ray" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Carsey, Jaben" Subject: Re: [PATCH v2 2/4] ShellPkg/UefiShellDebug1CommandsLib Thread-Topic: [PATCH v2 2/4] ShellPkg/UefiShellDebug1CommandsLib Thread-Index: AQHU+9xo2nhPOLhbN0+FeurcWCSHxKZN8KFQ Date: Fri, 26 Apr 2019 05:53:45 +0000 Deferred-Delivery: Fri, 26 Apr 2019 05:53:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C105740@SHSMSX104.ccr.corp.intel.com> References: <20190426030142.7880-1-shenglei.zhang@intel.com> <20190426030142.7880-3-shenglei.zhang@intel.com> In-Reply-To: <20190426030142.7880-3-shenglei.zhang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzllMTZkNTgtMTZhMC00NDA4LWEyYWYtZDQ2YzNiNWJlZTc2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid0c1NkdtbElnVFNrcDVwUmhtelRxZWFzRzh0Nk9oQ2dYY2ZyYVdRWUxMOFZndTcxemdxZTlna1MzdjBzUWlVRiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Zhang, Shenglei > Sent: Thursday, April 25, 2019 8:02 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray > Subject: [PATCH v2 2/4] ShellPkg/UefiShellDebug1CommandsLib >=20 > With Itanium architecture unsupported, gEfiSalSystemTableGuid and > gEfiMpsTableGuid will be no longer used. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1560 >=20 > v2:Withdraw the removal of #include and > gEfiMpsTableGuid. >=20 > Cc: Jaben Carsey > Cc: Ray Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c | 5 ----- > .../UefiShellDebug1CommandsLib.inf | 1 - > 2 files changed, 6 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c > index 59eee3082a..e6aec2e37c 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c > @@ -13,7 +13,6 @@ > #include > #include > #include > -#include >=20 > /** > Make a printable character. > @@ -180,10 +179,6 @@ ShellCommandRunDmem ( > AcpiTableAddress =3D (UINT64)(UINTN)gST- > >ConfigurationTable[TableWalker].VendorTable; > continue; > } > - if (CompareGuid(&gST- > >ConfigurationTable[TableWalker].VendorGuid, &gEfiSalSystemTableGuid)) { > - SalTableAddress =3D (UINT64)(UINTN)gST- > >ConfigurationTable[TableWalker].VendorTable; > - continue; > - } > if (CompareGuid(&gST- > >ConfigurationTable[TableWalker].VendorGuid, &gEfiSmbiosTableGuid)) { > SmbiosTableAddress =3D (UINT64)(UINTN)gST- > >ConfigurationTable[TableWalker].VendorTable; > continue; > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.inf > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.inf > index 2c8894a2cd..ed94477a06 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.inf > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > d > +++ sLib.inf > @@ -126,7 +126,6 @@ > gEfiSmbiosTableGuid ## SOMETIMES_CONSUMES ## SystemTable > gEfiSmbios3TableGuid ## SOMETIMES_CONSUMES ## SystemTable > gEfiMpsTableGuid ## SOMETIMES_CONSUMES ## SystemTable > - gEfiSalSystemTableGuid ## SOMETIMES_CONSUMES ## SystemTable > gEfiAcpi10TableGuid ## SOMETIMES_CONSUMES ## SystemTable > gEfiAcpi20TableGuid ## SOMETIMES_CONSUMES ## SystemTable > gShellDebug1HiiGuid ## SOMETIMES_CONSUMES ## HII > -- > 2.18.0.windows.1