From: "Ni, Ray" <ray.ni@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [PATCH v2 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids
Date: Fri, 26 Apr 2019 05:56:45 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C1057C5@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190426030142.7880-4-shenglei.zhang@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Thursday, April 25, 2019 8:02 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH v2 3/4] ShellPkg/UefiHandleParsingLib: Remove some
> unused Guids
>
> ExtendedSalBootService.h, ExtendedSalServiceClasses.h and McaInitPmi.h
> will be deleted. So remove the Guids defined in these Protocols. And also
> remove strings in uni file.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1560
>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> Reviewed-by: Ray Ni <ray.ni@intel.com>
> ---
> .../UefiHandleParsingLib/UefiHandleParsingLib.c | 17 -----------------
> .../UefiHandleParsingLib.inf | 17 -----------------
> .../UefiHandleParsingLib.uni | 17 -----------------
> 3 files changed, 51 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> index 8e8fa13285..f179c41092 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> @@ -2315,23 +2315,6 @@ STATIC CONST GUID_INFO_BLOCK
> mGuidStringList[] = {
> {STRING_TOKEN(STR_FVB2),
> &gEfiFirmwareVolumeBlock2ProtocolGuid, NULL},
> {STRING_TOKEN(STR_CPUIO2), &gEfiCpuIo2ProtocolGuid,
> NULL},
> {STRING_TOKEN(STR_LEGACY_R2), &gEfiLegacyRegion2ProtocolGuid,
> NULL},
> - {STRING_TOKEN(STR_SAL_MIP), &gEfiSalMcaInitPmiProtocolGuid,
> NULL},
> - {STRING_TOKEN(STR_ES_BS),
> &gEfiExtendedSalBootServiceProtocolGuid, NULL},
> - {STRING_TOKEN(STR_ES_BIO),
> &gEfiExtendedSalBaseIoServicesProtocolGuid, NULL},
> - {STRING_TOKEN(STR_ES_STALL),
> &gEfiExtendedSalStallServicesProtocolGuid, NULL},
> - {STRING_TOKEN(STR_ES_RTC),
> &gEfiExtendedSalRtcServicesProtocolGuid, NULL},
> - {STRING_TOKEN(STR_ES_VS),
> &gEfiExtendedSalVariableServicesProtocolGuid, NULL},
> - {STRING_TOKEN(STR_ES_MTC),
> &gEfiExtendedSalMtcServicesProtocolGuid, NULL},
> - {STRING_TOKEN(STR_ES_RESET),
> &gEfiExtendedSalResetServicesProtocolGuid, NULL},
> - {STRING_TOKEN(STR_ES_SC),
> &gEfiExtendedSalStatusCodeServicesProtocolGuid, NULL},
> - {STRING_TOKEN(STR_ES_FBS),
> &gEfiExtendedSalFvBlockServicesProtocolGuid, NULL},
> - {STRING_TOKEN(STR_ES_MP),
> &gEfiExtendedSalMpServicesProtocolGuid, NULL},
> - {STRING_TOKEN(STR_ES_PAL),
> &gEfiExtendedSalPalServicesProtocolGuid, NULL},
> - {STRING_TOKEN(STR_ES_BASE),
> &gEfiExtendedSalBaseServicesProtocolGuid, NULL},
> - {STRING_TOKEN(STR_ES_MCA),
> &gEfiExtendedSalMcaServicesProtocolGuid, NULL},
> - {STRING_TOKEN(STR_ES_PCI),
> &gEfiExtendedSalPciServicesProtocolGuid, NULL},
> - {STRING_TOKEN(STR_ES_CACHE),
> &gEfiExtendedSalCacheServicesProtocolGuid, NULL},
> - {STRING_TOKEN(STR_ES_MCA_LOG),
> &gEfiExtendedSalMcaLogServicesProtocolGuid, NULL},
> {STRING_TOKEN(STR_S2ARCH), &gEfiSecurity2ArchProtocolGuid,
> NULL},
> {STRING_TOKEN(STR_EODXE), &gEfiSmmEndOfDxeProtocolGuid,
> NULL},
> {STRING_TOKEN(STR_ISAHC), &gEfiIsaHcProtocolGuid,
> NULL},
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> index 2a54529901..93b69cd8e9 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> @@ -229,23 +229,6 @@
> gEfiFirmwareVolumeBlock2ProtocolGuid ## UNDEFINED
> gEfiCpuIo2ProtocolGuid ## UNDEFINED
> gEfiLegacyRegion2ProtocolGuid ## UNDEFINED
> - gEfiSalMcaInitPmiProtocolGuid ## UNDEFINED
> - gEfiExtendedSalBootServiceProtocolGuid ## UNDEFINED
> - gEfiExtendedSalBaseIoServicesProtocolGuid ## UNDEFINED
> - gEfiExtendedSalStallServicesProtocolGuid ## UNDEFINED
> - gEfiExtendedSalRtcServicesProtocolGuid ## UNDEFINED
> - gEfiExtendedSalVariableServicesProtocolGuid ## UNDEFINED
> - gEfiExtendedSalMtcServicesProtocolGuid ## UNDEFINED
> - gEfiExtendedSalResetServicesProtocolGuid ## UNDEFINED
> - gEfiExtendedSalStatusCodeServicesProtocolGuid ## UNDEFINED
> - gEfiExtendedSalFvBlockServicesProtocolGuid ## UNDEFINED
> - gEfiExtendedSalMpServicesProtocolGuid ## UNDEFINED
> - gEfiExtendedSalPalServicesProtocolGuid ## UNDEFINED
> - gEfiExtendedSalBaseServicesProtocolGuid ## UNDEFINED
> - gEfiExtendedSalMcaServicesProtocolGuid ## UNDEFINED
> - gEfiExtendedSalPciServicesProtocolGuid ## UNDEFINED
> - gEfiExtendedSalCacheServicesProtocolGuid ## UNDEFINED
> - gEfiExtendedSalMcaLogServicesProtocolGuid ## UNDEFINED
> gEfiSecurity2ArchProtocolGuid ## UNDEFINED
> gEfiSmmEndOfDxeProtocolGuid ## UNDEFINED
> gEfiIsaHcProtocolGuid ## UNDEFINED
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
> index 15a270620f..9c8028d0d5 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
> @@ -268,23 +268,6 @@
> #string STR_FVB2 #language en-US "FirmwareVolumeBlock2"
> #string STR_CPUIO2 #language en-US "CpuIo2"
> #string STR_LEGACY_R2 #language en-US "LegacyRegion2"
> -#string STR_SAL_MIP #language en-US "SalMcaInitPmi"
> -#string STR_ES_BS #language en-US "ExtendedSalBootService"
> -#string STR_ES_BIO #language en-US "ExtendedSalBaseIoServices"
> -#string STR_ES_STALL #language en-US "ExtendedSalStallServices"
> -#string STR_ES_RTC #language en-US "ExtendedSalRtcServices"
> -#string STR_ES_VS #language en-US "ExtendedSalVariableServices"
> -#string STR_ES_MTC #language en-US "ExtendedSalMtcServices"
> -#string STR_ES_RESET #language en-US "ExtendedSalResetServices"
> -#string STR_ES_SC #language en-US
> "ExtendedSalStatusCodeServices"
> -#string STR_ES_FBS #language en-US "ExtendedSalFvBlockServices"
> -#string STR_ES_MP #language en-US "ExtendedSalMpServices"
> -#string STR_ES_PAL #language en-US "ExtendedSalPalServices"
> -#string STR_ES_BASE #language en-US "ExtendedSalBaseServices"
> -#string STR_ES_MCA #language en-US "ExtendedSalMcaServices"
> -#string STR_ES_PCI #language en-US "ExtendedSalPciServices"
> -#string STR_ES_CACHE #language en-US "ExtendedSalCacheServices"
> -#string STR_ES_MCA_LOG #language en-US
> "ExtendedSalMcaLogServices"
> #string STR_S2ARCH #language en-US "Security2Arch"
> #string STR_EODXE #language en-US "SmmEndOfDxe"
> #string STR_ISAHC #language en-US "IsaHc"
> --
> 2.18.0.windows.1
next prev parent reply other threads:[~2019-04-26 5:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 3:01 [PATCH v2 0/4] Remove IPF and related code Zhang, Shenglei
2019-04-26 3:01 ` [PATCH v2 1/4] OvmfPkg/PlatformBootManagerLib: Remove dependency on Mps.h Zhang, Shenglei
2019-04-26 3:01 ` [PATCH v2 2/4] ShellPkg/UefiShellDebug1CommandsLib Zhang, Shenglei
2019-04-26 5:53 ` Ni, Ray
2019-04-26 3:01 ` [PATCH v2 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids Zhang, Shenglei
2019-04-26 5:56 ` Ni, Ray [this message]
2019-04-26 3:01 ` [PATCH v2 4/4] MdePkg: Removed IPF related code Zhang, Shenglei
2019-04-26 4:40 ` [PATCH v2 0/4] Remove IPF and " Liming Gao
[not found] ` <1598EC71E5B05FD5.20378@groups.io>
2019-04-28 1:27 ` [edk2-devel] " Liming Gao
2019-04-28 1:32 ` Yao, Jiewen
2019-04-28 1:36 ` Liming Gao
2019-04-28 1:46 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C1057C5@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox