From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Thu, 25 Apr 2019 22:56:50 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 22:56:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,396,1549958400"; d="scan'208";a="145867823" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 25 Apr 2019 22:56:49 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 25 Apr 2019 22:56:48 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 25 Apr 2019 22:56:48 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.39]) with mapi id 14.03.0415.000; Fri, 26 Apr 2019 13:56:46 +0800 From: "Ni, Ray" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Carsey, Jaben" Subject: Re: [PATCH v2 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids Thread-Topic: [PATCH v2 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids Thread-Index: AQHU+9xp+lED2kDwI0qeuY39zqtycqZN8aIQ Date: Fri, 26 Apr 2019 05:56:45 +0000 Deferred-Delivery: Fri, 26 Apr 2019 05:56:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C1057C5@SHSMSX104.ccr.corp.intel.com> References: <20190426030142.7880-1-shenglei.zhang@intel.com> <20190426030142.7880-4-shenglei.zhang@intel.com> In-Reply-To: <20190426030142.7880-4-shenglei.zhang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTZiM2E1NjEtNzg0OC00Mzk1LThjYjctMzk3OGY5N2MxMzNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK2ZCeWZSVWIxM3VvYVwvQlFrMitmNHlZQlFlZWFYMmpyREdMZ3pVWk1rdUd6XC96UkpmOHlGTGlqeHhYYUhITTJXIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Zhang, Shenglei > Sent: Thursday, April 25, 2019 8:02 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray > Subject: [PATCH v2 3/4] ShellPkg/UefiHandleParsingLib: Remove some > unused Guids >=20 > ExtendedSalBootService.h, ExtendedSalServiceClasses.h and McaInitPmi.h > will be deleted. So remove the Guids defined in these Protocols. And also > remove strings in uni file. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1560 >=20 > Cc: Jaben Carsey > Cc: Ray Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > Reviewed-by: Jaben Carsey > Reviewed-by: Ray Ni > --- > .../UefiHandleParsingLib/UefiHandleParsingLib.c | 17 ----------------- > .../UefiHandleParsingLib.inf | 17 ----------------- > .../UefiHandleParsingLib.uni | 17 ----------------- > 3 files changed, 51 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > index 8e8fa13285..f179c41092 100644 > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > @@ -2315,23 +2315,6 @@ STATIC CONST GUID_INFO_BLOCK > mGuidStringList[] =3D { > {STRING_TOKEN(STR_FVB2), > &gEfiFirmwareVolumeBlock2ProtocolGuid, NULL}, > {STRING_TOKEN(STR_CPUIO2), &gEfiCpuIo2ProtocolGuid, > NULL}, > {STRING_TOKEN(STR_LEGACY_R2), &gEfiLegacyRegion2ProtocolGu= id, > NULL}, > - {STRING_TOKEN(STR_SAL_MIP), &gEfiSalMcaInitPmiProtocolGu= id, > NULL}, > - {STRING_TOKEN(STR_ES_BS), > &gEfiExtendedSalBootServiceProtocolGuid, NULL}, > - {STRING_TOKEN(STR_ES_BIO), > &gEfiExtendedSalBaseIoServicesProtocolGuid, NULL}, > - {STRING_TOKEN(STR_ES_STALL), > &gEfiExtendedSalStallServicesProtocolGuid, NULL}, > - {STRING_TOKEN(STR_ES_RTC), > &gEfiExtendedSalRtcServicesProtocolGuid, NULL}, > - {STRING_TOKEN(STR_ES_VS), > &gEfiExtendedSalVariableServicesProtocolGuid, NULL}, > - {STRING_TOKEN(STR_ES_MTC), > &gEfiExtendedSalMtcServicesProtocolGuid, NULL}, > - {STRING_TOKEN(STR_ES_RESET), > &gEfiExtendedSalResetServicesProtocolGuid, NULL}, > - {STRING_TOKEN(STR_ES_SC), > &gEfiExtendedSalStatusCodeServicesProtocolGuid, NULL}, > - {STRING_TOKEN(STR_ES_FBS), > &gEfiExtendedSalFvBlockServicesProtocolGuid, NULL}, > - {STRING_TOKEN(STR_ES_MP), > &gEfiExtendedSalMpServicesProtocolGuid, NULL}, > - {STRING_TOKEN(STR_ES_PAL), > &gEfiExtendedSalPalServicesProtocolGuid, NULL}, > - {STRING_TOKEN(STR_ES_BASE), > &gEfiExtendedSalBaseServicesProtocolGuid, NULL}, > - {STRING_TOKEN(STR_ES_MCA), > &gEfiExtendedSalMcaServicesProtocolGuid, NULL}, > - {STRING_TOKEN(STR_ES_PCI), > &gEfiExtendedSalPciServicesProtocolGuid, NULL}, > - {STRING_TOKEN(STR_ES_CACHE), > &gEfiExtendedSalCacheServicesProtocolGuid, NULL}, > - {STRING_TOKEN(STR_ES_MCA_LOG), > &gEfiExtendedSalMcaLogServicesProtocolGuid, NULL}, > {STRING_TOKEN(STR_S2ARCH), &gEfiSecurity2ArchProtocolGu= id, > NULL}, > {STRING_TOKEN(STR_EODXE), &gEfiSmmEndOfDxeProtocolGuid= , > NULL}, > {STRING_TOKEN(STR_ISAHC), &gEfiIsaHcProtocolGuid, > NULL}, > diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.i= nf > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > index 2a54529901..93b69cd8e9 100644 > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > @@ -229,23 +229,6 @@ > gEfiFirmwareVolumeBlock2ProtocolGuid ## UNDEFINED > gEfiCpuIo2ProtocolGuid ## UNDEFINED > gEfiLegacyRegion2ProtocolGuid ## UNDEFINED > - gEfiSalMcaInitPmiProtocolGuid ## UNDEFINED > - gEfiExtendedSalBootServiceProtocolGuid ## UNDEFINED > - gEfiExtendedSalBaseIoServicesProtocolGuid ## UNDEFINED > - gEfiExtendedSalStallServicesProtocolGuid ## UNDEFINED > - gEfiExtendedSalRtcServicesProtocolGuid ## UNDEFINED > - gEfiExtendedSalVariableServicesProtocolGuid ## UNDEFINED > - gEfiExtendedSalMtcServicesProtocolGuid ## UNDEFINED > - gEfiExtendedSalResetServicesProtocolGuid ## UNDEFINED > - gEfiExtendedSalStatusCodeServicesProtocolGuid ## UNDEFINED > - gEfiExtendedSalFvBlockServicesProtocolGuid ## UNDEFINED > - gEfiExtendedSalMpServicesProtocolGuid ## UNDEFINED > - gEfiExtendedSalPalServicesProtocolGuid ## UNDEFINED > - gEfiExtendedSalBaseServicesProtocolGuid ## UNDEFINED > - gEfiExtendedSalMcaServicesProtocolGuid ## UNDEFINED > - gEfiExtendedSalPciServicesProtocolGuid ## UNDEFINED > - gEfiExtendedSalCacheServicesProtocolGuid ## UNDEFINED > - gEfiExtendedSalMcaLogServicesProtocolGuid ## UNDEFINED > gEfiSecurity2ArchProtocolGuid ## UNDEFINED > gEfiSmmEndOfDxeProtocolGuid ## UNDEFINED > gEfiIsaHcProtocolGuid ## UNDEFINED > diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.u= ni > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > index 15a270620f..9c8028d0d5 100644 > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > @@ -268,23 +268,6 @@ > #string STR_FVB2 #language en-US "FirmwareVolumeBlock2" > #string STR_CPUIO2 #language en-US "CpuIo2" > #string STR_LEGACY_R2 #language en-US "LegacyRegion2" > -#string STR_SAL_MIP #language en-US "SalMcaInitPmi" > -#string STR_ES_BS #language en-US "ExtendedSalBootServic= e" > -#string STR_ES_BIO #language en-US "ExtendedSalBaseIoServ= ices" > -#string STR_ES_STALL #language en-US "ExtendedSalStallServi= ces" > -#string STR_ES_RTC #language en-US "ExtendedSalRtcService= s" > -#string STR_ES_VS #language en-US "ExtendedSalVariableSe= rvices" > -#string STR_ES_MTC #language en-US "ExtendedSalMtcService= s" > -#string STR_ES_RESET #language en-US "ExtendedSalResetServi= ces" > -#string STR_ES_SC #language en-US > "ExtendedSalStatusCodeServices" > -#string STR_ES_FBS #language en-US "ExtendedSalFvBlockSer= vices" > -#string STR_ES_MP #language en-US "ExtendedSalMpServices= " > -#string STR_ES_PAL #language en-US "ExtendedSalPalService= s" > -#string STR_ES_BASE #language en-US "ExtendedSalBaseServic= es" > -#string STR_ES_MCA #language en-US "ExtendedSalMcaService= s" > -#string STR_ES_PCI #language en-US "ExtendedSalPciService= s" > -#string STR_ES_CACHE #language en-US "ExtendedSalCacheServi= ces" > -#string STR_ES_MCA_LOG #language en-US > "ExtendedSalMcaLogServices" > #string STR_S2ARCH #language en-US "Security2Arch" > #string STR_EODXE #language en-US "SmmEndOfDxe" > #string STR_ISAHC #language en-US "IsaHc" > -- > 2.18.0.windows.1