Re: [edk2-devel] [PATCH] EmulatorPkg: Remove framework pkgs dependency from EmulatorPkg

["Ni, Ray" <ray.ni@intel.com>]

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Zhiguang Liu
> Sent: Monday, April 29, 2019 2:41 PM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> <afish@apple.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [edk2-devel] [PATCH] EmulatorPkg: Remove framework pkgs
> dependency from EmulatorPkg
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1721
> 
> Remove two inf files form EmulatorPkg.
> 
> About
> IntelFrameworkModulePkg/Universal/StatusCode/Pei/StatusCodePei.inf,
> this inf file is not included in the EmulaotrPkg.fdf, which means the
> StatusCodePei.inf does't work at all, so it is ok to remove it from EmulatorPkg.
> 
> About IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBusDxe.inf,
> in the inf file, we can see it consumes gEfiIdeControllerInitProtocolGuid.
> there are only two inf files in the edk project that produce this Protocol, as
> belows:
>     PcAtChipsetPkg\Bus\Pci\IdeControllerDxe\IdeControllerDxe.inf
>     MdeModulePkg\Bus\Pci\SataControllerDxe\SataControllerDxe.inf
> However, neither of them is included in the EmulatorPkg.dsc.
> It means the IdeBusDxe.inf can't work at all, so it is ok to remove it from
> EmulatorPkg.
> 
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> 
> Cc: Andrew Fish <afish@apple.com>
> 
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  EmulatorPkg/EmulatorPkg.dsc | 2 --
>  EmulatorPkg/EmulatorPkg.fdf | 1 -
>  2 files changed, 3 deletions(-)
> 
> diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
> index 7023de9ba2..de20f81046 100644
> --- a/EmulatorPkg/EmulatorPkg.dsc
> +++ b/EmulatorPkg/EmulatorPkg.dsc
> @@ -261,7 +261,6 @@
> 
> MdeModulePkg/Universal/ReportStatusCodeRouter/Pei/ReportStatusCode
> RouterPei.inf
> 
> MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.in
> f
> 
> -  IntelFrameworkModulePkg/Universal/StatusCode/Pei/StatusCodePei.inf
>    EmulatorPkg/BootModePei/BootModePei.inf
> 
> MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.inf
>    MdeModulePkg/Universal/Variable/Pei/VariablePei.inf
> @@ -349,7 +348,6 @@
>    MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
>    MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
>    MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
> -  IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBusDxe.inf
> 
>    EmulatorPkg/EmuBusDriverDxe/EmuBusDriverDxe.inf
>    EmulatorPkg/EmuGopDxe/EmuGopDxe.inf
> diff --git a/EmulatorPkg/EmulatorPkg.fdf b/EmulatorPkg/EmulatorPkg.fdf
> index 85197a14ca..1f02a4fb5a 100644
> --- a/EmulatorPkg/EmulatorPkg.fdf
> +++ b/EmulatorPkg/EmulatorPkg.fdf
> @@ -164,7 +164,6 @@ INF
> MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
>  INF  MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
>  INF  MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
>  INF  MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
> -INF  IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBusDxe.inf
>  INF  MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf
> 
>  INF  EmulatorPkg/EmuBusDriverDxe/EmuBusDriverDxe.inf
> --
> 2.21.0.windows.1
> 
> 
>