From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: ray.ni@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Sat, 04 May 2019 20:17:04 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 May 2019 20:17:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,431,1549958400"; d="scan'208";a="297116744" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 04 May 2019 20:17:03 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sat, 4 May 2019 20:17:03 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sat, 4 May 2019 20:17:03 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.129]) with mapi id 14.03.0415.000; Sun, 5 May 2019 11:17:01 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Liu, Zhiguang" CC: "Justen, Jordan L" , Andrew Fish Subject: Re: [edk2-devel] [PATCH] EmulatorPkg: Remove framework pkgs dependency from EmulatorPkg Thread-Topic: [edk2-devel] [PATCH] EmulatorPkg: Remove framework pkgs dependency from EmulatorPkg Thread-Index: AQHU/lakEDp2ZHFqAUa8YoECXauJqaZb5R1w Date: Sun, 5 May 2019 03:12:51 +0000 Deferred-Delivery: Sun, 5 May 2019 03:17:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C125E51@SHSMSX104.ccr.corp.intel.com> References: <20190429064114.20140-1-zhiguang.liu@intel.com> In-Reply-To: <20190429064114.20140-1-zhiguang.liu@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Zhiguang Liu > Sent: Monday, April 29, 2019 2:41 PM > To: devel@edk2.groups.io > Cc: Justen, Jordan L ; Andrew Fish > ; Ni, Ray > Subject: [edk2-devel] [PATCH] EmulatorPkg: Remove framework pkgs > dependency from EmulatorPkg >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1721 >=20 > Remove two inf files form EmulatorPkg. >=20 > About > IntelFrameworkModulePkg/Universal/StatusCode/Pei/StatusCodePei.inf, > this inf file is not included in the EmulaotrPkg.fdf, which means the > StatusCodePei.inf does't work at all, so it is ok to remove it from Emul= atorPkg. >=20 > About IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBusDxe.inf, > in the inf file, we can see it consumes gEfiIdeControllerInitProtocolGui= d. > there are only two inf files in the edk project that produce this Protoc= ol, as > belows: > PcAtChipsetPkg\Bus\Pci\IdeControllerDxe\IdeControllerDxe.inf > MdeModulePkg\Bus\Pci\SataControllerDxe\SataControllerDxe.inf > However, neither of them is included in the EmulatorPkg.dsc. > It means the IdeBusDxe.inf can't work at all, so it is ok to remove it f= rom > EmulatorPkg. >=20 > Signed-off-by: Zhiguang Liu >=20 > Cc: Jordan Justen >=20 > Cc: Andrew Fish >=20 > Cc: Ray Ni > --- > EmulatorPkg/EmulatorPkg.dsc | 2 -- > EmulatorPkg/EmulatorPkg.fdf | 1 - > 2 files changed, 3 deletions(-) >=20 > diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc > index 7023de9ba2..de20f81046 100644 > --- a/EmulatorPkg/EmulatorPkg.dsc > +++ b/EmulatorPkg/EmulatorPkg.dsc > @@ -261,7 +261,6 @@ >=20 > MdeModulePkg/Universal/ReportStatusCodeRouter/Pei/ReportStatusCode > RouterPei.inf >=20 > MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.in > f >=20 > - IntelFrameworkModulePkg/Universal/StatusCode/Pei/StatusCodePei.inf > EmulatorPkg/BootModePei/BootModePei.inf >=20 > MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.inf > MdeModulePkg/Universal/Variable/Pei/VariablePei.inf > @@ -349,7 +348,6 @@ > MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > - IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBusDxe.inf >=20 > EmulatorPkg/EmuBusDriverDxe/EmuBusDriverDxe.inf > EmulatorPkg/EmuGopDxe/EmuGopDxe.inf > diff --git a/EmulatorPkg/EmulatorPkg.fdf b/EmulatorPkg/EmulatorPkg.fdf > index 85197a14ca..1f02a4fb5a 100644 > --- a/EmulatorPkg/EmulatorPkg.fdf > +++ b/EmulatorPkg/EmulatorPkg.fdf > @@ -164,7 +164,6 @@ INF > MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf > INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf > INF MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > -INF IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBusDxe.inf > INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf >=20 > INF EmulatorPkg/EmuBusDriverDxe/EmuBusDriverDxe.inf > -- > 2.21.0.windows.1 >=20 >=20 >=20