public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "Liu, Zhiguang" <zhiguang.liu@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Justen, Jordan L" <jordan.l.justen@intel.com>,
	Andrew Fish <afish@apple.com>
Subject: Re: [PATCH] EmulatorPkg: Change the cpu current speed from 0 to a non-zero value
Date: Sun, 5 May 2019 03:25:05 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C125FFD@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190429022333.22740-1-zhiguang.liu@intel.com>

Please add comments above the CurrentSpeed assignment to
explain the 1234 is a fake value for CPU frequency.

> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu@intel.com>
> Sent: Monday, April 29, 2019 10:24 AM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> <afish@apple.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH] EmulatorPkg: Change the cpu current speed from 0 to a
> non-zero value
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1686
> 
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  EmulatorPkg/CpuRuntimeDxe/Cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/EmulatorPkg/CpuRuntimeDxe/Cpu.c
> b/EmulatorPkg/CpuRuntimeDxe/Cpu.c index e997b39f41..3093a7b642
> 100644
> --- a/EmulatorPkg/CpuRuntimeDxe/Cpu.c
> +++ b/EmulatorPkg/CpuRuntimeDxe/Cpu.c
> @@ -238,7 +238,7 @@ CpuUpdateSmbios (
>    mCpuSmbiosType4.CoreCount        = (UINT8) MaxCpus;
>    mCpuSmbiosType4.EnabledCoreCount = (UINT8) MaxCpus;
>    mCpuSmbiosType4.ThreadCount      = (UINT8) MaxCpus;
> -
> +  mCpuSmbiosType4.CurrentSpeed = 1234;
>    LogSmbiosData ((EFI_SMBIOS_TABLE_HEADER *)&mCpuSmbiosType4,
> mCpuSmbiosType4Strings);  }
> 
> --
> 2.21.0.windows.1


      reply	other threads:[~2019-05-05  3:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-29  2:23 [PATCH] EmulatorPkg: Change the cpu current speed from 0 to a non-zero value zhiguang.liu
2019-05-05  3:25 ` Ni, Ray [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C125FFD@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox