From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: ray.ni@intel.com)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by groups.io with SMTP; Sat, 04 May 2019 20:25:08 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
  by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 May 2019 20:25:08 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,431,1549958400"; 
   d="scan'208";a="167905556"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
  by fmsmga004.fm.intel.com with ESMTP; 04 May 2019 20:25:08 -0700
Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Sat, 4 May 2019 20:25:07 -0700
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
 FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Sat, 4 May 2019 20:25:07 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.70]) with mapi id 14.03.0415.000;
 Sun, 5 May 2019 11:25:05 +0800
From: "Ni, Ray" <ray.ni@intel.com>
To: "Liu, Zhiguang" <zhiguang.liu@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Justen, Jordan L" <jordan.l.justen@intel.com>, Andrew Fish
	<afish@apple.com>
Subject: Re: [PATCH] EmulatorPkg: Change the cpu current speed from 0 to a non-zero value
Thread-Topic: [PATCH] EmulatorPkg: Change the cpu current speed from 0 to a
 non-zero value
Thread-Index: AQHU/jKlIjKQHkOug0iiNMssR3xjqKZb6IvA
Date: Sun, 5 May 2019 03:25:05 +0000
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C125FFD@SHSMSX104.ccr.corp.intel.com>
References: <20190429022333.22740-1-zhiguang.liu@intel.com>
In-Reply-To: <20190429022333.22740-1-zhiguang.liu@intel.com>
Accept-Language: en-US, zh-CN
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: ray.ni@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Please add comments above the CurrentSpeed assignment to
explain the 1234 is a fake value for CPU frequency.

> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu@intel.com>
> Sent: Monday, April 29, 2019 10:24 AM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> <afish@apple.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH] EmulatorPkg: Change the cpu current speed from 0 to a
> non-zero value
>=20
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1686
>=20
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  EmulatorPkg/CpuRuntimeDxe/Cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/EmulatorPkg/CpuRuntimeDxe/Cpu.c
> b/EmulatorPkg/CpuRuntimeDxe/Cpu.c index e997b39f41..3093a7b642
> 100644
> --- a/EmulatorPkg/CpuRuntimeDxe/Cpu.c
> +++ b/EmulatorPkg/CpuRuntimeDxe/Cpu.c
> @@ -238,7 +238,7 @@ CpuUpdateSmbios (
>    mCpuSmbiosType4.CoreCount        =3D (UINT8) MaxCpus;
>    mCpuSmbiosType4.EnabledCoreCount =3D (UINT8) MaxCpus;
>    mCpuSmbiosType4.ThreadCount      =3D (UINT8) MaxCpus;
> -
> +  mCpuSmbiosType4.CurrentSpeed =3D 1234;
>    LogSmbiosData ((EFI_SMBIOS_TABLE_HEADER *)&mCpuSmbiosType4,
> mCpuSmbiosType4Strings);  }
>=20
> --
> 2.21.0.windows.1