Re: [edk2-devel] [patch 02/11] FatPkg/FatPei: Remove PcdFrameworkCompatibilitySupport usage

["Ni, Ray" <ray.ni@intel.com>]

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Dandan
> Bi
> Sent: Monday, April 29, 2019 10:16 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>
> Subject: [edk2-devel] [patch 02/11] FatPkg/FatPei: Remove
> PcdFrameworkCompatibilitySupport usage
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1464
> 
> Currently Framework compatibility is not needed and
> PcdFrameworkCompatibilitySupport will be removed from edk2.
> So remove the usage of this PCD firstly.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  FatPkg/FatPei/FatLiteApi.c | 10 +---------
>  FatPkg/FatPei/FatPei.inf   |  4 ----
>  2 files changed, 1 insertion(+), 13 deletions(-)
> 
> diff --git a/FatPkg/FatPei/FatLiteApi.c b/FatPkg/FatPei/FatLiteApi.c index
> 0bf6ddae6a..b9f883b9e0 100644
> --- a/FatPkg/FatPei/FatLiteApi.c
> +++ b/FatPkg/FatPei/FatLiteApi.c
> @@ -1,9 +1,9 @@
>  /** @file
>    FAT recovery PEIM entry point, Ppi Functions and FAT Api functions.
> 
> -Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
> 
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  **/
> 
> @@ -429,14 +429,10 @@ GetRecoveryCapsuleInfo (
> 
>    if (EFI_ERROR (Status)) {
>      return Status;
>    }
> 
> -  if (FeaturePcdGet (PcdFrameworkCompatibilitySupport)) {
> -    CapsuleInstance = CapsuleInstance + 1;
> -  }
> -
>    if ((CapsuleInstance == 0) || (CapsuleInstance > NumberRecoveryCapsules))
> {
>      return EFI_NOT_FOUND;
>    }
> 
>    PrivateData = PEI_FAT_PRIVATE_DATA_FROM_THIS (This); @@ -557,14
> +553,10 @@ LoadRecoveryCapsule (
> 
>    if (EFI_ERROR (Status)) {
>      return Status;
>    }
> 
> -  if (FeaturePcdGet (PcdFrameworkCompatibilitySupport)) {
> -    CapsuleInstance = CapsuleInstance + 1;
> -  }
> -
>    if ((CapsuleInstance == 0) || (CapsuleInstance > NumberRecoveryCapsules))
> {
>      return EFI_NOT_FOUND;
>    }
> 
>    PrivateData = PEI_FAT_PRIVATE_DATA_FROM_THIS (This); diff --git
> a/FatPkg/FatPei/FatPei.inf b/FatPkg/FatPei/FatPei.inf index
> b554aae040..d3466db9bf 100644
> --- a/FatPkg/FatPei/FatPei.inf
> +++ b/FatPkg/FatPei/FatPei.inf
> @@ -63,14 +63,10 @@
>  [Ppis]
>    gEfiPeiVirtualBlockIoPpiGuid                  ## SOMETIMES_CONSUMES
> PPI_NOTIFY
>    gEfiPeiVirtualBlockIo2PpiGuid                 ## SOMETIMES_CONSUMES
> PPI_NOTIFY
>    gEfiPeiDeviceRecoveryModulePpiGuid            ## SOMETIMES_PRODUCES
> 
> -
> -[FeaturePcd]
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdFrameworkCompatibilitySupport
> ## CONSUMES
> -
>  [Pcd]
>    gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryFileName         ##
> CONSUMES
> 
>  [Depex]
>    gEfiPeiMemoryDiscoveredPpiGuid AND
> gEfiPeiBootInRecoveryModePpiGuid
> --
> 2.18.0.windows.1
> 
> 
>