From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: ray.ni@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Sat, 04 May 2019 20:29:03 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 May 2019 20:29:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,431,1549958400"; d="scan'208";a="167906179" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 04 May 2019 20:29:03 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sat, 4 May 2019 20:29:03 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sat, 4 May 2019 20:29:02 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by shsmsx102.ccr.corp.intel.com ([169.254.2.249]) with mapi id 14.03.0415.000; Sun, 5 May 2019 11:29:01 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Bi, Dandan" Subject: Re: [edk2-devel] [patch 02/11] FatPkg/FatPei: Remove PcdFrameworkCompatibilitySupport usage Thread-Topic: [edk2-devel] [patch 02/11] FatPkg/FatPei: Remove PcdFrameworkCompatibilitySupport usage Thread-Index: AQHU/jGTcX7vJGrxhkWPru9ttvlQaaZb6Oqw Date: Sun, 5 May 2019 03:25:24 +0000 Deferred-Delivery: Sun, 5 May 2019 03:29:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C12602C@SHSMSX104.ccr.corp.intel.com> References: <20190429021607.11304-1-dandan.bi@intel.com> <20190429021607.11304-3-dandan.bi@intel.com> In-Reply-To: <20190429021607.11304-3-dandan.bi@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Dandan > Bi > Sent: Monday, April 29, 2019 10:16 AM > To: devel@edk2.groups.io > Cc: Ni, Ray > Subject: [edk2-devel] [patch 02/11] FatPkg/FatPei: Remove > PcdFrameworkCompatibilitySupport usage >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1464 >=20 > Currently Framework compatibility is not needed and > PcdFrameworkCompatibilitySupport will be removed from edk2. > So remove the usage of this PCD firstly. >=20 > Cc: Ray Ni > Signed-off-by: Dandan Bi > --- > FatPkg/FatPei/FatLiteApi.c | 10 +--------- > FatPkg/FatPei/FatPei.inf | 4 ---- > 2 files changed, 1 insertion(+), 13 deletions(-) >=20 > diff --git a/FatPkg/FatPei/FatLiteApi.c b/FatPkg/FatPei/FatLiteApi.c ind= ex > 0bf6ddae6a..b9f883b9e0 100644 > --- a/FatPkg/FatPei/FatLiteApi.c > +++ b/FatPkg/FatPei/FatLiteApi.c > @@ -1,9 +1,9 @@ > /** @file > FAT recovery PEIM entry point, Ppi Functions and FAT Api functions. >=20 > -Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ >=20 > @@ -429,14 +429,10 @@ GetRecoveryCapsuleInfo ( >=20 > if (EFI_ERROR (Status)) { > return Status; > } >=20 > - if (FeaturePcdGet (PcdFrameworkCompatibilitySupport)) { > - CapsuleInstance =3D CapsuleInstance + 1; > - } > - > if ((CapsuleInstance =3D=3D 0) || (CapsuleInstance > NumberRecoveryCa= psules)) > { > return EFI_NOT_FOUND; > } >=20 > PrivateData =3D PEI_FAT_PRIVATE_DATA_FROM_THIS (This); @@ -557,14 > +553,10 @@ LoadRecoveryCapsule ( >=20 > if (EFI_ERROR (Status)) { > return Status; > } >=20 > - if (FeaturePcdGet (PcdFrameworkCompatibilitySupport)) { > - CapsuleInstance =3D CapsuleInstance + 1; > - } > - > if ((CapsuleInstance =3D=3D 0) || (CapsuleInstance > NumberRecoveryCa= psules)) > { > return EFI_NOT_FOUND; > } >=20 > PrivateData =3D PEI_FAT_PRIVATE_DATA_FROM_THIS (This); diff --git > a/FatPkg/FatPei/FatPei.inf b/FatPkg/FatPei/FatPei.inf index > b554aae040..d3466db9bf 100644 > --- a/FatPkg/FatPei/FatPei.inf > +++ b/FatPkg/FatPei/FatPei.inf > @@ -63,14 +63,10 @@ > [Ppis] > gEfiPeiVirtualBlockIoPpiGuid ## SOMETIMES_CONSUMES > PPI_NOTIFY > gEfiPeiVirtualBlockIo2PpiGuid ## SOMETIMES_CONSUMES > PPI_NOTIFY > gEfiPeiDeviceRecoveryModulePpiGuid ## SOMETIMES_PRODUCES >=20 > - > -[FeaturePcd] > - gEfiMdeModulePkgTokenSpaceGuid.PcdFrameworkCompatibilitySupport > ## CONSUMES > - > [Pcd] > gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryFileName ## > CONSUMES >=20 > [Depex] > gEfiPeiMemoryDiscoveredPpiGuid AND > gEfiPeiBootInRecoveryModePpiGuid > -- > 2.18.0.windows.1 >=20 >=20 >=20