From: "Ni, Ray" <ray.ni@intel.com>
To: "Liu, Zhiguang" <zhiguang.liu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Justen, Jordan L" <jordan.l.justen@intel.com>,
Andrew Fish <afish@apple.com>
Subject: Re: [Patch V2 1/2] EmulatorPkg: Save the modified order after rebooting
Date: Mon, 6 May 2019 02:37:06 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C12AC96@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190506020618.12032-2-zhiguang.liu@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Liu, Zhiguang
> Sent: Monday, May 6, 2019 10:06 AM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> <afish@apple.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [Patch V2 1/2] EmulatorPkg: Save the modified order after rebooting
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1650
>
> v2:
> Abandon v1, and avoid using memory mapped FV device path by adding
> FvNameGuid to EmulatorPkg.fdf file.
>
> v1:
> The reason why boot order changed is that everytime Emulator restarts, the
> memory mapped address will change.
> This patch correct the device path to the right one.
>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
> EmulatorPkg/EmulatorPkg.fdf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/EmulatorPkg/EmulatorPkg.fdf b/EmulatorPkg/EmulatorPkg.fdf
> index 85197a14ca..c5c69f8a84 100644
> --- a/EmulatorPkg/EmulatorPkg.fdf
> +++ b/EmulatorPkg/EmulatorPkg.fdf
> @@ -80,6 +80,7 @@ DATA = {
>
> gEmulatorPkgTokenSpaceGuid.PcdEmuFlashNvStorageFtwSpareBase|gEfiMd
> eModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize
>
> [FV.FvRecovery]
> +FvNameGuid = 6D99E806-3D38-42c2-A095-5F4300BFD7DC
> FvAlignment = 16 #FV alignment and FV attributes setting.
> ERASE_POLARITY = 1
> MEMORY_MAPPED = TRUE
> --
> 2.21.0.windows.1
next prev parent reply other threads:[~2019-05-06 2:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 2:06 [Patch V2 0/2] EmulatorPkg: fix boot order bugs Zhiguang Liu
2019-05-06 2:06 ` [Patch V2 1/2] EmulatorPkg: Save the modified order after rebooting Zhiguang Liu
2019-05-06 2:37 ` Ni, Ray [this message]
2019-05-06 2:06 ` [Patch V2 2/2] EmulatorPkg: Make the shell be the first boot option Zhiguang Liu
2019-05-06 2:38 ` Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C12AC96@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox