From: "Ni, Ray" <ray.ni@intel.com>
To: "Liu, Zhiguang" <zhiguang.liu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Justen, Jordan L" <jordan.l.justen@intel.com>,
Andrew Fish <afish@apple.com>
Subject: Re: [Patch V2 2/2] EmulatorPkg: Make the shell be the first boot option
Date: Mon, 6 May 2019 02:38:37 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C12AD22@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190506020618.12032-3-zhiguang.liu@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Liu, Zhiguang
> Sent: Monday, May 6, 2019 10:06 AM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> <afish@apple.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [Patch V2 2/2] EmulatorPkg: Make the shell be the first boot option
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1649
>
> Make the shell be the first boot option by default, So it can boot into UEFI
> Internal Shell directly
>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
> EmulatorPkg/Library/PlatformBmLib/PlatformBm.c | 30
> ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/EmulatorPkg/Library/PlatformBmLib/PlatformBm.c
> b/EmulatorPkg/Library/PlatformBmLib/PlatformBm.c
> index 191ce58cfb..03f6157ae8 100644
> --- a/EmulatorPkg/Library/PlatformBmLib/PlatformBm.c
> +++ b/EmulatorPkg/Library/PlatformBmLib/PlatformBm.c
> @@ -332,6 +332,35 @@ PlatformBdsRegisterStaticBootOptions (
> PrintXY (10, 50, &White, &Black, L"Enter to boot directly."); }
>
> +/**
> + Returns the priority number.
> +
> + @param BootOption
> +**/
> +UINTN
> +BootOptionPriority (
> + CONST EFI_BOOT_MANAGER_LOAD_OPTION *BootOption
> + )
> +{
> + //
> + // Make sure Shell is first
> + //
> + if (StrCmp (BootOption->Description, L"UEFI Shell") == 0) {
> + return 0;
> + }
> + return 100;
> +}
> +
> +INTN
> +EFIAPI
> +CompareBootOption (
> + CONST EFI_BOOT_MANAGER_LOAD_OPTION *Left,
> + CONST EFI_BOOT_MANAGER_LOAD_OPTION *Right
> + )
> +{
> + return BootOptionPriority (Left) - BootOptionPriority (Right); }
> +
> /**
> Do the platform specific action after the console is connected.
>
> @@ -377,6 +406,7 @@ PlatformBootManagerAfterConsole (
> PlatformBdsRegisterStaticBootOptions ();
> PlatformBdsConnectSequence ();
> EfiBootManagerRefreshAllBootOption ();
> + EfiBootManagerSortLoadOptionVariable (LoadOptionTypeBoot,
> + (SORT_COMPARE)CompareBootOption);
> break;
> }
> }
> --
> 2.21.0.windows.1
prev parent reply other threads:[~2019-05-06 2:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 2:06 [Patch V2 0/2] EmulatorPkg: fix boot order bugs Zhiguang Liu
2019-05-06 2:06 ` [Patch V2 1/2] EmulatorPkg: Save the modified order after rebooting Zhiguang Liu
2019-05-06 2:37 ` Ni, Ray
2019-05-06 2:06 ` [Patch V2 2/2] EmulatorPkg: Make the shell be the first boot option Zhiguang Liu
2019-05-06 2:38 ` Ni, Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C12AD22@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox