From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ray.ni@intel.com)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by groups.io with SMTP; Fri, 10 May 2019 03:13:04 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
  by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2019 03:13:03 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,453,1549958400"; 
   d="scan'208";a="170276009"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
  by fmsmga002.fm.intel.com with ESMTP; 10 May 2019 03:13:03 -0700
Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Fri, 10 May 2019 03:13:02 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by
 SHSMSX106.ccr.corp.intel.com ([169.254.10.213]) with mapi id 14.03.0415.000;
 Fri, 10 May 2019 18:13:01 +0800
From: "Ni, Ray" <ray.ni@intel.com>
To: 'Joe Richey' <joerichey@google.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Dong, Eric" <eric.dong@intel.com>, Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH 2/3] UefiCpuPkg: Remove double \r
Thread-Topic: [PATCH 2/3] UefiCpuPkg: Remove double \r
Thread-Index: AQHVBwdzEMqlI+++RUeYz9oTe6Nh2aZkI5Fg
Date: Fri, 10 May 2019 10:12:04 +0000
Deferred-Delivery: Fri, 10 May 2019 10:13:00 +0000
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C139278@SHSMSX104.ccr.corp.intel.com>
References: <20190510080657.252121-1-joerichey@google.com>
In-Reply-To: <20190510080657.252121-1-joerichey@google.com>
Accept-Language: en-US, zh-CN
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: ray.ni@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Joe Richey <joerichey@google.com>
> Sent: Friday, May 10, 2019 4:07 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo
> Ersek <lersek@redhat.com>; Joe Richey <joerichey@google.com>
> Subject: [PATCH 2/3] UefiCpuPkg: Remove double \r
>=20
> These files have \r\n line endings, but a few lines use \r\r\n which
> is not a valid line ending. These lines were causing problems for git
> and other tools.
>=20
> Signed-off-by: Joe Richey <joerichey@google.com>
> ---
>  UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
> b/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
> index 32cd63ede0..906ed65408 100644
> --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
> +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
> @@ -68,7 +68,7 @@ LimitCpuidMaxvalInitialize (
>    // The scope of LimitCpuidMaxval bit in the MSR_IA32_MISC_ENABLE is
> core for below
>    // processor type, only program MSR_IA32_MISC_ENABLE for thread 0 in
> each core.
>    //
> -  if (IS_PENTIUM_4_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo-
> >DisplayModel) ||
>=20
> +  if (IS_PENTIUM_4_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo-
> >DisplayModel) ||
>        IS_SILVERMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo-
> >DisplayModel) ||
>        IS_GOLDMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo-
> >DisplayModel) ||
>        IS_CORE_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel)
> ||
> --
> 2.21.0.1020.gf2820cf01a-goog