public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"'lersek@redhat.com'" <lersek@redhat.com>
Cc: "Gao, Liming" <liming.gao@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Cetola, Stephano" <stephano.cetola@intel.com>,
	Andrew Fish <afish@apple.com>,
	Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [edk2-devel] [edk2] Soft Feature Freeze starts today for edk2-stable201905
Date: Wed, 22 May 2019 08:28:55 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C1580D1@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <a9aa2c5f-ec6c-6d0b-208c-8038e2e85915@redhat.com>

> > 110d4729b58e EmulatorPkg: Add NetworkPkg/NetworkPkg.dec as the
> package
> > dependency
> 
> Invalid, same as commit 911efe279ec3 above.
> 
> ... No, wait, this is worse: this patch had not received *any* review feedback
> on the list:
> 
>   http://mid.mail-archive.com/20190520130920.9464-3-liming.gao@intel.com
> 
> but it was committed with Ray's R-b. I don't understand.
> 

Laszlo,
The "R-b" thing is my fault. When Liming reminded me to review the patch, I replied "directly"
to Liming's mail but forgot to add "devel@edk2.groups.io" to the CC address line.
And I just noticed that when I saw Liming forwarded my reply mail out to the public.

Maybe we need to set edk2 repo read-only to ordinary developers after soft-freeze starts.
Only stewards have the rights to push the changes.

But I am not sure whether github supports this feature.

Or maybe we could create a branch when soft-freeze starts, and every push on the master
will be audited and cherry-picked by stewards. On the date of release, the master branch
will be discarded and the branch created before becomes master.

Thanks,
Ray



  parent reply	other threads:[~2019-05-22  8:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17  8:56 [edk2] Soft Feature Freeze starts today for edk2-stable201905 Liming Gao
2019-05-21 21:01 ` [edk2-devel] " Laszlo Ersek
2019-05-21 21:05   ` Laszlo Ersek
2019-05-22  8:28   ` Ni, Ray [this message]
2019-05-22  8:53     ` Laszlo Ersek
2019-05-22 12:09   ` Liming Gao
2019-05-22 13:04     ` Laszlo Ersek
2019-05-23  5:58       ` Liming Gao
2019-05-23 11:44         ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C1580D1@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox