* [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system
@ 2019-05-27 10:23 Javeed, Ashraf
2019-05-28 2:15 ` Ni, Ray
2019-06-17 9:49 ` Ni, Ray
0 siblings, 2 replies; 6+ messages in thread
From: Javeed, Ashraf @ 2019-05-27 10:23 UTC (permalink / raw)
To: devel; +Cc: Ashraf Javeed, Jian J Wang, Ray Ni
https://bugzilla.tianocore.org/show_bug.cgi?id=1796
Bug fixed in PciBusDxe\PciLib.c.
Removed the redundant second call to PciSearchDevice sub-routine when the
PCD for the Hot-Plug support is disabled.
Signed-off-by: Ashraf Javeed <Ashraf.javeed@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
index f0d9f45c4a..5b55fb5d3b 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
@@ -1114,24 +1114,7 @@ PciScanBus (
//
// For PPB
//
- if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
- //
- // If Hot Plug is not supported,
- // get the bridge information
- //
- Status = PciSearchDevice (
- Bridge,
- &Pci,
- StartBusNumber,
- Device,
- Func,
- &PciDevice
- );
-
- if (EFI_ERROR (Status)) {
- return Status;
- }
- } else {
+ if (FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
//
// If Hot Plug is supported,
// Get the bridge information
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system
2019-05-27 10:23 [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system Javeed, Ashraf
@ 2019-05-28 2:15 ` Ni, Ray
2019-06-17 9:49 ` Ni, Ray
1 sibling, 0 replies; 6+ messages in thread
From: Ni, Ray @ 2019-05-28 2:15 UTC (permalink / raw)
To: Javeed, Ashraf, devel@edk2.groups.io; +Cc: Wang, Jian J
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Javeed, Ashraf
> Sent: Monday, May 27, 2019 6:24 PM
> To: devel@edk2.groups.io
> Cc: Javeed, Ashraf <ashraf.javeed@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH] PciBusDxe: duplicate node insertion for every PPB device in
> the system
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=1796
> Bug fixed in PciBusDxe\PciLib.c.
> Removed the redundant second call to PciSearchDevice sub-routine when
> the PCD for the Hot-Plug support is disabled.
>
> Signed-off-by: Ashraf Javeed <Ashraf.javeed@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
> MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------
> 1 file changed, 1 insertion(+), 18 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> index f0d9f45c4a..5b55fb5d3b 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> @@ -1114,24 +1114,7 @@ PciScanBus (
> //
> // For PPB
> //
> - if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> - //
> - // If Hot Plug is not supported,
> - // get the bridge information
> - //
> - Status = PciSearchDevice (
> - Bridge,
> - &Pci,
> - StartBusNumber,
> - Device,
> - Func,
> - &PciDevice
> - );
> -
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
> - } else {
> + if (FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> //
> // If Hot Plug is supported,
> // Get the bridge information
> --
> 2.21.0.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system
2019-05-27 10:23 [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system Javeed, Ashraf
2019-05-28 2:15 ` Ni, Ray
@ 2019-06-17 9:49 ` Ni, Ray
2019-06-18 2:24 ` [edk2-devel] " Wu, Hao A
1 sibling, 1 reply; 6+ messages in thread
From: Ni, Ray @ 2019-06-17 9:49 UTC (permalink / raw)
To: Javeed, Ashraf, devel@edk2.groups.io; +Cc: Wang, Jian J
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Javeed, Ashraf
> Sent: Monday, May 27, 2019 6:24 PM
> To: devel@edk2.groups.io
> Cc: Javeed, Ashraf <ashraf.javeed@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH] PciBusDxe: duplicate node insertion for every PPB device in
> the system
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=1796
> Bug fixed in PciBusDxe\PciLib.c.
> Removed the redundant second call to PciSearchDevice sub-routine when
> the PCD for the Hot-Plug support is disabled.
>
> Signed-off-by: Ashraf Javeed <Ashraf.javeed@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
> MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------
> 1 file changed, 1 insertion(+), 18 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> index f0d9f45c4a..5b55fb5d3b 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> @@ -1114,24 +1114,7 @@ PciScanBus (
> //
> // For PPB
> //
> - if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> - //
> - // If Hot Plug is not supported,
> - // get the bridge information
> - //
> - Status = PciSearchDevice (
> - Bridge,
> - &Pci,
> - StartBusNumber,
> - Device,
> - Func,
> - &PciDevice
> - );
> -
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
> - } else {
> + if (FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> //
> // If Hot Plug is supported,
> // Get the bridge information
> --
> 2.21.0.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system
2019-06-17 9:49 ` Ni, Ray
@ 2019-06-18 2:24 ` Wu, Hao A
2019-06-18 2:27 ` Wu, Hao A
0 siblings, 1 reply; 6+ messages in thread
From: Wu, Hao A @ 2019-06-18 2:24 UTC (permalink / raw)
To: devel@edk2.groups.io, Ni, Ray, Javeed, Ashraf; +Cc: Wang, Jian J
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni,
> Ray
> Sent: Monday, June 17, 2019 5:49 PM
> To: Javeed, Ashraf; devel@edk2.groups.io
> Cc: Wang, Jian J
> Subject: Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for
> every PPB device in the system
>
> Reviewed-by: Ray Ni <ray.ni@intel.com>
Hello all,
I did not see the origin patch being sent to the mailing list.
Maybe Ashraf has not subscribed the mailing list?
Best Regards,
Hao Wu
>
> > -----Original Message-----
> > From: Javeed, Ashraf
> > Sent: Monday, May 27, 2019 6:24 PM
> > To: devel@edk2.groups.io
> > Cc: Javeed, Ashraf <ashraf.javeed@intel.com>; Wang, Jian J
> > <jian.j.wang@intel.com>; Ni, Ray <ray.ni@intel.com>
> > Subject: [PATCH] PciBusDxe: duplicate node insertion for every PPB device
> in
> > the system
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1796
> > Bug fixed in PciBusDxe\PciLib.c.
> > Removed the redundant second call to PciSearchDevice sub-routine when
> > the PCD for the Hot-Plug support is disabled.
> >
> > Signed-off-by: Ashraf Javeed <Ashraf.javeed@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > ---
> > MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------
> > 1 file changed, 1 insertion(+), 18 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > index f0d9f45c4a..5b55fb5d3b 100644
> > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > @@ -1114,24 +1114,7 @@ PciScanBus (
> > //
> > // For PPB
> > //
> > - if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> > - //
> > - // If Hot Plug is not supported,
> > - // get the bridge information
> > - //
> > - Status = PciSearchDevice (
> > - Bridge,
> > - &Pci,
> > - StartBusNumber,
> > - Device,
> > - Func,
> > - &PciDevice
> > - );
> > -
> > - if (EFI_ERROR (Status)) {
> > - return Status;
> > - }
> > - } else {
> > + if (FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> > //
> > // If Hot Plug is supported,
> > // Get the bridge information
> > --
> > 2.21.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system
2019-06-18 2:24 ` [edk2-devel] " Wu, Hao A
@ 2019-06-18 2:27 ` Wu, Hao A
2019-07-01 7:39 ` Wu, Hao A
0 siblings, 1 reply; 6+ messages in thread
From: Wu, Hao A @ 2019-06-18 2:27 UTC (permalink / raw)
To: devel@edk2.groups.io, Wu, Hao A, Ni, Ray, Javeed, Ashraf; +Cc: Wang, Jian J
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Tuesday, June 18, 2019 10:24 AM
> To: devel@edk2.groups.io; Ni, Ray; Javeed, Ashraf
> Cc: Wang, Jian J
> Subject: Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for
> every PPB device in the system
>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ni,
> > Ray
> > Sent: Monday, June 17, 2019 5:49 PM
> > To: Javeed, Ashraf; devel@edk2.groups.io
> > Cc: Wang, Jian J
> > Subject: Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for
> > every PPB device in the system
> >
> > Reviewed-by: Ray Ni <ray.ni@intel.com>
>
> Hello all,
>
> I did not see the origin patch being sent to the mailing list.
> Maybe Ashraf has not subscribed the mailing list?
Sorry, saw it at:
https://edk2.groups.io/g/devel/message/41418
Acked-by: Hao A Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
>
> Best Regards,
> Hao Wu
>
> >
> > > -----Original Message-----
> > > From: Javeed, Ashraf
> > > Sent: Monday, May 27, 2019 6:24 PM
> > > To: devel@edk2.groups.io
> > > Cc: Javeed, Ashraf <ashraf.javeed@intel.com>; Wang, Jian J
> > > <jian.j.wang@intel.com>; Ni, Ray <ray.ni@intel.com>
> > > Subject: [PATCH] PciBusDxe: duplicate node insertion for every PPB
> device
> > in
> > > the system
> > >
> > > https://bugzilla.tianocore.org/show_bug.cgi?id=1796
> > > Bug fixed in PciBusDxe\PciLib.c.
> > > Removed the redundant second call to PciSearchDevice sub-routine
> when
> > > the PCD for the Hot-Plug support is disabled.
> > >
> > > Signed-off-by: Ashraf Javeed <Ashraf.javeed@intel.com>
> > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > Cc: Ray Ni <ray.ni@intel.com>
> > > ---
> > > MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------
> > > 1 file changed, 1 insertion(+), 18 deletions(-)
> > >
> > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > > index f0d9f45c4a..5b55fb5d3b 100644
> > > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > > @@ -1114,24 +1114,7 @@ PciScanBus (
> > > //
> > > // For PPB
> > > //
> > > - if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> > > - //
> > > - // If Hot Plug is not supported,
> > > - // get the bridge information
> > > - //
> > > - Status = PciSearchDevice (
> > > - Bridge,
> > > - &Pci,
> > > - StartBusNumber,
> > > - Device,
> > > - Func,
> > > - &PciDevice
> > > - );
> > > -
> > > - if (EFI_ERROR (Status)) {
> > > - return Status;
> > > - }
> > > - } else {
> > > + if (FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> > > //
> > > // If Hot Plug is supported,
> > > // Get the bridge information
> > > --
> > > 2.21.0.windows.1
> >
> >
> >
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system
2019-06-18 2:27 ` Wu, Hao A
@ 2019-07-01 7:39 ` Wu, Hao A
0 siblings, 0 replies; 6+ messages in thread
From: Wu, Hao A @ 2019-07-01 7:39 UTC (permalink / raw)
To: devel@edk2.groups.io, Ni, Ray, Javeed, Ashraf; +Cc: Wang, Jian J
> -----Original Message-----
> From: Wu, Hao A
> Sent: Tuesday, June 18, 2019 10:28 AM
> To: devel@edk2.groups.io; Wu, Hao A; Ni, Ray; Javeed, Ashraf
> Cc: Wang, Jian J
> Subject: RE: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for
> every PPB device in the system
>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Wu, Hao A
> > Sent: Tuesday, June 18, 2019 10:24 AM
> > To: devel@edk2.groups.io; Ni, Ray; Javeed, Ashraf
> > Cc: Wang, Jian J
> > Subject: Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for
> > every PPB device in the system
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> Of
> > Ni,
> > > Ray
> > > Sent: Monday, June 17, 2019 5:49 PM
> > > To: Javeed, Ashraf; devel@edk2.groups.io
> > > Cc: Wang, Jian J
> > > Subject: Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion
> for
> > > every PPB device in the system
> > >
> > > Reviewed-by: Ray Ni <ray.ni@intel.com>
> >
> > Hello all,
> >
> > I did not see the origin patch being sent to the mailing list.
> > Maybe Ashraf has not subscribed the mailing list?
>
> Sorry, saw it at:
> https://edk2.groups.io/g/devel/message/41418
>
> Acked-by: Hao A Wu <hao.a.wu@intel.com>
Pushed via commit 2603fce126.
Best Regards,
Hao Wu
>
> Best Regards,
> Hao Wu
>
> >
> > Best Regards,
> > Hao Wu
> >
> > >
> > > > -----Original Message-----
> > > > From: Javeed, Ashraf
> > > > Sent: Monday, May 27, 2019 6:24 PM
> > > > To: devel@edk2.groups.io
> > > > Cc: Javeed, Ashraf <ashraf.javeed@intel.com>; Wang, Jian J
> > > > <jian.j.wang@intel.com>; Ni, Ray <ray.ni@intel.com>
> > > > Subject: [PATCH] PciBusDxe: duplicate node insertion for every PPB
> > device
> > > in
> > > > the system
> > > >
> > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1796
> > > > Bug fixed in PciBusDxe\PciLib.c.
> > > > Removed the redundant second call to PciSearchDevice sub-routine
> > when
> > > > the PCD for the Hot-Plug support is disabled.
> > > >
> > > > Signed-off-by: Ashraf Javeed <Ashraf.javeed@intel.com>
> > > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > > Cc: Ray Ni <ray.ni@intel.com>
> > > > ---
> > > > MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------
> > > > 1 file changed, 1 insertion(+), 18 deletions(-)
> > > >
> > > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > > > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > > > index f0d9f45c4a..5b55fb5d3b 100644
> > > > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > > > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> > > > @@ -1114,24 +1114,7 @@ PciScanBus (
> > > > //
> > > > // For PPB
> > > > //
> > > > - if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> > > > - //
> > > > - // If Hot Plug is not supported,
> > > > - // get the bridge information
> > > > - //
> > > > - Status = PciSearchDevice (
> > > > - Bridge,
> > > > - &Pci,
> > > > - StartBusNumber,
> > > > - Device,
> > > > - Func,
> > > > - &PciDevice
> > > > - );
> > > > -
> > > > - if (EFI_ERROR (Status)) {
> > > > - return Status;
> > > > - }
> > > > - } else {
> > > > + if (FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> > > > //
> > > > // If Hot Plug is supported,
> > > > // Get the bridge information
> > > > --
> > > > 2.21.0.windows.1
> > >
> > >
> > >
> >
> >
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-01 7:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-27 10:23 [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system Javeed, Ashraf
2019-05-28 2:15 ` Ni, Ray
2019-06-17 9:49 ` Ni, Ray
2019-06-18 2:24 ` [edk2-devel] " Wu, Hao A
2019-06-18 2:27 ` Wu, Hao A
2019-07-01 7:39 ` Wu, Hao A
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox