From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: ray.ni@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Mon, 27 May 2019 19:15:56 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 May 2019 19:15:55 -0700 X-ExtLoop1: 1 Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 27 May 2019 19:15:56 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 27 May 2019 19:15:56 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 27 May 2019 19:15:55 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.70]) with mapi id 14.03.0415.000; Tue, 28 May 2019 10:15:53 +0800 From: "Ni, Ray" To: "Javeed, Ashraf" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system Thread-Topic: [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system Thread-Index: AQHVFHZ4FsFOv7Sp5kmoWKQLphqgQKZ/zX+Q Date: Tue, 28 May 2019 02:15:52 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C168D85@SHSMSX104.ccr.corp.intel.com> References: <20190527102356.15164-1-ashraf.javeed@intel.com> In-Reply-To: <20190527102356.15164-1-ashraf.javeed@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzU5MGI2NWMtOGVmYy00YWM0LTllNGEtMjBhZjUyNTgxZjFmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibUlYNFBYc0xhUko1Mm9hcERFbjFLbm5pU2Q5a0E1RGI3eEtDVVVqVlwvUFFHY25zSnljWGc5d1k4Y2FTeFdzMngifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Javeed, Ashraf > Sent: Monday, May 27, 2019 6:24 PM > To: devel@edk2.groups.io > Cc: Javeed, Ashraf ; Wang, Jian J > ; Ni, Ray > Subject: [PATCH] PciBusDxe: duplicate node insertion for every PPB device= in > the system >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1796 > Bug fixed in PciBusDxe\PciLib.c. > Removed the redundant second call to PciSearchDevice sub-routine when > the PCD for the Hot-Plug support is disabled. >=20 > Signed-off-by: Ashraf Javeed > Cc: Jian J Wang > Cc: Ray Ni > --- > MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------ > 1 file changed, 1 insertion(+), 18 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c > index f0d9f45c4a..5b55fb5d3b 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c > @@ -1114,24 +1114,7 @@ PciScanBus ( > // > // For PPB > // > - if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) { > - // > - // If Hot Plug is not supported, > - // get the bridge information > - // > - Status =3D PciSearchDevice ( > - Bridge, > - &Pci, > - StartBusNumber, > - Device, > - Func, > - &PciDevice > - ); > - > - if (EFI_ERROR (Status)) { > - return Status; > - } > - } else { > + if (FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) { > // > // If Hot Plug is supported, > // Get the bridge information > -- > 2.21.0.windows.1