From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>
Cc: "Justen, Jordan L" <jordan.l.justen@intel.com>,
Andrew Fish <afish@apple.com>
Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed
Date: Mon, 3 Jun 2019 06:51:37 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C18ACEB@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190603064503.20460-1-zhiguang.liu@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Zhiguang Liu
> Sent: Monday, June 3, 2019 2:45 PM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> <afish@apple.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current
> speed
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1686
>
> The bug reporter wish to diaplay nothing as the CPU is virtual
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
> MdeModulePkg/Application/UiApp/FrontPage.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c
> b/MdeModulePkg/Application/UiApp/FrontPage.c
> index 4b95cccb5c..fded763406 100644
> --- a/MdeModulePkg/Application/UiApp/FrontPage.c
> +++ b/MdeModulePkg/Application/UiApp/FrontPage.c
> @@ -621,11 +621,6 @@ UpdateFrontPageBannerStrings (
> HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN
> (STR_FRONT_PAGE_CPU_MODEL), NewString, NULL);
> FreePool (NewString);
>
> - ConvertProcessorToString(Type4Record->CurrentSpeed, 6,
> &NewString);
> - UiCustomizeFrontPageBanner (2, FALSE, &NewString);
> - HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN
> (STR_FRONT_PAGE_CPU_SPEED), NewString, NULL);
> - FreePool (NewString);
> -
> FoundCpu = TRUE;
> }
> }
> --
> 2.21.0.windows.1
>
>
>
next prev parent reply other threads:[~2019-06-03 6:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 6:45 [Patch V2] EmulatorPkg: don't diaplay the cpu current speed Zhiguang Liu
2019-06-03 6:51 ` Ni, Ray [this message]
[not found] ` <15A49DA9FFA456B0.4546@groups.io>
2019-06-04 8:50 ` [edk2-devel] " Ni, Ray
2019-06-04 11:53 ` Ard Biesheuvel
2019-06-04 13:40 ` Liming Gao
2019-06-04 13:41 ` Ard Biesheuvel
2019-06-04 14:19 ` Liming Gao
2019-06-05 1:10 ` Ni, Ray
2019-06-05 8:03 ` Laszlo Ersek
2019-06-05 14:31 ` Zeng, Star
2019-06-10 6:01 ` Wu, Hao A
2019-06-10 6:13 ` Yao, Jiewen
2019-06-10 6:20 ` Wu, Hao A
2019-06-10 7:16 ` Ni, Ray
2019-06-10 7:32 ` Wu, Hao A
2019-06-10 7:33 ` Ni, Ray
2019-06-10 7:37 ` Ard Biesheuvel
2019-06-10 8:07 ` Wu, Hao A
2019-06-10 10:50 ` Ard Biesheuvel
2019-06-11 15:19 ` Laszlo Ersek
2019-06-10 7:39 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C18ACEB@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox