Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

["Ni, Ray" <ray.ni@intel.com>]

Zhiguang,
I made a mistake here.
I thought you changed the EmulatorPkg to not display the CPU speed
but actually what you changed impacts all platforms.
With this change, OVMF cannot show the CPU speed either.

Can you please roll back this changes (if it was pushed in)?

To close the Bugzilla, I think you need to find out other ways that only
impact EmulatorPkg. Or does it really matter to show a 1234Hz in
Emulator UI?

Sorry I didn't give the comments earlier.

Thanks,
Ray

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni,
> Ray
> Sent: Monday, June 3, 2019 2:52 PM
> To: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> <afish@apple.com>
> Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> current speed
> 
> Reviewed-by: Ray Ni <ray.ni@intel.com>
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > Zhiguang Liu
> > Sent: Monday, June 3, 2019 2:45 PM
> > To: devel@edk2.groups.io
> > Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> > <afish@apple.com>; Ni, Ray <ray.ni@intel.com>
> > Subject: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> > current speed
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1686
> >
> > The bug reporter wish to diaplay nothing as the CPU is virtual
> >
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > ---
> >  MdeModulePkg/Application/UiApp/FrontPage.c | 5 -----
> >  1 file changed, 5 deletions(-)
> >
> > diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c
> > b/MdeModulePkg/Application/UiApp/FrontPage.c
> > index 4b95cccb5c..fded763406 100644
> > --- a/MdeModulePkg/Application/UiApp/FrontPage.c
> > +++ b/MdeModulePkg/Application/UiApp/FrontPage.c
> > @@ -621,11 +621,6 @@ UpdateFrontPageBannerStrings (
> >          HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN
> > (STR_FRONT_PAGE_CPU_MODEL), NewString, NULL);
> >          FreePool (NewString);
> >
> > -        ConvertProcessorToString(Type4Record->CurrentSpeed, 6,
> > &NewString);
> > -        UiCustomizeFrontPageBanner (2, FALSE, &NewString);
> > -        HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN
> > (STR_FRONT_PAGE_CPU_SPEED), NewString, NULL);
> > -        FreePool (NewString);
> > -
> >          FoundCpu = TRUE;
> >        }
> >      }
> > --
> > 2.21.0.windows.1
> >
> >
> >
> 
> 
>