From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ray.ni@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Tue, 04 Jun 2019 01:50:35 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2019 01:50:34 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga007.fm.intel.com with ESMTP; 04 Jun 2019 01:50:34 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Jun 2019 01:50:34 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Jun 2019 01:50:34 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.137]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.187]) with mapi id 14.03.0415.000; Tue, 4 Jun 2019 16:50:32 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Ni, Ray" , "Liu, Zhiguang" CC: "Justen, Jordan L" , Andrew Fish Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed Thread-Topic: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed Thread-Index: AQHVGdfycauCGkpC402vij+ELikwKKaJfdXQgAGyNRA= Date: Tue, 4 Jun 2019 08:50:31 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C18F543@SHSMSX104.ccr.corp.intel.com> References: <20190603064503.20460-1-zhiguang.liu@intel.com> <15A49DA9FFA456B0.4546@groups.io> In-Reply-To: <15A49DA9FFA456B0.4546@groups.io> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWM3NjA0MmUtZjMyMi00MzE5LWI3Y2YtMTgzZDY2ZDNjMGFhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQ1RsXC8xdUEyZkIwSTRlcUZOMlJxU2tCRTdLS3FkcFdLdTZpSWpyODN4V1RORHczSEFyXC8xR0hET2ZLOW9DMU1XIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Zhiguang, I made a mistake here. I thought you changed the EmulatorPkg to not display the CPU speed but actually what you changed impacts all platforms. With this change, OVMF cannot show the CPU speed either. Can you please roll back this changes (if it was pushed in)? To close the Bugzilla, I think you need to find out other ways that only impact EmulatorPkg. Or does it really matter to show a 1234Hz in Emulator UI? Sorry I didn't give the comments earlier. Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni= , > Ray > Sent: Monday, June 3, 2019 2:52 PM > To: devel@edk2.groups.io; Liu, Zhiguang > Cc: Justen, Jordan L ; Andrew Fish > > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu > current speed >=20 > Reviewed-by: Ray Ni >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > > Zhiguang Liu > > Sent: Monday, June 3, 2019 2:45 PM > > To: devel@edk2.groups.io > > Cc: Justen, Jordan L ; Andrew Fish > > ; Ni, Ray > > Subject: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu > > current speed > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1686 > > > > The bug reporter wish to diaplay nothing as the CPU is virtual > > > > Cc: Jordan Justen > > Cc: Andrew Fish > > Cc: Ray Ni > > Signed-off-by: Zhiguang Liu > > --- > > MdeModulePkg/Application/UiApp/FrontPage.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c > > b/MdeModulePkg/Application/UiApp/FrontPage.c > > index 4b95cccb5c..fded763406 100644 > > --- a/MdeModulePkg/Application/UiApp/FrontPage.c > > +++ b/MdeModulePkg/Application/UiApp/FrontPage.c > > @@ -621,11 +621,6 @@ UpdateFrontPageBannerStrings ( > > HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN > > (STR_FRONT_PAGE_CPU_MODEL), NewString, NULL); > > FreePool (NewString); > > > > - ConvertProcessorToString(Type4Record->CurrentSpeed, 6, > > &NewString); > > - UiCustomizeFrontPageBanner (2, FALSE, &NewString); > > - HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN > > (STR_FRONT_PAGE_CPU_SPEED), NewString, NULL); > > - FreePool (NewString); > > - > > FoundCpu =3D TRUE; > > } > > } > > -- > > 2.21.0.windows.1 > > > > > > >=20 >=20 >=20