From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ray.ni@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Fri, 14 Jun 2019 01:50:00 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jun 2019 01:49:59 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 14 Jun 2019 01:49:59 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 14 Jun 2019 01:49:59 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 14 Jun 2019 01:49:58 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.173]) with mapi id 14.03.0439.000; Fri, 14 Jun 2019 16:49:57 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Yao, Jiewen" , "Gao, Zhichao" CC: Bret Barkelew , "Zhang, Chao B" , "Wang, Jian J" , "Gao, Liming" , Sean Brogan , Michael Turner , Leif Lindholm Subject: Re: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for build only Thread-Topic: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for build only Thread-Index: AQHVIowe1J2YsoAhRUuZLflFV2S09qaaUIOAgACGJ5A= Date: Fri, 14 Jun 2019 08:49:57 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C1C6A69@SHSMSX104.ccr.corp.intel.com> References: <20190614083438.10728-1-zhichao.gao@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F6B3E82@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503F6B3E82@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes I agree. Since UID feature was completely dropped early this year, this is a missin= g library that should be removed together with UID. Zhichao, Can you help submit a BZ for this removal? I am ok with your current patch to include this library. This library can = be removed by further patch that removes DxeDeferImageLoadLib. Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > Sent: Friday, June 14, 2019 4:48 PM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Bret Barkelew ; Zhang, Chao B > ; Wang, Jian J ; Gao, > Liming ; Sean Brogan ; > Michael Turner ; Leif Lindholm > > Subject: Re: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances = for > build only >=20 > Hi > It is good to add those to build. >=20 > However, I think we should remove > SecurityPkg\Library\DxeDeferImageLoadLib from the code base. >=20 > This lib supports old UID and may conflict with > MdeModulePkg\Universal\SecurityStubDxe\Defer3rdPartyImageLoad.c >=20 >=20 > Thank you > Yao Jiewen >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Gao, Zhichao > > Sent: Friday, June 14, 2019 4:35 PM > > To: devel@edk2.groups.io > > Cc: Bret Barkelew ; Zhang, Chao B > > ; Yao, Jiewen ; Wang, > > Jian J ; Gao, Liming ; > > Sean Brogan ; Michael Turner > > ; Leif Lindholm > > ; Gao, Zhichao > > Subject: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances > > for build only > > > > From: Bret Barkelew > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1902 > > > > Add the missing instances to the [Components] of dsc file for build > > only. > > > > Cc: Chao Zhang > > Cc: Jiewen Yao > > Cc: Jian Wang > > Cc: Liming Gao > > Cc: Sean Brogan > > Cc: Michael Turner > > Cc: Bret Barkelew > > Cc: Leif Lindholm > > Signed-off-by: Zhichao gao > > --- > > V2: fix with Laszlo's comment: > > https://edk2.groups.io/g/devel/message/42273 > > > > SecurityPkg/SecurityPkg.dsc | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc > > index a2ee0528f0..ed0da7563d 100644 > > --- a/SecurityPkg/SecurityPkg.dsc > > +++ b/SecurityPkg/SecurityPkg.dsc > > @@ -199,6 +199,12 @@ > > > > > SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs > > 7 > > .inf > > > > > SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticatio > > nLibRsa2048Sha256.inf > > > > + SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.inf > > + > > > SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf > > + SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf > > + SecurityPkg/Library/Tcg2PpVendorLibNull/Tcg2PpVendorLibNull.inf > > + SecurityPkg/Library/TcgPpVendorLibNull/TcgPpVendorLibNull.inf > > + > > [Components.IA32, Components.X64, Components.ARM, > Components.AARCH64] > > SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf > > > > -- > > 2.21.0.windows.1 > > > > > > >=20 >=20 >=20