From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Sun, 16 Jun 2019 20:26:38 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jun 2019 20:26:37 -0700 X-ExtLoop1: 1 Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 16 Jun 2019 20:26:37 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 16 Jun 2019 20:26:37 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 16 Jun 2019 20:26:37 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.89]) with mapi id 14.03.0439.000; Mon, 17 Jun 2019 11:26:35 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Chiu, Chasel" CC: "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: add TempRamExitPpi.h. Thread-Topic: [edk2-devel] [PATCH v2] IntelFsp2Pkg: add TempRamExitPpi.h. Thread-Index: AQHVJLZBJS6thAPM4UCrPHl2y/Fn+6afK5bg Date: Mon, 17 Jun 2019 03:26:34 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C1CF649@SHSMSX104.ccr.corp.intel.com> References: <20190617024137.9436-1-chasel.chiu@intel.com> In-Reply-To: <20190617024137.9436-1-chasel.chiu@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Chasel, I found another instance of this PPI in edk2-platforms/Silicon/Intel/Kabyl= akeSiliconPkg/Include/Ppi. Will you remove that one after this is checked in? Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chiu, > Chasel > Sent: Monday, June 17, 2019 10:42 AM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Zeng, Star > > Subject: [edk2-devel] [PATCH v2] IntelFsp2Pkg: add TempRamExitPpi.h. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1883 >=20 > Add header file for FSP_TEMP_RAM_EXIT_PPI which is defined by FSP 2.1 > spec. >=20 > Test: Build successfully. >=20 > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Chasel Chiu > --- > IntelFsp2Pkg/Include/Ppi/TempRamExitPpi.h | 52 > ++++++++++++++++++++++++++++++++++++++++++++++++++++ > IntelFsp2Pkg/IntelFsp2Pkg.dec | 5 +++++ > 2 files changed, 57 insertions(+) >=20 > diff --git a/IntelFsp2Pkg/Include/Ppi/TempRamExitPpi.h > b/IntelFsp2Pkg/Include/Ppi/TempRamExitPpi.h > new file mode 100644 > index 0000000000..0db54dfa45 > --- /dev/null > +++ b/IntelFsp2Pkg/Include/Ppi/TempRamExitPpi.h > @@ -0,0 +1,52 @@ > +/** @file > + This file defines the Silicon Temp Ram Exit PPI which implements the > + required programming steps for disabling temporary memory. > + > +Copyright (c) 2019, Intel Corporation. All rights reserved.
> +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#ifndef _FSP_TEMP_RAM_EXIT_PPI_H_ > +#define _FSP_TEMP_RAM_EXIT_PPI_H_ > + > +/// > +/// Global ID for the FSP_TEMP_RAM_EXIT_PPI. > +/// > +#define FSP_TEMP_RAM_EXIT_GUID \ > + { \ > + 0xbc1cfbdb, 0x7e50, 0x42be, { 0xb4, 0x87, 0x22, 0xe0, 0xa9, 0x0c, > +0xb0, 0x52 } \ > + } > + > +// > +// Forward declaration for the FSP_TEMP_RAM_EXIT_PPI. > +// > +typedef struct _FSP_TEMP_RAM_EXIT_PPI FSP_TEMP_RAM_EXIT_PPI; > + > +/** > + Silicon function for disabling temporary memory. > + @param[in] TempRamExitParamPtr - Pointer to the TempRamExit > parameters structure. > + This structure is normally defined i= n the Integration > + Guide. If it is not defined in the I= ntegration Guide, > + pass NULL. > + @retval EFI_SUCCESS - FSP execution environment was initia= lized > successfully. > + @retval EFI_INVALID_PARAMETER - Input parameters are invalid. > + @retval EFI_UNSUPPORTED - The FSP calling conditions were not = met. > + @retval EFI_DEVICE_ERROR - Temporary memory exit. > +**/ > +typedef > +EFI_STATUS > +(EFIAPI *FSP_TEMP_RAM_EXIT) ( > + IN VOID *TempRamExitParamPtr > + ); > + > +/// > +/// This PPI provides function to disable temporary memory. > +/// > +struct _FSP_TEMP_RAM_EXIT_PPI { > + FSP_TEMP_RAM_EXIT TempRamExit; > +}; > + > +extern EFI_GUID gFspTempRamExitPpiGuid; > + > +#endif // _FSP_TEMP_RAM_EXIT_PPI_H_ > diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.dec b/IntelFsp2Pkg/IntelFsp2Pkg.d= ec > index cc17164742..ad2b7f7fb5 100644 > --- a/IntelFsp2Pkg/IntelFsp2Pkg.dec > +++ b/IntelFsp2Pkg/IntelFsp2Pkg.dec > @@ -49,6 +49,11 @@ > # > gFspInApiModePpiGuid =3D { 0xa1eeab87, 0xc859, 0x479= d, {0x89, > 0xb5, 0x14, 0x61, 0xf4, 0x06, 0x1a, 0x3e}} >=20 > + # > + # PPI to tear down the temporary memory set up by TempRamInit (). > + # > + gFspTempRamExitPpiGuid =3D {0xbc1cfbdb, 0x7e50, 0x42be, {0xb4, 0= x87, > 0x22, 0xe0, 0xa9, 0x0c, 0xb0, 0x52}} > + > [Guids] > # > # GUID defined in package > -- > 2.13.3.windows.1 >=20 >=20 >=20