public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] EmulatorPkg/Win: support running multiple WinHost.exe
@ 2019-06-14  8:23 Ni, Ray
  2019-06-14  8:44 ` [edk2-devel] " Yao, Jiewen
  0 siblings, 1 reply; 4+ messages in thread
From: Ni, Ray @ 2019-06-14  8:23 UTC (permalink / raw)
  To: devel; +Cc: Jordan Justen, Andrew Fish, Zhiguang Liu, Hao A Wu

When running 2nd instance of WinHost.exe, below error is printed:
ERROR : Can not open Firmware Device File ../FV/FV_RECOVERY.fd...

The root cause is "RECOVERY.FD" is exclusively opened by the first
instance of WinHost.exe.

The patch changes to open "RECOVERY.FD" in shared way so that
2nd+ instance of WinHost.exe can still run successfully.

Signed-off-by: Ray Ni <ray.ni@intel.com>

Signed-off-by: Ray Ni <ray.ni@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
---
 EmulatorPkg/Win/Host/WinHost.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/EmulatorPkg/Win/Host/WinHost.c b/EmulatorPkg/Win/Host/WinHost.c
index bd7662683a..5a354d084e 100644
--- a/EmulatorPkg/Win/Host/WinHost.c
+++ b/EmulatorPkg/Win/Host/WinHost.c
@@ -269,7 +269,7 @@ Returns:
     NtFileHandle = CreateFile (
                      FileName,
                      GENERIC_READ | GENERIC_WRITE | GENERIC_EXECUTE,
-                     FILE_SHARE_READ,
+                     FILE_SHARE_READ | FILE_SHARE_WRITE,
                      NULL,
                      CreationDisposition,
                      FILE_ATTRIBUTE_NORMAL,
-- 
2.21.0.windows.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-06-17  7:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-14  8:23 [PATCH] EmulatorPkg/Win: support running multiple WinHost.exe Ni, Ray
2019-06-14  8:44 ` [edk2-devel] " Yao, Jiewen
2019-06-14  8:53   ` Ni, Ray
     [not found]   ` <15A804AED7A7D734.10316@groups.io>
2019-06-17  7:02     ` Ni, Ray

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox