From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: ray.ni@intel.com)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by groups.io with SMTP; Mon, 17 Jun 2019 02:49:22 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
  by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2019 02:49:21 -0700
X-ExtLoop1: 1
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
  by orsmga005.jf.intel.com with ESMTP; 17 Jun 2019 02:49:20 -0700
Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 17 Jun 2019 02:49:20 -0700
Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by
 fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 17 Jun 2019 02:49:19 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by
 SHSMSX105.ccr.corp.intel.com ([169.254.11.72]) with mapi id 14.03.0439.000;
 Mon, 17 Jun 2019 17:49:18 +0800
From: "Ni, Ray" <ray.ni@intel.com>
To: "Javeed, Ashraf" <ashraf.javeed@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system
Thread-Topic: [PATCH] PciBusDxe: duplicate node insertion for every PPB
 device in the system
Thread-Index: AQHVFHZ4FsFOv7Sp5kmoWKQLphqgQKafurSg
Date: Mon, 17 Jun 2019 09:49:17 +0000
Deferred-Delivery: Mon, 17 Jun 2019 09:49:00 +0000
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C1D1F07@SHSMSX104.ccr.corp.intel.com>
References: <20190527102356.15164-1-ashraf.javeed@intel.com>
In-Reply-To: <20190527102356.15164-1-ashraf.javeed@intel.com>
Accept-Language: en-US, zh-CN
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDY2NzhiYzMtOTgzNC00YWZkLTllODAtNTNiMGRkNGEyYTllIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZVwvRWd4eGJKVXFMS3B4MW9DeUYyMDhHSEs3K1pJQTVhU2Q1SU16clhYVTFnUFpNbmwyWnl1dk53TVE1SFNnWjQifQ==
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: ray.ni@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Javeed, Ashraf
> Sent: Monday, May 27, 2019 6:24 PM
> To: devel@edk2.groups.io
> Cc: Javeed, Ashraf <ashraf.javeed@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH] PciBusDxe: duplicate node insertion for every PPB device=
 in
> the system
>=20
> https://bugzilla.tianocore.org/show_bug.cgi?id=3D1796
> Bug fixed in PciBusDxe\PciLib.c.
> Removed the redundant second call to PciSearchDevice sub-routine when
> the PCD for the Hot-Plug support is disabled.
>=20
> Signed-off-by: Ashraf Javeed <Ashraf.javeed@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c | 19 +------------------
>  1 file changed, 1 insertion(+), 18 deletions(-)
>=20
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> index f0d9f45c4a..5b55fb5d3b 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c
> @@ -1114,24 +1114,7 @@ PciScanBus (
>          //
>          // For PPB
>          //
> -        if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> -          //
> -          // If Hot Plug is not supported,
> -          // get the bridge information
> -          //
> -          Status =3D PciSearchDevice (
> -                    Bridge,
> -                    &Pci,
> -                    StartBusNumber,
> -                    Device,
> -                    Func,
> -                    &PciDevice
> -                    );
> -
> -          if (EFI_ERROR (Status)) {
> -            return Status;
> -          }
> -        } else {
> +        if (FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
>            //
>            // If Hot Plug is supported,
>            // Get the bridge information
> --
> 2.21.0.windows.1