From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: ray.ni@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Tue, 18 Jun 2019 22:06:13 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jun 2019 22:06:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,391,1557212400"; d="scan'208";a="153693822" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga008.jf.intel.com with ESMTP; 18 Jun 2019 22:06:11 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 18 Jun 2019 22:06:11 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 18 Jun 2019 22:06:10 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.83]) with mapi id 14.03.0439.000; Wed, 19 Jun 2019 13:06:09 +0800 From: "Ni, Ray" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: Bret Barkelew , "Wang, Jian J" , "Wu, Hao A" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner Subject: Re: [PATCH V4 1/2] MdeModulePkg: Add a pcd to set the OS indications bit Thread-Topic: [PATCH V4 1/2] MdeModulePkg: Add a pcd to set the OS indications bit Thread-Index: AQHVJkyXCpyHCy1sFkyPvloVJnPalKaibJlQ Date: Wed, 19 Jun 2019 05:06:08 +0000 Deferred-Delivery: Wed, 19 Jun 2019 05:06:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C1D9489@SHSMSX104.ccr.corp.intel.com> References: <20190619031023.10820-1-zhichao.gao@intel.com> <20190619031023.10820-2-zhichao.gao@intel.com> In-Reply-To: <20190619031023.10820-2-zhichao.gao@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjZlNmU3ZGMtNWIzYS00ZDMyLWIwMWYtZDQxZDZlZGNiZGYxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicllqKzRrMktUMkdCU2lxQnZ0TGs1XC9oRHhpYTVFaGNBa2QzYjhTaEpLQ3pzY3FHaFVIdWZ5Q3IzVzZlMnlTRnUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Gao, Zhichao > Sent: Wednesday, June 19, 2019 11:10 AM > To: devel@edk2.groups.io > Cc: Bret Barkelew ; Wang, Jian J > ; Wu, Hao A ; Ni, Ray > ; Zeng, Star ; Gao, Liming > ; Sean Brogan ; > Michael Turner > Subject: [PATCH V4 1/2] MdeModulePkg: Add a pcd to set the OS indications > bit >=20 > From: Bret Barkelew >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1678 >=20 > Add a pcd PcdPlatformRecoverySupport to conditionally set an OS > indications bit and set the 'PlatformRecovery####' > variable. This pcd would also control whether the BDS support platform > recovery or not. > Update the uni file for description of the pcd. >=20 > Cc: Jian J Wang > Cc: Hao Wu > Cc: Ray Ni > Cc: Star Zeng > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew > Signed-off-by: Zhichao Gao > --- > MdeModulePkg/MdeModulePkg.dec | 6 ++++++ > MdeModulePkg/MdeModulePkg.uni | 2 ++ > 2 files changed, 8 insertions(+) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 0a9fcddecc..da2b85770c > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -1660,6 +1660,12 @@ > # @Prompt Reset on memory type information change. >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationCh > ange|TRUE|BOOLEAN|0x00010056 >=20 > + ## Indicates if the BDS supports Platform Recovery.

> + # TRUE - BDS supports Platform Recovery.
> + # FALSE - BDS does not support Platform Recovery.
> + # @Prompt Support Platform Recovery. > + > + > gEfiMdeModulePkgTokenSpaceGuid.PcdPlatformRecoverySupport|TRUE|BO > OLEAN > + |0x00010078 > + > ## Specify the foreground color for Subtile text in HII Form Browser. = The > default value is EFI_BLUE. > # Only following values defined in UEFI specification are valid:
<= BR> > # 0x00 (EFI_BLACK)
> diff --git a/MdeModulePkg/MdeModulePkg.uni > b/MdeModulePkg/MdeModulePkg.uni index ed8ac9eadc..a265452eba > 100644 > --- a/MdeModulePkg/MdeModulePkg.uni > +++ b/MdeModulePkg/MdeModulePkg.uni > @@ -441,6 +441,8 @@ >=20 > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdResetOnMemoryTypeInformati > onChange_PROMPT #language en-US "Reset on memory type information > change" >=20 > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdResetOnMemoryTypeInformati > onChange #language en-US "Indicate the system support platform recovery > or not" > + > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdResetOnMemoryTypeInformati > onChange_HELP #language en-US "Indicates if to reset system when > memory type information changes.

\n" > = "TRUE - Resets > system when memory type information changes.
\n" > = "FALSE - Does not > reset system when memory type information changes.
" > -- > 2.21.0.windows.1