From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ray.ni@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Sat, 13 Jul 2019 04:13:12 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jul 2019 04:13:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,486,1557212400"; d="scan'208";a="250372445" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 13 Jul 2019 04:13:11 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 13 Jul 2019 04:13:11 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 13 Jul 2019 04:13:11 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.22]) with mapi id 14.03.0439.000; Sat, 13 Jul 2019 19:13:09 +0800 From: "Ni, Ray" To: "Justen, Jordan L" , "devel@edk2.groups.io" , Andrew Fish Subject: Re: [PATCH] EmulatorPkg/build.sh: Fix missing usage of -b BUILDTARGET parameter Thread-Topic: [PATCH] EmulatorPkg/build.sh: Fix missing usage of -b BUILDTARGET parameter Thread-Index: AQHVOU5uF84nUXgep0KOR6iPELt336bIZP1Q Date: Sat, 13 Jul 2019 11:13:09 +0000 Deferred-Delivery: Sat, 13 Jul 2019 11:13:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C229CBF@SHSMSX104.ccr.corp.intel.com> References: <20190410090734.19835-1-jordan.l.justen@intel.com> <156300370674.5689.6433150749740005539@jljusten-skl> In-Reply-To: <156300370674.5689.6433150749740005539@jljusten-skl> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTVkMjI4MzYtY2I3Ni00ZDAwLTg2MzEtNjZlZmI5NzcyN2VkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNGY0YTBOZFVQYjF3R29heXhNeFNWa2xSWm9TZFFVakJvRGRmOGs2OVo1M0NXdWhaNmtjcjZqYkw5TTJCNDNMRyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Justen, Jordan L > Sent: Saturday, July 13, 2019 3:42 PM > To: devel@edk2.groups.io; Andrew Fish ; Ni, Ray > Subject: Re: [PATCH] EmulatorPkg/build.sh: Fix missing usage of -b BUILDT= ARGET parameter >=20 > On 2019-04-10 02:07:34, Jordan Justen wrote: > > Signed-off-by: Jordan Justen > > Cc: Andrew Fish > > Cc: Ray Ni >=20 > ping >=20 > > --- > > EmulatorPkg/build.sh | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/EmulatorPkg/build.sh b/EmulatorPkg/build.sh > > index 89fd26baca..75561c116a 100755 > > --- a/EmulatorPkg/build.sh > > +++ b/EmulatorPkg/build.sh > > @@ -1,7 +1,7 @@ > > #!/bin/bash > > # > > # Copyright (c) 2008 - 2011, Apple Inc. All rights reserved.
> > -# Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved. > > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. > > # > > # SPDX-License-Identifier: BSD-2-Clause-Patent > > # > > @@ -188,7 +188,7 @@ do > > done > > > > PLATFORMFILE=3D$WORKSPACE/EmulatorPkg/EmulatorPkg.dsc > > -BUILD_DIR=3D$BUILD_OUTPUT_DIR/DEBUG_"$TARGET_TOOLS" > > +BUILD_DIR=3D"$BUILD_OUTPUT_DIR/${BUILDTARGET}_$TARGET_TOOLS" > > BUILD_ROOT_ARCH=3D$BUILD_DIR/$PROCESSOR > > > > if [[ ! -f `which build` || ! -f `which GenFv` ]]; > > @@ -218,11 +218,11 @@ if [[ "$RUN_EMULATOR" =3D=3D "yes" ]]; then > > then > > # only older versions of Xcode support -ccc-host-tripe, for newe= r versions > > # it is -target > > - cp $WORKSPACE/EmulatorPkg/Unix/lldbefi.py $BUILD_OUTPUT_DIR/DE= BUG_"$TARGET_TOOLS"/$PROCESSOR > > + cp $WORKSPACE/EmulatorPkg/Unix/lldbefi.py > "$BUILD_OUTPUT_DIR/${BUILDTARGET}_$TARGET_TOOLS/$PROCESSOR" > > cd $BUILD_ROOT_ARCH; /usr/bin/lldb --source $WORKSPACE/Emulato= rPkg/Unix/lldbinit Host > > exit $? > > else > > - cp $WORKSPACE/EmulatorPkg/Unix/.gdbinit $BUILD_OUTPUT_DIR/DEBU= G_"$TARGET_TOOLS"/$PROCESSOR > > + cp $WORKSPACE/EmulatorPkg/Unix/.gdbinit "$BUILD_OUTPUT_DIR/${B= UILDTARGET}_$TARGET_TOOLS/$PROCESSOR" > > fi > > ;; > > esac > > @@ -255,7 +255,7 @@ if [[ $HOST_TOOLS =3D=3D $TARGET_TOOLS ]]; then > > else > > build -p $WORKSPACE/EmulatorPkg/EmulatorPkg.dsc $BUILD_OPTIONS -a $P= ROCESSOR -b $BUILDTARGET -t $HOST_TOOLS > -D BUILD_$ARCH_SIZE -D UNIX_SEC_BUILD -D SKIP_MAIN_BUILD -n 3 modules > > build -p $WORKSPACE/EmulatorPkg/EmulatorPkg.dsc $BUILD_OPTIONS -a $P= ROCESSOR -b $BUILDTARGET -t > $TARGET_TOOLS -D BUILD_$ARCH_SIZE $NETWORK_SUPPORT $BUILD_NEW_SHELL $BUIL= D_FAT -n 3 > > - cp $BUILD_OUTPUT_DIR/DEBUG_"$HOST_TOOLS"/$PROCESSOR/Host $BUILD_ROOT= _ARCH > > + cp "$BUILD_OUTPUT_DIR/${BUILDTARGET}_$HOST_TOOLS/$PROCESSOR/Host" $B= UILD_ROOT_ARCH > > fi > > exit $? > > > > -- > > 2.20.1 > >