From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: ray.ni@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Wed, 17 Jul 2019 01:07:09 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2019 01:07:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,273,1559545200"; d="scan'208";a="158391059" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga007.jf.intel.com with ESMTP; 17 Jul 2019 01:07:08 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jul 2019 01:07:07 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 17 Jul 2019 01:07:06 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 17 Jul 2019 01:07:06 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.134]) with mapi id 14.03.0439.000; Wed, 17 Jul 2019 16:07:05 +0800 From: "Ni, Ray" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner , Bret Barkelew Subject: Re: [PATCH 0/4] Add a pcd PcdBootManagerInBootOrder to control whether BootManager is in BootOrder Thread-Topic: [PATCH 0/4] Add a pcd PcdBootManagerInBootOrder to control whether BootManager is in BootOrder Thread-Index: AQHVPHUgSIPB3zAwy0ivpJlDegaEA6bOchhA Date: Wed, 17 Jul 2019 08:07:05 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C23325A@SHSMSX104.ccr.corp.intel.com> References: <20190717075008.22716-1-zhichao.gao@intel.com> In-Reply-To: <20190717075008.22716-1-zhichao.gao@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Zhichao, Firstly, patch 4/4 is a fix to patch 3/4, why not merge them into one patch= ? Do we have a policy to strictly cherry-pick the patches from MU? Secondly, the change that skips to add the #### to BootOrder may cause the = Boot#### pointing to the BootManagerMenu be overwritten later. Reason is Bm= GetFreeOptionNumber() replies on BootOrder/BootNext to get a free option nu= mber. If the requirement is to let BootManagerMenuApp hide the BootManagerMenu, w= e could change the BootManagerMenuApp using a PCD to control. Thanks, Ray > -----Original Message----- > From: Gao, Zhichao > Sent: Wednesday, July 17, 2019 3:50 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray ; Zeng, Star ; Gao, Liming > ; Sean Brogan ; > Michael Turner ; Bret Barkelew > > Subject: [PATCH 0/4] Add a pcd PcdBootManagerInBootOrder to control > whether BootManager is in BootOrder >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1979 >=20 > Add a pcd to control whether the BootManager is in BootOrder variable. > From a UI perspective, it never want to see a Front Page UI in the boot o= rder > list. So add a pcd PcdBootManagerInBootOrder to control it. If it is FALS= E, the > BootManager App wouldn't be added to BootOrder. And it wouldn't be > shown in the BootManagerMenuApp. >=20 > Notes: > BootManager means the application with file guid PcdBootManagerMenuFile. > It's default value is EEC25BDC-67F2-4D95-B1D5-F81B2039D11D, and users > usually change the pcd to UiApp.inf's file guid. BootManagerMenuApp > means uefi application with file guid EEC25BDC-67F2-4D95-B1D5- > F81B2039D11D. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Ray Ni > Cc: Star Zeng > Cc: Liming gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew > Signed-off-by: Zhichao Gao >=20 > Bret Barkelew (2): > MdeModulePkg: Add PcdBootManagerInBootOrder to dec file > MdeModulePkg: Use pcd to control if BootManager in BootOrder >=20 > Zhichao Gao (2): > MdeModulePkg: Add prompt and help string for > PcdBootManagerInBootOrder > MdeModulePkg: PcdBootManagerInBootOrder should only affect > BootOrder >=20 > .../Library/UefiBootManagerLib/BmBoot.c | 29 +++++++++++++++---- > .../UefiBootManagerLib/UefiBootManagerLib.inf | 1 + > MdeModulePkg/MdeModulePkg.dec | 6 ++++ > MdeModulePkg/MdeModulePkg.uni | 6 ++++ > 4 files changed, 36 insertions(+), 6 deletions(-) >=20 > -- > 2.21.0.windows.1