From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: ray.ni@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Wed, 17 Jul 2019 01:42:36 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2019 01:42:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,273,1559545200"; d="scan'208";a="187517466" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 17 Jul 2019 01:42:34 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jul 2019 01:42:31 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jul 2019 01:42:31 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.134]) with mapi id 14.03.0439.000; Wed, 17 Jul 2019 16:42:29 +0800 From: "Ni, Ray" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner , Bret Barkelew Subject: Re: [PATCH 0/4] Add a pcd PcdBootManagerInBootOrder to control whether BootManager is in BootOrder Thread-Topic: [PATCH 0/4] Add a pcd PcdBootManagerInBootOrder to control whether BootManager is in BootOrder Thread-Index: AQHVPHUgSIPB3zAwy0ivpJlDegaEA6bOchhAgAADWnCAAAg2AA== Date: Wed, 17 Jul 2019 08:42:29 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C2332DF@SHSMSX104.ccr.corp.intel.com> References: <20190717075008.22716-1-zhichao.gao@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C23325A@SHSMSX104.ccr.corp.intel.com> <3CE959C139B4C44DBEA1810E3AA6F9000B8085BB@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B8085BB@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I don't know the requirement. That's just my guess so I used "if". You need to clarify with Bret Barkelew and get real requirement. > -----Original Message----- > From: Gao, Zhichao > Sent: Wednesday, July 17, 2019 4:29 PM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Zeng, Star ; Gao, Liming ; > Sean Brogan ; Michael Turner > ; Bret Barkelew > > Subject: RE: [PATCH 0/4] Add a pcd PcdBootManagerInBootOrder to control > whether BootManager is in BootOrder >=20 > Ray, >=20 > You are right. I didn't view the implementation of BmGetFreeOptionNumber. > Only use it base on its comments. > If new options are added after BootManagerMenuApp with the pcd's value > FALSE then it would be overwriten. >=20 > 3/4 would remove the BootManagerMenuApp option from Boot#### and > BootOrder. But adding it to BootMenu (i.e. BootOrder) is done by platform > code, platform usually add it at PlatformBootManagerAfterConsole function= . > So I think we are able to choose whether to add it or not. Both changing = the > pcd or do not add it in the platform (actually PlatformBootManagerLib) ca= n > match this requirement. >=20 > So I think the requirement is keeping all the features of BootMenuApp (su= ch > as hotkey boot, boot next and so on) except showing it in the BootMenu. >=20 > This patch is inappropriate. But firstly, did I misunderstand the require= ment? >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: Ni, Ray > > Sent: Wednesday, July 17, 2019 4:07 PM > > To: Gao, Zhichao ; devel@edk2.groups.io > > Cc: Wang, Jian J ; Wu, Hao A > > ; Zeng, Star ; Gao, Liming > > ; Sean Brogan ; > > Michael Turner ; Bret Barkelew > > > > Subject: RE: [PATCH 0/4] Add a pcd PcdBootManagerInBootOrder to > > control whether BootManager is in BootOrder > > > > Zhichao, > > > > Firstly, patch 4/4 is a fix to patch 3/4, why not merge them into one > > patch? Do we have a policy to strictly cherry-pick the patches from MU? > > > > Secondly, the change that skips to add the #### to BootOrder may cause > > the Boot#### pointing to the BootManagerMenu be overwritten later. > > Reason is > > BmGetFreeOptionNumber() replies on BootOrder/BootNext to get a free > > option number. > > > > If the requirement is to let BootManagerMenuApp hide the > > BootManagerMenu, we could change the BootManagerMenuApp using a > PCD to > > control. > > > > Thanks, > > Ray > > > > > -----Original Message----- > > > From: Gao, Zhichao > > > Sent: Wednesday, July 17, 2019 3:50 PM > > > To: devel@edk2.groups.io > > > Cc: Wang, Jian J ; Wu, Hao A > > > ; Ni, Ray ; Zeng, Star > > > ; Gao, Liming ; Sean > > > Brogan ; Michael Turner > > > ; Bret Barkelew > > > > > > Subject: [PATCH 0/4] Add a pcd PcdBootManagerInBootOrder to control > > > whether BootManager is in BootOrder > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1979 > > > > > > Add a pcd to control whether the BootManager is in BootOrder variable= . > > > From a UI perspective, it never want to see a Front Page UI in the > > > boot order list. So add a pcd PcdBootManagerInBootOrder to control it= . > > > If it is FALSE, the BootManager App wouldn't be added to BootOrder. > > > And it wouldn't be shown in the BootManagerMenuApp. > > > > > > Notes: > > > BootManager means the application with file guid > > PcdBootManagerMenuFile. > > > It's default value is EEC25BDC-67F2-4D95-B1D5-F81B2039D11D, and > > > users usually change the pcd to UiApp.inf's file guid. > > > BootManagerMenuApp means uefi application with file guid > > > EEC25BDC-67F2-4D95-B1D5- F81B2039D11D. > > > > > > Cc: Jian J Wang > > > Cc: Hao A Wu > > > Cc: Ray Ni > > > Cc: Star Zeng > > > Cc: Liming gao > > > Cc: Sean Brogan > > > Cc: Michael Turner > > > Cc: Bret Barkelew > > > Signed-off-by: Zhichao Gao > > > > > > Bret Barkelew (2): > > > MdeModulePkg: Add PcdBootManagerInBootOrder to dec file > > > MdeModulePkg: Use pcd to control if BootManager in BootOrder > > > > > > Zhichao Gao (2): > > > MdeModulePkg: Add prompt and help string for > > > PcdBootManagerInBootOrder > > > MdeModulePkg: PcdBootManagerInBootOrder should only affect > > BootOrder > > > > > > .../Library/UefiBootManagerLib/BmBoot.c | 29 +++++++++++++++--= -- > > > .../UefiBootManagerLib/UefiBootManagerLib.inf | 1 + > > > MdeModulePkg/MdeModulePkg.dec | 6 ++++ > > > MdeModulePkg/MdeModulePkg.uni | 6 ++++ > > > 4 files changed, 36 insertions(+), 6 deletions(-) > > > > > > -- > > > 2.21.0.windows.1