From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: ray.ni@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Wed, 31 Jul 2019 19:26:39 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2019 19:26:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,332,1559545200"; d="scan'208";a="201086550" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 31 Jul 2019 19:26:38 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 31 Jul 2019 19:26:37 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 31 Jul 2019 19:26:37 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.62]) with mapi id 14.03.0439.000; Thu, 1 Aug 2019 10:26:35 +0800 From: "Ni, Ray" To: "Kinney, Michael D" , "Gao, Liming" , "devel@edk2.groups.io" CC: "Dong, Eric" , Laszlo Ersek Subject: Re: [PATCH V2 5/6] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg to MdePkg Thread-Topic: [PATCH V2 5/6] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg to MdePkg Thread-Index: AQHVQgbAogcK2schRUq8UZx+6VE+n6biidNw//99iwCAAId7UIAATz8AgAK+W5A= Date: Thu, 1 Aug 2019 02:26:35 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C266D3D@SHSMSX104.ccr.corp.intel.com> References: <20190724100029.252404-1-ray.ni@intel.com> <20190724100029.252404-6-ray.ni@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C4F55@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C4FAC@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTE0OGVkZjEtZmM1My00ZGVlLWIzOGEtZDE0OTFkMmU5Mzc4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK1wvSEpsVkk0YUV5UW1sbCtDeGRaUVloK3FlWEhBMFJmYzhnOVZPYXF6NzhaR3lmWXIyNG8wWm5uOVFHd3RkcG4ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Mike, Thanks for the time for offline discussion. I agree with the idea to have an Intel/Cpuid.h in MdePkg/Include/Register/ = directory. Do you prefer to move Amd/Cpuid.h to MdePkg/Include/Register/ in my V3 patc= h? Thanks, Ray > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, July 31, 2019 12:31 AM > To: Gao, Liming ; Ni, Ray ; devel= @edk2.groups.io; Kinney, Michael D > > Cc: Dong, Eric ; Laszlo Ersek > Subject: RE: [PATCH V2 5/6] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg = to MdePkg >=20 > Liming, >=20 > Yes. That would be the correct include statement for > a module/lib that depends on MdePkg. >=20 > I know we have modules/libs that use the UefiCpuPkg > and use #include . If we want to > provide compatibility with all consumers of the UefiCpuPkg, > the Cpuid.h file in the UefiCpuPkg can updated to simply > include from MdePkg. We could > also choose to update those consumers to use the new path > in the MdePkg. >=20 > Mike >=20 > > -----Original Message----- > > From: Gao, Liming > > Sent: Monday, July 29, 2019 8:49 PM > > To: Kinney, Michael D ; Ni, > > Ray ; devel@edk2.groups.io > > Cc: Dong, Eric ; Laszlo Ersek > > > > Subject: RE: [PATCH V2 5/6] MdePkg/Cpuid.h: Move > > Cpuid.h from UefiCpuPkg to MdePkg > > > > Mike: > > OK. If so, the consumer code also need to obviously > > include vendor header file, such as #include > > . Right? > > > > Thanks > > Liming > > > -----Original Message----- > > > From: Kinney, Michael D > > > Sent: Tuesday, July 30, 2019 11:42 AM > > > To: Gao, Liming ; Ni, Ray > > ; > > > devel@edk2.groups.io; Kinney, Michael D > > > > > Cc: Dong, Eric ; Laszlo Ersek > > > > > Subject: RE: [PATCH V2 5/6] MdePkg/Cpuid.h: Move > > Cpuid.h from > > > UefiCpuPkg to MdePkg > > > > > > Liming, > > > > > > There is an unresolved discussion on the location of > > this file in the > > > MdePkg. I prefer a vendor name in the path. > > > > > > MdePkg/Include/Register/Intel/Cpuid.h > > > > > > Also, after this file is moved to MdePkg, we can > > enter new BZs to > > > update all the modules that call AsmCpuid and > > AsmCpuidEx to use the > > > defines and structures from Cpuid.h. > > > > > > Mike > > > > > > > -----Original Message----- > > > > From: Gao, Liming > > > > Sent: Monday, July 29, 2019 8:29 PM > > > > To: Ni, Ray ; > > devel@edk2.groups.io > > > > Cc: Kinney, Michael D ; > > Dong, Eric > > > > ; Laszlo Ersek > > > > > > Subject: RE: [PATCH V2 5/6] MdePkg/Cpuid.h: Move > > Cpuid.h from > > > > UefiCpuPkg to MdePkg > > > > > > > > The change is good to me. Reviewed-by: Liming Gao > > > > > > > > > > > > > -----Original Message----- > > > > > From: Ni, Ray > > > > > Sent: Wednesday, July 24, 2019 6:00 PM > > > > > To: devel@edk2.groups.io > > > > > Cc: Kinney, Michael D > > ; > > > > Gao, Liming > > > > > ; Dong, Eric > > > > ; Laszlo Ersek > > > > > > > > > > Subject: [PATCH V2 5/6] MdePkg/Cpuid.h: Move > > Cpuid.h > > > > from UefiCpuPkg > > > > > to MdePkg > > > > > > > > > > REF: > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2008 > > > > > > > > > > MdeModulePkg/DxeIpl needs to get CPUID output for > > CPU > > > > 5-level paging > > > > > capability detection. > > > > > > > > > > In order to use the macros/structures defined in > > > > > UefiCpuPkg/Include/Register/Cpuid.h, the patch > > moves > > > > Cpuid.h to > > > > > MdePkg/Include/Register/ directory. > > > > > > > > > > Because almost every module depends on MdePkg.dec > > in > > > > its INF file, the > > > > > move almost has no impact. > > > > > > > > > > Signed-off-by: Ray Ni > > > > > Cc: Michael D Kinney > > > > > Cc: Liming Gao > > > > > Cc: Eric Dong > > > > > Cc: Laszlo Ersek > > > > > --- > > > > > {UefiCpuPkg =3D> MdePkg}/Include/Register/Cpuid.h > > | 0 > > > > > 1 file changed, 0 insertions(+), 0 deletions(-) > > > > rename {UefiCpuPkg > > > > > =3D> MdePkg}/Include/Register/Cpuid.h (100%) > > > > > > > > > > diff --git a/UefiCpuPkg/Include/Register/Cpuid.h > > > > > b/MdePkg/Include/Register/Cpuid.h similarity > > index > > > > 100% rename from > > > > > UefiCpuPkg/Include/Register/Cpuid.h > > > > > rename to MdePkg/Include/Register/Cpuid.h > > > > > -- > > > > > 2.21.0.windows.1