From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Thu, 01 Aug 2019 00:51:35 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2019 00:51:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,333,1559545200"; d="scan'208";a="175161443" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 01 Aug 2019 00:51:33 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 1 Aug 2019 00:51:32 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 1 Aug 2019 00:51:32 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 1 Aug 2019 00:51:32 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.163]) with mapi id 14.03.0439.000; Thu, 1 Aug 2019 15:51:30 +0800 From: "Ni, Ray" To: "Dong, Eric" , "devel@edk2.groups.io" CC: Laszlo Ersek Subject: Re: [Patch 0/2] UefiCpuPkg: Default avoid print. Thread-Topic: [Patch 0/2] UefiCpuPkg: Default avoid print. Thread-Index: AQHVR3J+GP/aw17k40mspgou8ZxqsKbl6LGg Date: Thu, 1 Aug 2019 07:51:30 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C26764D@SHSMSX104.ccr.corp.intel.com> References: <20190731073502.24640-1-eric.dong@intel.com> In-Reply-To: <20190731073502.24640-1-eric.dong@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Eric, My understanding to your patch is you want to avoid printing from AP becaus= e some platforms may choose wrong DebugLib instance for the CpuFeaturePei/Dxe driver, which leads to system hang. To make the platform happy and while the value of printing the debug messag= e is less, the solution in your patch is to suppress the debug message unless a minor code change is made to turn on the debugging. Given that there are many comments/suggestions on how to implement a MP saf= e debugging infra, I don't think implementing such a MP safe debugging infra = can be quickly done. How about directly remove the debug message instead of disabling in your V2 patch? The goal of MP safe debugging infra is to provide a mechanism to print debu= g message in MP environment that doesn't depend on platform DSC library instance mapp= ing. Can you please submit a BZ to capture that and also remember to attach the = URL to this mail thread in BZ? We could use future TianoCore Design Meeting to discuss about this. Thanks, Ray > -----Original Message----- > From: Dong, Eric > Sent: Wednesday, July 31, 2019 3:35 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek > Subject: [Patch 0/2] UefiCpuPkg: Default avoid print. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1984 >=20 > Current debug message brings much restriction for the platform which use > this driver. >=20 > For PEI and DXE phase, platform mush link base DebugLib (without using an= y > pei/dxe services, even for its dependent libraries). >=20 > This patch default disable this debug message, only open it when need to > debug the related code. >=20 > Signed-off-by: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek >=20 > Eric Dong (2): > UefiCpuPkg/RegisterCpuFeaturesLib: Default avoid print. > UefiCpuPkg/PiSmmCpuDxeSmm: Default avoid print. >=20 > .../Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 4 +++- > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 4 +++- > 2 files changed, 6 insertions(+), 2 deletions(-) >=20 > -- > 2.21.0.windows.1