From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ray.ni@intel.com)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by groups.io with SMTP; Mon, 26 Aug 2019 13:35:26 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
  by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Aug 2019 13:35:25 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,433,1559545200"; 
   d="scan'208";a="181489663"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
  by fmsmga007.fm.intel.com with ESMTP; 26 Aug 2019 13:35:24 -0700
Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 26 Aug 2019 13:35:24 -0700
Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by
 FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 26 Aug 2019 13:35:24 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by
 SHSMSX154.ccr.corp.intel.com ([169.254.7.249]) with mapi id 14.03.0439.000;
 Tue, 27 Aug 2019 04:35:22 +0800
From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "tim.lewis@insyde.com"
	<tim.lewis@insyde.com>, "Kinney, Michael D" <michael.d.kinney@intel.com>
CC: "Justen, Jordan L" <jordan.l.justen@intel.com>, 'Andrew Fish'
	<afish@apple.com>
Subject: Re: [edk2-devel] [Patch][edk2-stable201908 0/2] EmulatorPkg/Win/Host: Fix image unload regression
Thread-Topic: [edk2-devel] [Patch][edk2-stable201908 0/2]
 EmulatorPkg/Win/Host: Fix image unload regression
Thread-Index: AQHVWJJepE5q5O7uJUOqwshLP6EgLKcNUoKAgACXaeA=
Date: Mon, 26 Aug 2019 20:35:22 +0000
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C29AF21@SHSMSX104.ccr.corp.intel.com>
References: <20190822023610.2068-1-michael.d.kinney@intel.com>
 <016201d55c44$e42cf220$ac86d660$@insyde.com>
In-Reply-To: <016201d55c44$e42cf220$ac86d660$@insyde.com>
Accept-Language: en-US, zh-CN
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTg0ZGJkMWMtMzdlMS00MjZjLTgwODEtMmI4ZTEzMGM1ZTIwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYWNNQ3RESlI4RjJXTHBwRmJ2S0syWWJQcnJid0hiOFVjU3dZMzViMll3RzJXREFkMmJJaGk0WUJCRDVRXC9paysifQ==
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: ray.ni@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

All,
As the package maintainer of EmulatorPkg, I should push the patches.
But I am not sure if there should be some ack from stewards regarding incl=
uding this patch in the coming stable tag.

What's the process?

Thanks,
Ray

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Tim Lewis
> Sent: Monday, August 26, 2019 12:32 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Ni, Ray <ray.ni@intel.=
com>; 'Andrew Fish' <afish@apple.com>
> Subject: Re: [edk2-devel] [Patch][edk2-stable201908 0/2] EmulatorPkg/Win=
/Host: Fix image unload regression
>=20
> Tested-by: Tim Lewis <tim.lewis@insyde.com>
>=20
> -----Original Message-----
> From: Michael D Kinney <michael.d.kinney@intel.com>
> Sent: Wednesday, August 21, 2019 7:36 PM
> To: devel@edk2.groups.io
> Cc: Jordan Justen <jordan.l.justen@intel.com>; Ray Ni <ray.ni@intel.com>=
;
> Andrew Fish <afish@apple.com>; Tim Lewis <tim.lewis@insyde.com>
> Subject: [Patch][edk2-stable201908 0/2] EmulatorPkg/Win/Host: Fix image
> unload regression
>=20
> https://bugzilla.tianocore.org/show_bug.cgi?id=3D2104
>=20
> When UEFI Applications or UEFI Drivers are unloaded, the
> PeCoffLoaderUnloadImageExtraAction() needs to unload the image using
> FreeLibrary() if the image was successfully loaded using LoadLibrrayEx()=
.
>=20
> This is a regression from the Nt32Pkg that supported unloading applicati=
ons
> and drivers as well as loading the same application or driver multiple
> times.
>=20
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Tim Lewis <tim.lewis@insyde.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>=20
> Michael D Kinney (2):
>   EmulatorPkg/Win/Host: Fix image unload regression
>   EmulatorPkg/Win/Host: Fix SecPrint() log line endings
>=20
>  EmulatorPkg/Win/Host/WinHost.c | 193 +++++++++++++++++++++++++++++----
>  1 file changed, 174 insertions(+), 19 deletions(-)
>=20
> --
> 2.21.0.windows.1
>=20
>=20
>=20
>=20