From: "Ni, Ray" <ray.ni@intel.com>
To: "afish@apple.com" <afish@apple.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"tim.lewis@insyde.com" <tim.lewis@insyde.com>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
"Justen, Jordan L" <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [Patch][edk2-stable201908 0/2] EmulatorPkg/Win/Host: Fix image unload regression
Date: Mon, 26 Aug 2019 22:03:34 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C29CA64@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <B469C798-1645-4CA1-A269-68EBD78C7AC9@apple.com>
pushed @ abc0155b03..30b4abc6e9.
> -----Original Message-----
> From: afish@apple.com <afish@apple.com>
> Sent: Monday, August 26, 2019 2:10 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; tim.lewis@insyde.com; leif.lindholm@linaro.org; Justen, Jordan L
> <jordan.l.justen@intel.com>
> Subject: Re: [edk2-devel] [Patch][edk2-stable201908 0/2] EmulatorPkg/Win/Host: Fix image unload regression
>
> Mike,
>
> I'm OK with it going in.
>
> Thanks,
>
> Andrew Fish
>
> > On Aug 26, 2019, at 2:01 PM, Kinney, Michael D <michael.d.kinney@intel.com> wrote:
> >
> > Ray,
> >
> > Laszlo and I are OK with this change going into the stable tag.
> >
> > I would like to a response from Andrew or Leif.
> >
> > Mike
> >
> >> -----Original Message-----
> >> From: Ni, Ray
> >> Sent: Monday, August 26, 2019 1:35 PM
> >> To: devel@edk2.groups.io; tim.lewis@insyde.com; Kinney,
> >> Michael D <michael.d.kinney@intel.com>
> >> Cc: Justen, Jordan L <jordan.l.justen@intel.com>;
> >> 'Andrew Fish' <afish@apple.com>
> >> Subject: RE: [edk2-devel] [Patch][edk2-stable201908 0/2]
> >> EmulatorPkg/Win/Host: Fix image unload regression
> >>
> >> All,
> >> As the package maintainer of EmulatorPkg, I should push
> >> the patches.
> >> But I am not sure if there should be some ack from
> >> stewards regarding including this patch in the coming
> >> stable tag.
> >>
> >> What's the process?
> >>
> >> Thanks,
> >> Ray
> >>
> >>> -----Original Message-----
> >>> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> >> Behalf Of Tim
> >>> Lewis
> >>> Sent: Monday, August 26, 2019 12:32 PM
> >>> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> >>> devel@edk2.groups.io
> >>> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Ni,
> >> Ray
> >>> <ray.ni@intel.com>; 'Andrew Fish' <afish@apple.com>
> >>> Subject: Re: [edk2-devel] [Patch][edk2-stable201908
> >> 0/2]
> >>> EmulatorPkg/Win/Host: Fix image unload regression
> >>>
> >>> Tested-by: Tim Lewis <tim.lewis@insyde.com>
> >>>
> >>> -----Original Message-----
> >>> From: Michael D Kinney <michael.d.kinney@intel.com>
> >>> Sent: Wednesday, August 21, 2019 7:36 PM
> >>> To: devel@edk2.groups.io
> >>> Cc: Jordan Justen <jordan.l.justen@intel.com>; Ray Ni
> >>> <ray.ni@intel.com>; Andrew Fish <afish@apple.com>; Tim
> >> Lewis
> >>> <tim.lewis@insyde.com>
> >>> Subject: [Patch][edk2-stable201908 0/2]
> >> EmulatorPkg/Win/Host: Fix
> >>> image unload regression
> >>>
> >>> https://bugzilla.tianocore.org/show_bug.cgi?id=2104
> >>>
> >>> When UEFI Applications or UEFI Drivers are unloaded,
> >> the
> >>> PeCoffLoaderUnloadImageExtraAction() needs to unload
> >> the image using
> >>> FreeLibrary() if the image was successfully loaded
> >> using LoadLibrrayEx().
> >>>
> >>> This is a regression from the Nt32Pkg that supported
> >> unloading
> >>> applications and drivers as well as loading the same
> >> application or
> >>> driver multiple times.
> >>>
> >>> Cc: Jordan Justen <jordan.l.justen@intel.com>
> >>> Cc: Ray Ni <ray.ni@intel.com>
> >>> Cc: Andrew Fish <afish@apple.com>
> >>> Cc: Tim Lewis <tim.lewis@insyde.com>
> >>> Signed-off-by: Michael D Kinney
> >> <michael.d.kinney@intel.com>
> >>>
> >>> Michael D Kinney (2):
> >>> EmulatorPkg/Win/Host: Fix image unload regression
> >>> EmulatorPkg/Win/Host: Fix SecPrint() log line
> >> endings
> >>>
> >>> EmulatorPkg/Win/Host/WinHost.c | 193
> >>> +++++++++++++++++++++++++++++----
> >>> 1 file changed, 174 insertions(+), 19 deletions(-)
> >>>
> >>> --
> >>> 2.21.0.windows.1
> >>>
> >>>
> >>>
> >>>
> >
prev parent reply other threads:[~2019-08-26 22:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 2:36 [Patch][edk2-stable201908 0/2] EmulatorPkg/Win/Host: Fix image unload regression Michael D Kinney
2019-08-22 2:36 ` [Patch][edk2-stable201908 1/2] " Michael D Kinney
2019-08-22 23:10 ` [edk2-devel] " Ni, Ray
2019-08-22 2:36 ` [Patch][edk2-stable201908 2/2] EmulatorPkg/Win/Host: Fix SecPrint() log line endings Michael D Kinney
2019-08-22 23:12 ` [edk2-devel] " Ni, Ray
2019-08-26 19:31 ` [Patch][edk2-stable201908 0/2] EmulatorPkg/Win/Host: Fix image unload regression Tim Lewis
2019-08-26 20:35 ` [edk2-devel] " Ni, Ray
2019-08-26 21:01 ` Michael D Kinney
2019-08-26 21:10 ` Andrew Fish
2019-08-26 22:03 ` Ni, Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C29CA64@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox